You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@iggy.apache.org by "ethanlin01x (via GitHub)" <gi...@apache.org> on 2026/08/07 15:40:20 UTC
[PR] feat(ci): require bash >= 4.2 in the pre-commit hook scripts [iggy]
ethanlin01x opened a new pull request, #3837:
URL: https://github.com/apache/iggy/pull/3837
## Which issue does this PR address?
Related: #3694
## Rationale
Without a declared minimum, every hook script has to be written against bash 3.2 and carry portable fallbacks (#3694). Checking the version once, up front, means anyone writing a hook script from now on can use modern bash without thinking about it.
## What changed?
1. `scripts/ci/lib/init.sh` checks for bash >= 4.2 and is sourced by the 13 script-backed hooks, so a future check reaches all of them from one place.
2. The 16 scripts on `#!/bin/bash` are normalized to `#!/usr/bin/env bash` first, since on macOS the former is always the system bash 3.2 and no `brew install bash` can override it.
## Local Execution
- Passed
- Pre-commit hooks ran
## AI Usage
If AI tools were used, please answer:
1. Which tools? Claude Code
2. Scope of usage? Implementation
3. How did you verify the generated code works correctly? Ran the hooks under both bash 3.2 and bash 5,
4. Can you explain every line of the code if asked? Yes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(ci): require bash >= 4.2 in the pre-commit hook scripts [iggy]
Posted by "ethanlin01x (via GitHub)" <gi...@apache.org>.
ethanlin01x commented on PR #3837:
URL: https://github.com/apache/iggy/pull/3837#issuecomment-5219163406
/request-review @numinnex
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(ci): require bash >= 4.2 in the pre-commit hook scripts [iggy]
Posted by "hubcio (via GitHub)" <gi...@apache.org>.
hubcio merged PR #3837:
URL: https://github.com/apache/iggy/pull/3837
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(ci): require bash >= 4.2 in the pre-commit hook scripts [iggy]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #3837:
URL: https://github.com/apache/iggy/pull/3837#issuecomment-5219112329
## [Codecov](https://app.codecov.io/gh/apache/iggy/pull/3837?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 74.39%. Comparing base ([`360ee7e`](https://app.codecov.io/gh/apache/iggy/commit/360ee7ed6753136029de554b3fcf140f882ba9b3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`2ee721c`](https://app.codecov.io/gh/apache/iggy/commit/2ee721c09423e6acd9a47c8de2d4ca81ca1f7d0c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #3837 +/- ##
============================================
- Coverage 75.89% 74.39% -1.51%
Complexity 1046 1046
============================================
Files 1337 1337
Lines 169995 169995
Branches 142351 142425 +74
============================================
- Hits 129016 126465 -2551
- Misses 37177 39821 +2644
+ Partials 3802 3709 -93
```
| [Components](https://app.codecov.io/gh/apache/iggy/pull/3837/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [Rust Core](https://app.codecov.io/gh/apache/iggy/pull/3837/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `75.79% <ø> (ø)` | |
| [Java SDK](https://app.codecov.io/gh/apache/iggy/pull/3837/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `63.67% <ø> (ø)` | |
| [C# SDK](https://app.codecov.io/gh/apache/iggy/pull/3837/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.11% <ø> (-39.15%)` | :arrow_down: |
| [Python SDK](https://app.codecov.io/gh/apache/iggy/pull/3837/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `88.14% <ø> (ø)` | |
| [PHP SDK](https://app.codecov.io/gh/apache/iggy/pull/3837/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `82.97% <ø> (ø)` | |
| [Node SDK](https://app.codecov.io/gh/apache/iggy/pull/3837/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `96.28% <ø> (ø)` | |
| [Go SDK](https://app.codecov.io/gh/apache/iggy/pull/3837/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `43.08% <ø> (ø)` | |
[see 70 files with indirect coverage changes](https://app.codecov.io/gh/apache/iggy/pull/3837/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(ci): require bash >= 4.2 in the pre-commit hook scripts [iggy]
Posted by "ethanlin01x (via GitHub)" <gi...@apache.org>.
ethanlin01x commented on PR #3837:
URL: https://github.com/apache/iggy/pull/3837#issuecomment-5219155703
/request-review @hubcio
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org