You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "claudio4j (via GitHub)" <gi...@apache.org> on 2024/01/24 12:53:35 UTC

[PR] The camel-quarkus dependencies must come exclusively from quarkus-camel-bom [camel-k-runtime]

claudio4j opened a new pull request, #1156:
URL: https://github.com/apache/camel-k-runtime/pull/1156

   <!--
   Enter your extended release note in the below block. If the PR requires
   additional action from users switching to the new release, include the string
   "action required". If no release note is required, write "NONE". 
   
   You can (optionally) mark this PR with labels "kind/bug" or "kind/feature" to make sure
   the text is added to the right section of the release notes. 
   -->
   
   **Release Note**
   ```release-note
   NONE
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] The camel-quarkus dependencies must come exclusively from quarkus-camel-bom [camel-k-runtime]

Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on code in PR #1156:
URL: https://github.com/apache/camel-k-runtime/pull/1156#discussion_r1464970341


##########
support/camel-k-maven-plugin/src/it/generate-catalog/verify.groovy:
##########
@@ -21,9 +21,6 @@ new File(basedir, "catalog.yaml").withReader {
     assert catalog.spec.runtime.version == runtimeVersion
     assert catalog.spec.runtime.applicationClass == 'io.quarkus.bootstrap.runner.QuarkusEntryPoint'
     assert catalog.spec.runtime.metadata['camel.version'] == camelVersion
-    // Re-enabled this when the version will be the same again
-    //assert catalog.spec.runtime.metadata['quarkus.version'] == quarkusVersion
-    assert catalog.spec.runtime.metadata['camel-quarkus.version'] == camelQuarkusVersion

Review Comment:
   This is needed by the operator!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] The camel-quarkus dependencies must come exclusively from quarkus-camel-bom [camel-k-runtime]

Posted by "claudio4j (via GitHub)" <gi...@apache.org>.
claudio4j merged PR #1156:
URL: https://github.com/apache/camel-k-runtime/pull/1156


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] The camel-quarkus dependencies must come exclusively from quarkus-camel-bom [camel-k-runtime]

Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on PR #1156:
URL: https://github.com/apache/camel-k-runtime/pull/1156#issuecomment-1908206969

   There are breaking compatibility changes with the operator. Please, revert.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org