You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Alexei Fedotov (JIRA)" <ji...@apache.org> on 2007/08/18 15:30:33 UTC
[jira] Created: (HARMONY-4649) [p-unit] memory utils, fixes
[p-unit] memory utils, fixes
----------------------------
Key: HARMONY-4649
URL: https://issues.apache.org/jira/browse/HARMONY-4649
Project: Harmony
Issue Type: Improvement
Reporter: Alexei Fedotov
Andrey, sorry for delay. Here go some improvements.
* Added junit-style shouldStop() method to detect timeout expiration from inside the test
* Allocate thread objects once for all test iterations.
* Replaced logger.* and assert.* domains with sensible ones.
* Slightly corrected messages in float and double asserts.
* Fixed testInstance allocation: allocate it once for class (as it is done in ng-unit).
* Improved memory deallocation algorithm in MemoryUtil.clear() to free objects with finalizers on RI, added wilderness utilities and maximum total memory calculation. Restored org.punit.exception.OutOfMemoryException. Added related test.
* Fixed Maximum/Minimum watcher value accumulation in case when _scale changes.
* Fixed formatting and tabs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (HARMONY-4649) [p-unit] memory utils, fixes
Posted by "Alexei Fedotov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexei Fedotov closed HARMONY-4649.
-----------------------------------
Resolution: Fixed
The patch was coommitted to the p-unit repository.
> [p-unit] memory utils, fixes
> ----------------------------
>
> Key: HARMONY-4649
> URL: https://issues.apache.org/jira/browse/HARMONY-4649
> Project: Harmony
> Issue Type: Improvement
> Components: Misc
> Reporter: Alexei Fedotov
>
> Andrew, sorry for delay. Here go some improvements.
> * Added junit-style shouldStop() method to detect timeout expiration from inside the test
> * Allocate thread objects once for all test iterations.
> * Replaced logger.* and assert.* domains with sensible ones.
> * Slightly corrected messages in float and double asserts.
> * Fixed testInstance allocation: allocate it once for class (as it is done in ng-unit).
> * Improved memory deallocation algorithm in MemoryUtil.clear() to free objects with finalizers on RI, added wilderness utilities and maximum total memory calculation. Restored org.punit.exception.OutOfMemoryException. Added related test.
> * Fixed Maximum/Minimum watcher value accumulation in case when _scale changes.
> * Fixed formatting and tabs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-4649) [p-unit] memory utils, fixes
Posted by "Alexei Fedotov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexei Fedotov updated HARMONY-4649:
------------------------------------
Component/s: Misc
> [p-unit] memory utils, fixes
> ----------------------------
>
> Key: HARMONY-4649
> URL: https://issues.apache.org/jira/browse/HARMONY-4649
> Project: Harmony
> Issue Type: Improvement
> Components: Misc
> Reporter: Alexei Fedotov
>
> Andrew, sorry for delay. Here go some improvements.
> * Added junit-style shouldStop() method to detect timeout expiration from inside the test
> * Allocate thread objects once for all test iterations.
> * Replaced logger.* and assert.* domains with sensible ones.
> * Slightly corrected messages in float and double asserts.
> * Fixed testInstance allocation: allocate it once for class (as it is done in ng-unit).
> * Improved memory deallocation algorithm in MemoryUtil.clear() to free objects with finalizers on RI, added wilderness utilities and maximum total memory calculation. Restored org.punit.exception.OutOfMemoryException. Added related test.
> * Fixed Maximum/Minimum watcher value accumulation in case when _scale changes.
> * Fixed formatting and tabs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-4649) [p-unit] memory utils, fixes
Posted by "Andrew Zhang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12521000 ]
Andrew Zhang commented on HARMONY-4649:
---------------------------------------
Hi Alexei,
Excellent! Thanks for the improvement. I only have one question about the commit:
* Fixed testInstance allocation: allocate it once for class (as it is done in ng-unit).
Where's the exact code? Does it mean that the test methods will affect each other?
Best regards,
Andrew
> [p-unit] memory utils, fixes
> ----------------------------
>
> Key: HARMONY-4649
> URL: https://issues.apache.org/jira/browse/HARMONY-4649
> Project: Harmony
> Issue Type: Improvement
> Components: Misc
> Reporter: Alexei Fedotov
>
> Andrew, sorry for delay. Here go some improvements.
> * Added junit-style shouldStop() method to detect timeout expiration from inside the test
> * Allocate thread objects once for all test iterations.
> * Replaced logger.* and assert.* domains with sensible ones.
> * Slightly corrected messages in float and double asserts.
> * Fixed testInstance allocation: allocate it once for class (as it is done in ng-unit).
> * Improved memory deallocation algorithm in MemoryUtil.clear() to free objects with finalizers on RI, added wilderness utilities and maximum total memory calculation. Restored org.punit.exception.OutOfMemoryException. Added related test.
> * Fixed Maximum/Minimum watcher value accumulation in case when _scale changes.
> * Fixed formatting and tabs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-4649) [p-unit] memory utils, fixes
Posted by "Alexei Fedotov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexei Fedotov updated HARMONY-4649:
------------------------------------
Description:
Andrew, sorry for delay. Here go some improvements.
* Added junit-style shouldStop() method to detect timeout expiration from inside the test
* Allocate thread objects once for all test iterations.
* Replaced logger.* and assert.* domains with sensible ones.
* Slightly corrected messages in float and double asserts.
* Fixed testInstance allocation: allocate it once for class (as it is done in ng-unit).
* Improved memory deallocation algorithm in MemoryUtil.clear() to free objects with finalizers on RI, added wilderness utilities and maximum total memory calculation. Restored org.punit.exception.OutOfMemoryException. Added related test.
* Fixed Maximum/Minimum watcher value accumulation in case when _scale changes.
* Fixed formatting and tabs.
was:
Andrey, sorry for delay. Here go some improvements.
* Added junit-style shouldStop() method to detect timeout expiration from inside the test
* Allocate thread objects once for all test iterations.
* Replaced logger.* and assert.* domains with sensible ones.
* Slightly corrected messages in float and double asserts.
* Fixed testInstance allocation: allocate it once for class (as it is done in ng-unit).
* Improved memory deallocation algorithm in MemoryUtil.clear() to free objects with finalizers on RI, added wilderness utilities and maximum total memory calculation. Restored org.punit.exception.OutOfMemoryException. Added related test.
* Fixed Maximum/Minimum watcher value accumulation in case when _scale changes.
* Fixed formatting and tabs.
> [p-unit] memory utils, fixes
> ----------------------------
>
> Key: HARMONY-4649
> URL: https://issues.apache.org/jira/browse/HARMONY-4649
> Project: Harmony
> Issue Type: Improvement
> Components: Misc
> Reporter: Alexei Fedotov
>
> Andrew, sorry for delay. Here go some improvements.
> * Added junit-style shouldStop() method to detect timeout expiration from inside the test
> * Allocate thread objects once for all test iterations.
> * Replaced logger.* and assert.* domains with sensible ones.
> * Slightly corrected messages in float and double asserts.
> * Fixed testInstance allocation: allocate it once for class (as it is done in ng-unit).
> * Improved memory deallocation algorithm in MemoryUtil.clear() to free objects with finalizers on RI, added wilderness utilities and maximum total memory calculation. Restored org.punit.exception.OutOfMemoryException. Added related test.
> * Fixed Maximum/Minimum watcher value accumulation in case when _scale changes.
> * Fixed formatting and tabs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-4649) [p-unit] memory utils, fixes
Posted by "Alexei Fedotov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12524754 ]
Alexei Fedotov commented on HARMONY-4649:
-----------------------------------------
Andrew, I'm back.
This does not necessary mean that they will affect each other. If they
do not set up things correctly assuming zero fields values, than this
could be. If you think this is feasible, I may change this back to
JUnit style. Now I see how to make things work for this case as well.
Please, check [1] for a related discussion:
[1] http://www.beust.com/weblog/archives/000082.html
--
With best regards,
Alexei,
ESSD, Intel
> [p-unit] memory utils, fixes
> ----------------------------
>
> Key: HARMONY-4649
> URL: https://issues.apache.org/jira/browse/HARMONY-4649
> Project: Harmony
> Issue Type: Improvement
> Components: Misc
> Reporter: Alexei Fedotov
>
> Andrew, sorry for delay. Here go some improvements.
> * Added junit-style shouldStop() method to detect timeout expiration from inside the test
> * Allocate thread objects once for all test iterations.
> * Replaced logger.* and assert.* domains with sensible ones.
> * Slightly corrected messages in float and double asserts.
> * Fixed testInstance allocation: allocate it once for class (as it is done in ng-unit).
> * Improved memory deallocation algorithm in MemoryUtil.clear() to free objects with finalizers on RI, added wilderness utilities and maximum total memory calculation. Restored org.punit.exception.OutOfMemoryException. Added related test.
> * Fixed Maximum/Minimum watcher value accumulation in case when _scale changes.
> * Fixed formatting and tabs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.