You are viewing a plain text version of this content. The canonical link for it is here.
Posted to modperl-cvs@perl.apache.org by do...@apache.org on 2002/05/31 01:57:50 UTC

cvs commit: modperl-2.0/t/response/TestDirective perlmodule.pm perlrequire.pm

dougm       02/05/30 16:57:50

  Modified:    t/response/TestDirective perlmodule.pm perlrequire.pm
  Log:
  -Mlib= is broken on darwin/5.6.0, change to -I which works everywhere
  
  Revision  Changes    Path
  1.5       +1 -1      modperl-2.0/t/response/TestDirective/perlmodule.pm
  
  Index: perlmodule.pm
  ===================================================================
  RCS file: /home/cvs/modperl-2.0/t/response/TestDirective/perlmodule.pm,v
  retrieving revision 1.4
  retrieving revision 1.5
  diff -u -r1.4 -r1.5
  --- perlmodule.pm	11 Apr 2002 11:08:44 -0000	1.4
  +++ perlmodule.pm	30 May 2002 23:57:50 -0000	1.5
  @@ -46,7 +46,7 @@
   1;
   __END__
   <Base>
  -    PerlSwitches -Mlib=@documentroot@/testdirective/perlmodule-vh
  +    PerlSwitches -I@documentroot@/testdirective/perlmodule-vh
   </Base>
   
   <VirtualHost TestDirective::perlmodule>
  
  
  
  1.8       +3 -3      modperl-2.0/t/response/TestDirective/perlrequire.pm
  
  Index: perlrequire.pm
  ===================================================================
  RCS file: /home/cvs/modperl-2.0/t/response/TestDirective/perlrequire.pm,v
  retrieving revision 1.7
  retrieving revision 1.8
  diff -u -r1.7 -r1.8
  --- perlrequire.pm	11 Apr 2002 11:08:44 -0000	1.7
  +++ perlrequire.pm	30 May 2002 23:57:50 -0000	1.8
  @@ -57,7 +57,7 @@
   1;
   __END__
   <Base>
  -    PerlSwitches -Mlib=@documentroot@/testdirective/main
  +    PerlSwitches -I@documentroot@/testdirective/main
       PerlRequire "ApacheTest/PerlRequireTest.pm"
   </Base>
   
  @@ -69,10 +69,10 @@
       </IfDefine>
   
       # use test system's @INC
  -    PerlSwitches -Mlib=@serverroot@
  +    PerlSwitches -I@serverroot@
       PerlRequire "conf/modperl_startup.pl"
   
  -    PerlSwitches -Mlib=@documentroot@/testdirective/vh
  +    PerlSwitches -I@documentroot@/testdirective/vh
       PerlRequire "ApacheTest/PerlRequireTest.pm"
   
       <Location /TestDirective::perlrequire>
  
  
  

Re: cvs commit: modperl-2.0/t/response/TestDirective perlmodule.pm perlrequire.pm

Posted by Doug MacEachern <do...@covalent.net>.
On Mon, 3 Jun 2002, Stas Bekman wrote:
 
> The good thing about lib.pm is that it removes duplicates if any.

sure.  the bad thing is it is much more expensive and bloated.  all the 
stats and 'use Config'.
 
> I've changed the docs to say:
> 
> As an alternative to using C<use lib> in I<startup.pl> to adjust
> C<@INC>, now you can use the command line switch C<-I> to do that:
> 
>    PerlSwitches -I/home/stas/modperl
> 
> You could also use C<-Mlib=/home/stas/modperl> which is the exact
> equivalent as C<use lib>, but it's broken on certain platforms/version
> (e.g. Darwin/5.6.0). C<use lib> is removing duplicated entries,
> whereas C<-I> does not.

i wouldn't bother documenting brokeness on darwin here.



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Re: cvs commit: modperl-2.0/t/response/TestDirective perlmodule.pm perlrequire.pm

Posted by Stas Bekman <st...@stason.org>.
Doug MacEachern wrote:
> On Sun, 2 Jun 2002, Stas Bekman wrote:
>  
> 
>>Should the same change be applied for -Mblib, which you have used for 
>>demonstrating different @INC in two vhosts? I know it's not same as 
>>-Mlib=, the question is whether -Mblib works on darwin/5.6.0
> 
> 
> nope, seems it was only the case i changed caused breakage, no idea why.
> but now we are testing both -I and -Mblib, which is good.

The good thing about lib.pm is that it removes duplicates if any.

I've changed the docs to say:

As an alternative to using C<use lib> in I<startup.pl> to adjust
C<@INC>, now you can use the command line switch C<-I> to do that:

   PerlSwitches -I/home/stas/modperl

You could also use C<-Mlib=/home/stas/modperl> which is the exact
equivalent as C<use lib>, but it's broken on certain platforms/version
(e.g. Darwin/5.6.0). C<use lib> is removing duplicated entries,
whereas C<-I> does not.
__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Re: cvs commit: modperl-2.0/t/response/TestDirective perlmodule.pm perlrequire.pm

Posted by Doug MacEachern <do...@covalent.net>.
On Sun, 2 Jun 2002, Stas Bekman wrote:
 
> Should the same change be applied for -Mblib, which you have used for 
> demonstrating different @INC in two vhosts? I know it's not same as 
> -Mlib=, the question is whether -Mblib works on darwin/5.6.0

nope, seems it was only the case i changed caused breakage, no idea why.
but now we are testing both -I and -Mblib, which is good.



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Re: cvs commit: modperl-2.0/t/response/TestDirective perlmodule.pm perlrequire.pm

Posted by Stas Bekman <st...@stason.org>.
dougm@apache.org wrote:
> dougm       02/05/30 16:57:50
> 
>   Modified:    t/response/TestDirective perlmodule.pm perlrequire.pm
>   Log:
>   -Mlib= is broken on darwin/5.6.0, change to -I which works everywhere

Should the same change be applied for -Mblib, which you have used for 
demonstrating different @INC in two vhosts? I know it's not same as 
-Mlib=, the question is whether -Mblib works on darwin/5.6.0

__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org