You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zeppelin.apache.org by zjffdu <gi...@git.apache.org> on 2018/06/25 06:06:00 UTC

[GitHub] zeppelin pull request #3042: ZEPPELIN-3560. DisplayName in dynamic forms doe...

GitHub user zjffdu opened a pull request:

    https://github.com/apache/zeppelin/pull/3042

    ZEPPELIN-3560. DisplayName in dynamic forms doesn't work

    ### What is this PR for?
    
    Use the displayName as the label instead of name. 
    
    
    ### What type of PR is it?
    [Bug Fix]
    
    ### Todos
    * [ ] - Task
    
    ### What is the Jira issue?
    * https://issues.apache.org/jira/browse/ZEPPELIN-3560
    
    ### Screenshots (if appropriate)
    Before
    ![screen shot 2018-06-25 at 2 03 29 pm](https://user-images.githubusercontent.com/164491/41832928-d47c7f88-7880-11e8-920e-844828e9b1ef.png)
    
    After
    ![screen shot 2018-06-25 at 2 02 55 pm](https://user-images.githubusercontent.com/164491/41832931-d8079c6e-7880-11e8-9f7b-558a93accd4d.png)
    
    ### Questions:
    * Does the licenses files need update?
    * Is there breaking changes for older versions?
    * Does this needs documentation?


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-3560

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/3042.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3042
    
----
commit 297d7032032d0bd2c9067bba8315f3e2135315af
Author: Jeff Zhang <zj...@...>
Date:   2018-06-25T06:04:26Z

    ZEPPELIN-3560. DisplayName in dynamic forms doesn't work

----


---

[GitHub] zeppelin issue #3042: ZEPPELIN-3560. DisplayName in dynamic forms doesn't wo...

Posted by zjffdu <gi...@git.apache.org>.

Github user zjffdu commented on the issue:

    https://github.com/apache/zeppelin/pull/3042
  
    @prabhjyotsingh Could you help review it ? Thanks


---

[GitHub] zeppelin pull request #3042: ZEPPELIN-3560. DisplayName in dynamic forms doe...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/3042


---

[GitHub] zeppelin issue #3042: ZEPPELIN-3560. DisplayName in dynamic forms doesn't wo...

Posted by prabhjyotsingh <gi...@git.apache.org>.

Github user prabhjyotsingh commented on the issue:

    https://github.com/apache/zeppelin/pull/3042
  
    Tested on local, works as expected, LGTM.


---