[GitHub] [tez] guptanikhil007 commented on a diff in pull request #215: TEZ-4419: Upgrade node and yarn version and fix npm security issues in Tez UI module

[GitBox <gi...@apache.org>]

guptanikhil007 commented on code in PR #215:
URL: https://github.com/apache/tez/pull/215#discussion_r890218743


##########
pom.xml:
##########
@@ -67,7 +67,7 @@
     <roaringbitmap.version>0.7.45</roaringbitmap.version>
     <protoc.path>${env.PROTOC_PATH}</protoc.path>
     <scm.url>scm:git:https://gitbox.apache.org/repos/asf/tez.git</scm.url>
-    <frontend-maven-plugin.version>1.4</frontend-maven-plugin.version>
+    <frontend-maven-plugin.version>1.8.0</frontend-maven-plugin.version>

Review Comment:
   Please change this to 1.12.1



##########
tez-ui/pom.xml:
##########
@@ -374,7 +374,7 @@
             </goals>
             <configuration>
               <nodeVersion>${nodeVersion}</nodeVersion>
-              <yarnVersion>v0.21.3</yarnVersion>
+              <yarnVersion>v1.6.0</yarnVersion>

Review Comment:
   Please mention the RFC which adds selective dependency resolution in the description.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@tez.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org