[GitHub] [spark] LuciferYang commented on a diff in pull request #38041: [SPARK-40605][CONNECT] Change to use `log4j2.properties` to configure test log output

[GitBox <gi...@apache.org>]

LuciferYang commented on code in PR #38041:
URL: https://github.com/apache/spark/pull/38041#discussion_r983019642


##########
connect/src/test/scala/org/apache/spark/sql/connect/planner/SparkConnectPlannerSuite.scala:
##########
@@ -58,11 +58,6 @@ class SparkConnectPlannerSuite extends SparkFunSuite with SparkConnectPlanTest {
 
   protected var spark: SparkSession = null
 
-  override def beforeAll(): Unit = {
-    super.beforeAll()
-    TestUtils.configTestLog4j2("INFO")

Review Comment:
   `TestUtils.configTestLog4j2` always print log to console, some noises. I So I think it is better not to use this method unless debugging for something.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org