[GitHub] [netbeans] eirikbakke opened a new pull request #1273: [NETBEANS-2614, NETBEANS-1586] Improve icon scaling on HiDPI displays, and prepare ImageUtilities for HiDPI icons

[GitBox <gi...@apache.org>]

eirikbakke opened a new pull request #1273: [NETBEANS-2614,NETBEANS-1586] Improve icon scaling on HiDPI displays, and prepare ImageUtilities for HiDPI icons
URL: https://github.com/apache/netbeans/pull/1273
 
 
   This PR contains most of the changes that are needed to make ImageUtilities work with HiDPI icons. No publicly visible API changes are needed; the old javax.swing.Icon interface is actually well-suited for providing scalable graphics. The main challenge is to ensure that conversions between javax.swing.Icon and java.awt.Image, which are frequent throughout the NetBeans codebase, always retain the underlying scalable Icon instance.
   
   The main motivation for this PR is to enable SVG icon support, which I will contribute in a separate PR. There's an added bonus, though: With all icon painting now centralized through ImageUtilities.ToolTipImage.paintIcon, we can add some rendering tweaks that make existing low-resolution icons look slightly better on HiDPI displays. See the attached before/after screenshots.
   
   This issue is tracked under https://issues.apache.org/jira/browse/NETBEANS-2614 . SVG icon support is tracked under https://issues.apache.org/jira/browse/NETBEANS-2604 .
   
   To make reviewing easier, I have split up this PR into several commits, which can be reviewed one-at-a-time.
   
   ![Windows 150pct HiDPI Scaling, After Patch](https://user-images.githubusercontent.com/886243/58670469-347e0b80-830d-11e9-833c-0a5a6f05aa73.png)
   ![Windows 150pct HiDPI Scaling, Before Patch](https://user-images.githubusercontent.com/886243/58670470-347e0b80-830d-11e9-95be-ffa639af71a1.png)
   ![Windows 200pct HiDPI Scaling, After Patch](https://user-images.githubusercontent.com/886243/58670471-347e0b80-830d-11e9-8bb9-3f374a5d92aa.png)
   ![Windows 200pct HiDPI Scaling, Before Patch](https://user-images.githubusercontent.com/886243/58670472-347e0b80-830d-11e9-9958-3af50e2a4be1.png)
   
   
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists