You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2020/06/04 09:23:21 UTC
[GitHub] [incubator-echarts] regrex opened a new pull request #12754: Funnel chart support orient API
regrex opened a new pull request #12754:
URL: https://github.com/apache/incubator-echarts/pull/12754
<!-- Please fill in the following information to help us review your PR more efficiently. -->
## Brief Information
This pull request is in the type of:
- [ ] bug fixing
- [x] new feature
- [ ] others
### What does this PR do?
<!-- USE ONCE SENTENCE TO DESCRIBE WHAT THIS PR DOES. -->
Funnel chart support orient API with value vertical(default) or horizontal.
### Fixed issues
<!--
- #xxxx: ...
-->
## Details
## Usage
### Are there any API changes?
- [x] The API has been changed.
<!-- LIST THE API CHANGES HERE -->
series-funnel.orient: vertical | horizontal
### Related test cases or examples to use the new APIs
NA.
```javascript
option = {
series: [
{
name:'漏斗图',
type:'funnel',
gap: 3,
left: 300,
right: 300,
orient: 'horizontal', // vertical | horizontal, default value is vertical
label: {
normal: {
position: 'leftTop'
}
},
data:[
{value:60, name:'访问'},
{value:40, name:'咨询'},
{value:20, name:'订单'},
{value:80, name:'点击'},
]
}
]
}
```
## Others
### Merging options
- [x] Please squash the commits into a single one when merge.
### Other information
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] 100pah commented on pull request #12754: feat(funnel): funnel chart support orient API
Posted by GitBox <gi...@apache.org>.
100pah commented on pull request #12754:
URL: https://github.com/apache/incubator-echarts/pull/12754#issuecomment-641024308
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] 100pah commented on a change in pull request #12754: feat(funnel): funnel chart support orient API
Posted by GitBox <gi...@apache.org>.
100pah commented on a change in pull request #12754:
URL: https://github.com/apache/incubator-echarts/pull/12754#discussion_r437126955
##########
File path: test/funnel.html
##########
@@ -86,9 +86,10 @@
left: 300,
right: 300,
sort: 'ascending',
+ orient: 'horizontal',
Review comment:
We should better add some new test cases for `orient: 'horizontal'` rather than change the original 'vertical' test cases.
Hint: in echarts source dir,
```shell
npm run mktest funnel2
```
will generate a test caes file `test/funnel2.html`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] regrex commented on pull request #12754: feat(funnel): funnel chart support orient API
Posted by GitBox <gi...@apache.org>.
regrex commented on pull request #12754:
URL: https://github.com/apache/incubator-echarts/pull/12754#issuecomment-641697807
@100pah
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] echarts-bot[bot] commented on pull request #12754: feat(funnel): funnel chart support orient API
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #12754:
URL: https://github.com/apache/incubator-echarts/pull/12754#issuecomment-669074762
Congratulations! Your PR has been merged. Thanks for your contribution! 👍
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] regrex edited a comment on pull request #12754: feat(funnel): funnel chart support orient API
Posted by GitBox <gi...@apache.org>.
regrex edited a comment on pull request #12754:
URL: https://github.com/apache/incubator-echarts/pull/12754#issuecomment-641697807
@100pah I have also considered this problem. At the beginning, my plan is to increase the value of position for the original scenario of horizontal: top \ bottom \ topleft \ topright \ bottomleft \ bottomright. But later, considering that users need to associate two APIs to view documents at the same time, it simplifies the design of position. When the original is horizontal, I think it is to connect the entire entire funnel Chart rotates 90 degrees anticlockwise, and the left value of position corresponds to the bottom value of horizontal. At present, my mapping relationship implementation is a bit messy, which needs to be adjusted.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] 100pah merged pull request #12754: feat(funnel): funnel chart support orient API
Posted by GitBox <gi...@apache.org>.
100pah merged pull request #12754:
URL: https://github.com/apache/incubator-echarts/pull/12754
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] 100pah edited a comment on pull request #12754: feat(funnel): funnel chart support orient API
Posted by GitBox <gi...@apache.org>.
100pah edited a comment on pull request #12754:
URL: https://github.com/apache/incubator-echarts/pull/12754#issuecomment-641024308
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org