You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by robertwb <gi...@git.apache.org> on 2016/10/19 00:11:20 UTC
[GitHub] incubator-beam pull request #1132: Close threadpools when finished with them
GitHub user robertwb opened a pull request:
https://github.com/apache/incubator-beam/pull/1132
Close threadpools when finished with them
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
---
This avoids building up an arbitrary number of dangling threads,
which can cause issues in testing and is undesirable in production.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/robertwb/incubator-beam threadpools
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/1132.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1132
----
commit 4adccb28d84fda8791f58e5e59ef24509f3dc81f
Author: Robert Bradshaw <ro...@google.com>
Date: 2016-10-19T00:08:18Z
Close threadpools when finished with them
This avoids building up an arbitrary number of dangling threads,
which can cause issues in testing and is undesirable in production.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-beam pull request #1132: Close threadpools when finished with them
Posted by robertwb <gi...@git.apache.org>.
Github user robertwb closed the pull request at:
https://github.com/apache/incubator-beam/pull/1132
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---