You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by Lewuathe <gi...@git.apache.org> on 2015/04/06 14:38:02 UTC
[GitHub] spark pull request: [SPARK-6720] PySpark MultivariateStatisticalSu...
GitHub user Lewuathe opened a pull request:
https://github.com/apache/spark/pull/5374
[SPARK-6720] PySpark MultivariateStatisticalSummary unit test for normL1...
... and normL2.
Add test cases to insufficient unit test for `normL1` and `normL2`.
Ref: https://github.com/apache/spark/pull/5359
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Lewuathe/spark SPARK-6720
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/5374.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5374
----
commit dc5718cc543bd166ee58c1367acc6ed7ccd92788
Author: lewuathe <le...@me.com>
Date: 2015-04-06T12:36:28Z
[SPARK-6720] PySpark MultivariateStatisticalSummary unit test for normL1 and normL2
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6720][MLLIB] PySpark MultivariateStatis...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5374#issuecomment-90552040
[Test build #29791 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29791/consoleFull) for PR 5374 at commit [`5541b24`](https://github.com/apache/spark/commit/5541b24ffbb4933b2131b43aae2a6c59dbc6a25b).
* This patch **passes all tests**.
* This patch merges cleanly.
* This patch adds no public classes.
* This patch does not change any dependencies.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6720][MLLIB] PySpark MultivariateStatis...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5374#issuecomment-90046171
[Test build #29740 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29740/consoleFull) for PR 5374 at commit [`dc5718c`](https://github.com/apache/spark/commit/dc5718cc543bd166ee58c1367acc6ed7ccd92788).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6720][MLLIB] PySpark MultivariateStatis...
Posted by mengxr <gi...@git.apache.org>.
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/5374#issuecomment-90738003
LGTM. Merged into master. (The JIRA number is wrong. Do you mind updating the title?)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6720][MLLIB] PySpark MultivariateStatis...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5374#issuecomment-90076839
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/29740/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6720][MLLIB] PySpark MultivariateStatis...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5374#issuecomment-90076809
[Test build #29740 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29740/consoleFull) for PR 5374 at commit [`dc5718c`](https://github.com/apache/spark/commit/dc5718cc543bd166ee58c1367acc6ed7ccd92788).
* This patch **passes all tests**.
* This patch merges cleanly.
* This patch adds no public classes.
* This patch does not change any dependencies.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6720][MLLIB] PySpark MultivariateStatis...
Posted by mengxr <gi...@git.apache.org>.
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/5374#discussion_r27808046
--- Diff: python/pyspark/mllib/tests.py ---
@@ -363,6 +363,13 @@ def test_col_norms(self):
self.assertEqual(10, len(summary.normL1()))
self.assertEqual(10, len(summary.normL2()))
+ data2 = self.sc.parallelize(xrange(10)).map(lambda x: Vectors.dense(x))
+ summary2 = Statistics.colStats(data2)
+ self.assertEqual(array([45.0]), summary2.normL1())
+ # Confirm normL2 is among this span because it is a float value.
+ self.assertTrue(summary2.normL2()[0] > 16.5)
--- End diff --
The bounds are too loose. We should reach machine precision for this.
~~~
import math
expectedNormL2 = math.sqrt(sum(map(lambda x: x*x, xrange(10))))
self.assertTrue(math.abs(summary2.normL2()[0] - expectedNormL2) < 1e-14)
~~~
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6720][MLLIB] PySpark MultivariateStatis...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5374#issuecomment-90525831
[Test build #29791 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29791/consoleFull) for PR 5374 at commit [`5541b24`](https://github.com/apache/spark/commit/5541b24ffbb4933b2131b43aae2a6c59dbc6a25b).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6720][MLLIB] PySpark MultivariateStatis...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/5374
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6720][MLLIB] PySpark MultivariateStatis...
Posted by mengxr <gi...@git.apache.org>.
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/5374#issuecomment-90739262
LGTM. Merged into master. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6720][MLLIB] PySpark MultivariateStatis...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5374#issuecomment-90552095
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/29791/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org