You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flex.apache.org by Alex Harui <ah...@adobe.com> on 2014/08/26 17:59:39 UTC
Re: [1/2] git commit: [flex-sdk] [refs/heads/develop] - FLEX-34476
Added RichTextEditor
Just happened to notice that ColorPicker's button appears to have been
changed in a way that wouldn't be backward-compatible. Do we care? After
all, it is still experimental.
On 8/26/14 6:17 AM, "jmclean@apache.org" <jm...@apache.org> wrote:
>Repository: flex-sdk
>Updated Branches:
> refs/heads/develop 827297fc6 -> d4eeb05f5
>
>
>FLEX-34476 Added RichTextEditor
>
>
>Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
>Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/524cdbe3
>Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/524cdbe3
>Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/524cdbe3
>
>Branch: refs/heads/develop
>Commit: 524cdbe33da270e1ce0b7b4f068bfdcf0be87f31
>Parents: 827297f
>Author: Justin Mclean <jm...@apache.org>
>Authored: Tue Aug 26 23:12:57 2014 +1000
>Committer: Justin Mclean <jm...@apache.org>
>Committed: Tue Aug 26 23:12:57 2014 +1000
>
>----------------------------------------------------------------------
> frameworks/projects/experimental/spark-manifest.xml | 2 ++
> frameworks/projects/experimental/src/ExperimentalClasses.as | 1 +
> .../experimental/src/spark/skins/ColorPickerButtonSkin.mxml | 2 +-
> 3 files changed, 4 insertions(+), 1 deletion(-)
>----------------------------------------------------------------------
>
>
>http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/524cdbe3/frameworks/p
>rojects/experimental/spark-manifest.xml
>----------------------------------------------------------------------
>diff --git a/frameworks/projects/experimental/spark-manifest.xml
>b/frameworks/projects/experimental/spark-manifest.xml
>index 803a6f4..2a92ed4 100644
>--- a/frameworks/projects/experimental/spark-manifest.xml
>+++ b/frameworks/projects/experimental/spark-manifest.xml
>@@ -46,4 +46,6 @@
> <!-- Spark Graphics -->
> <component id="BitmapGraphic" class="spark.primitives.BitmapImage"
>lookupOnly="true"/>
> <component id="BitmapImage" class="spark.primitives.BitmapImage"
>lookupOnly="true"/>
>+
>+ <component id="ArrayList" class="mx.collections.ArrayList"
>lookupOnly="true"/>
> </componentPackage>
>
>http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/524cdbe3/frameworks/p
>rojects/experimental/src/ExperimentalClasses.as
>----------------------------------------------------------------------
>diff --git a/frameworks/projects/experimental/src/ExperimentalClasses.as
>b/frameworks/projects/experimental/src/ExperimentalClasses.as
>index b11d626..33024da 100644
>--- a/frameworks/projects/experimental/src/ExperimentalClasses.as
>+++ b/frameworks/projects/experimental/src/ExperimentalClasses.as
>@@ -32,6 +32,7 @@ package
> import spark.components.itemRenderers.MenuItemRenderer;
>MenuItemRenderer;
> import spark.components.listClasses.IListItemRenderer;
>IListItemRenderer;
> import spark.components.supportClasses.IDropDownContainer;
>IDropDownContainer;
>+ import spark.components.RichTextEditor; RichTextEditor;
> import spark.containers.supportClasses.DeferredCreationPolicy;
>DeferredCreationPolicy;
> import spark.containers.Accordion; Accordion;
> import spark.events.ColorChangeEvent; ColorChangeEvent;
>
>http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/524cdbe3/frameworks/p
>rojects/experimental/src/spark/skins/ColorPickerButtonSkin.mxml
>----------------------------------------------------------------------
>diff --git
>a/frameworks/projects/experimental/src/spark/skins/ColorPickerButtonSkin.m
>xml
>b/frameworks/projects/experimental/src/spark/skins/ColorPickerButtonSkin.m
>xml
>index 10dfc66..f8615b2 100644
>---
>a/frameworks/projects/experimental/src/spark/skins/ColorPickerButtonSkin.m
>xml
>+++
>b/frameworks/projects/experimental/src/spark/skins/ColorPickerButtonSkin.m
>xml
>@@ -20,7 +20,7 @@
>
>//////////////////////////////////////////////////////////////////////////
>//////
> -->
> <s:SparkSkin xmlns:fx="http://ns.adobe.com/mxml/2009"
>xmlns:s="library://ns.adobe.com/flex/spark"
>- xmlns:fb="http://ns.adobe.com/flashbuilder/2009" minWidth="24"
>minHeight="24">
>+ xmlns:fb="http://ns.adobe.com/flashbuilder/2009" minWidth="21"
>minHeight="21">
> <fx:Metadata>
> <![CDATA[
> [HostComponent("spark.components.Button")]
>
Re: [1/2] git commit: [flex-sdk] [refs/heads/develop] - FLEX-34476
Added RichTextEditor
Posted by Tom Chiverton <tc...@extravision.com>.
I see it's in experimental, we don't care if the usage changes.
Tom
On 26/08/14 16:59, Alex Harui wrote:
> Just happened to notice that ColorPicker's button appears to have been
> changed in a way that wouldn't be backward-compatible. Do we care? After
> all, it is still experimental.
>
> On 8/26/14 6:17 AM, "jmclean@apache.org" <jm...@apache.org> wrote:
>
>> Repository: flex-sdk
>> Updated Branches:
>> refs/heads/develop 827297fc6 -> d4eeb05f5
>>
>>
>> FLEX-34476 Added RichTextEditor
>>
>>
>> Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
>> Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/524cdbe3
>> Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/524cdbe3
>> Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/524cdbe3
>>
>> Branch: refs/heads/develop
>> Commit: 524cdbe33da270e1ce0b7b4f068bfdcf0be87f31
>> Parents: 827297f
>> Author: Justin Mclean <jm...@apache.org>
>> Authored: Tue Aug 26 23:12:57 2014 +1000
>> Committer: Justin Mclean <jm...@apache.org>
>> Committed: Tue Aug 26 23:12:57 2014 +1000
>>
>> ----------------------------------------------------------------------
>> frameworks/projects/experimental/spark-manifest.xml | 2 ++
>> frameworks/projects/experimental/src/ExperimentalClasses.as | 1 +
>> .../experimental/src/spark/skins/ColorPickerButtonSkin.mxml | 2 +-
>> 3 files changed, 4 insertions(+), 1 deletion(-)
>> ----------------------------------------------------------------------
>>
>>
>> http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/524cdbe3/frameworks/p
>> rojects/experimental/spark-manifest.xml
>> ----------------------------------------------------------------------
>> diff --git a/frameworks/projects/experimental/spark-manifest.xml
>> b/frameworks/projects/experimental/spark-manifest.xml
>> index 803a6f4..2a92ed4 100644
>> --- a/frameworks/projects/experimental/spark-manifest.xml
>> +++ b/frameworks/projects/experimental/spark-manifest.xml
>> @@ -46,4 +46,6 @@
>> <!-- Spark Graphics -->
>> <component id="BitmapGraphic" class="spark.primitives.BitmapImage"
>> lookupOnly="true"/>
>> <component id="BitmapImage" class="spark.primitives.BitmapImage"
>> lookupOnly="true"/>
>> +
>> + <component id="ArrayList" class="mx.collections.ArrayList"
>> lookupOnly="true"/>
>> </componentPackage>
>>
>> http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/524cdbe3/frameworks/p
>> rojects/experimental/src/ExperimentalClasses.as
>> ----------------------------------------------------------------------
>> diff --git a/frameworks/projects/experimental/src/ExperimentalClasses.as
>> b/frameworks/projects/experimental/src/ExperimentalClasses.as
>> index b11d626..33024da 100644
>> --- a/frameworks/projects/experimental/src/ExperimentalClasses.as
>> +++ b/frameworks/projects/experimental/src/ExperimentalClasses.as
>> @@ -32,6 +32,7 @@ package
>> import spark.components.itemRenderers.MenuItemRenderer;
>> MenuItemRenderer;
>> import spark.components.listClasses.IListItemRenderer;
>> IListItemRenderer;
>> import spark.components.supportClasses.IDropDownContainer;
>> IDropDownContainer;
>> + import spark.components.RichTextEditor; RichTextEditor;
>> import spark.containers.supportClasses.DeferredCreationPolicy;
>> DeferredCreationPolicy;
>> import spark.containers.Accordion; Accordion;
>> import spark.events.ColorChangeEvent; ColorChangeEvent;
>>
>> http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/524cdbe3/frameworks/p
>> rojects/experimental/src/spark/skins/ColorPickerButtonSkin.mxml
>> ----------------------------------------------------------------------
>> diff --git
>> a/frameworks/projects/experimental/src/spark/skins/ColorPickerButtonSkin.m
>> xml
>> b/frameworks/projects/experimental/src/spark/skins/ColorPickerButtonSkin.m
>> xml
>> index 10dfc66..f8615b2 100644
>> ---
>> a/frameworks/projects/experimental/src/spark/skins/ColorPickerButtonSkin.m
>> xml
>> +++
>> b/frameworks/projects/experimental/src/spark/skins/ColorPickerButtonSkin.m
>> xml
>> @@ -20,7 +20,7 @@
>>
>> //////////////////////////////////////////////////////////////////////////
>> //////
>> -->
>> <s:SparkSkin xmlns:fx="http://ns.adobe.com/mxml/2009"
>> xmlns:s="library://ns.adobe.com/flex/spark"
>> - xmlns:fb="http://ns.adobe.com/flashbuilder/2009" minWidth="24"
>> minHeight="24">
>> + xmlns:fb="http://ns.adobe.com/flashbuilder/2009" minWidth="21"
>> minHeight="21">
>> <fx:Metadata>
>> <![CDATA[
>> [HostComponent("spark.components.Button")]
>>
> ______________________________________________________________________
> This email has been scanned by the Symantec Email Security.cloud service.
> For more information please visit http://www.symanteccloud.com
> ______________________________________________________________________
>
Re: [1/2] git commit: [flex-sdk] [refs/heads/develop] - FLEX-34476 Added RichTextEditor
Posted by Justin Mclean <ju...@classsoftware.com>.
HI,
> Just happened to notice that ColorPicker's button appears to have been
> changed in a way that wouldn't be backward-compatible.
Changing the min width and height by 3 pixels is hardly a huge compatibility breaker. Plus it's one of the experimental spark components.
Justin