You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/05/31 08:16:25 UTC
[GitHub] [camel-k] johnpoth commented on a change in pull request #2328: Extra repositories
johnpoth commented on a change in pull request #2328:
URL: https://github.com/apache/camel-k/pull/2328#discussion_r642303134
##########
File path: pkg/apis/camel/v1/common_types.go
##########
@@ -93,8 +93,9 @@ type MavenSpec struct {
// A JKS formatted keystore is automatically created to store the CA certificate(s),
// and configured to be used as a trusted certificate(s) by the Maven commands.
// Note that the root CA certificates are also imported into the created keystore.
- CASecret *corev1.SecretKeySelector `json:"caSecret,omitempty"`
- Timeout *metav1.Duration `json:"timeout,omitempty"`
+ CASecret *corev1.SecretKeySelector `json:"caSecret,omitempty"`
+ Timeout *metav1.Duration `json:"timeout,omitempty"`
+ Repositories []string `json:"repositories,omitempty"`
Review comment:
Ah it's already defined that way in the [IntegrationKitSpec](https://github.com/apache/camel-k/blob/main/pkg/apis/camel/v1/integrationkit_types.go#L35), is that okay ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org