You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2017/12/20 00:52:29 UTC

[GitHub] piiswrong commented on a change in pull request #9148: raise warning when we detect Block inside nested list/dict

piiswrong commented on a change in pull request #9148: raise warning when we detect Block inside nested list/dict
URL: https://github.com/apache/incubator-mxnet/pull/9148#discussion_r157914581
 
 

 ##########
 File path: python/mxnet/gluon/block.py
 ##########
 @@ -230,6 +256,7 @@ def params(self):
     def collect_params(self):
         """Returns a :py:class:`ParameterDict` containing this :py:class:`Block` and all of its
         children's Parameters."""
+        self._check_container_with_block()
 
 Review comment:
   This should be checked on assignment

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services