You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/09/24 04:45:45 UTC

[GitHub] [incubator-superset] rusackas opened a new pull request #11033: WIP: Adding all icons from the design system to the codebase

rusackas opened a new pull request #11033:
URL: https://github.com/apache/incubator-superset/pull/11033


   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   This PR adds ALL of the icons from the SIP-34 (#8976)  design system into the codebase. Many were already here, but under different names, or with different attributes (sizes, etc). Now they're all here, visible in storybook, and existing use cases have been updated to work with updated icons wherever relevant.
   
   Forthcoming steps/PRs:
   • Removing any additional hard-coded colors in the SVGs, replacing them with a series of overridable default colors based on Theme variables
   • Replacing font-awesome icons with these new icons wherever possible
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   ![image](https://user-images.githubusercontent.com/812905/94102063-17185f00-fde6-11ea-99d5-d908e2b253d3.png)
   
   ### TEST PLAN
   <!--- What steps should be taken to verify the changes -->
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [x] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [x] Introduces new feature or API
   - [ ] Removes existing feature or API
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] rusackas commented on a change in pull request #11033: Adding all icons from the design system to the codebase

Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #11033:
URL: https://github.com/apache/incubator-superset/pull/11033#discussion_r494036337



##########
File path: superset-frontend/stylesheets/superset.less
##########
@@ -529,17 +529,6 @@ tr.reactable-column-header th.reactable-header-sortable {
   padding-right: 17px;
 }
 
-.fave-unfave-icon {

Review comment:
       this... doesn't seem to really do anything.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #11033: feat: adding all icons from the design system to the codebase

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #11033:
URL: https://github.com/apache/incubator-superset/pull/11033#issuecomment-698578102


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11033?src=pr&el=h1) Report
   > Merging [#11033](https://codecov.io/gh/apache/incubator-superset/pull/11033?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/220c410df4284b1a1681ac99b4db6c36a1407049?el=desc) will **decrease** coverage by `4.27%`.
   > The diff coverage is `97.19%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11033/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11033?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11033      +/-   ##
   ==========================================
   - Coverage   65.76%   61.49%   -4.28%     
   ==========================================
     Files         816      816              
     Lines       38374    38489     +115     
     Branches     3606     3606              
   ==========================================
   - Hits        25238    23667    -1571     
   - Misses      13028    14636    +1608     
   - Partials      108      186      +78     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `61.94% <97.19%> (+0.24%)` | :arrow_up: |
   | #python | `61.22% <ø> (-0.18%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11033?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...rontend/src/components/ErrorMessage/ErrorAlert.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11033/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL0Vycm9yQWxlcnQudHN4) | `20.83% <0.00%> (ø)` | |
   | [superset-frontend/src/components/FaveStar.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11033/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRmF2ZVN0YXIudHN4) | `80.95% <ø> (-19.05%)` | :arrow_down: |
   | [...rset-frontend/src/components/Icon/icon.stories.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11033/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvbi9pY29uLnN0b3JpZXMuanN4) | `0.00% <0.00%> (ø)` | |
   | [...c/components/ListViewCard/ListViewCard.stories.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11033/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXdDYXJkL0xpc3RWaWV3Q2FyZC5zdG9yaWVzLnRzeA==) | `0.00% <ø> (ø)` | |
   | [...src/dashboard/components/HeaderActionsDropdown.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11033/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0hlYWRlckFjdGlvbnNEcm9wZG93bi5qc3g=) | `62.22% <ø> (-6.67%)` | :arrow_down: |
   | [...perset-frontend/src/views/CRUD/chart/ChartList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11033/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY2hhcnQvQ2hhcnRMaXN0LnRzeA==) | `71.79% <ø> (-10.97%)` | :arrow_down: |
   | [...rontend/src/views/CRUD/dashboard/DashboardList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11033/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGFzaGJvYXJkL0Rhc2hib2FyZExpc3QudHN4) | `70.08% <ø> (-6.64%)` | :arrow_down: |
   | [...tend/src/views/CRUD/data/database/DatabaseList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11033/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZUxpc3QudHN4) | `82.05% <ø> (ø)` | |
   | [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11033/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `60.76% <ø> (ø)` | |
   | [...nd/src/views/CRUD/data/dataset/AddDatasetModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11033/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhc2V0L0FkZERhdGFzZXRNb2RhbC50c3g=) | `57.57% <ø> (ø)` | |
   | ... and [200 more](https://codecov.io/gh/apache/incubator-superset/pull/11033/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11033?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11033?src=pr&el=footer). Last update [220c410...b299555](https://codecov.io/gh/apache/incubator-superset/pull/11033?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter commented on pull request #11033: feat: adding all icons from the design system to the codebase

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #11033:
URL: https://github.com/apache/incubator-superset/pull/11033#issuecomment-698578102


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11033?src=pr&el=h1) Report
   > Merging [#11033](https://codecov.io/gh/apache/incubator-superset/pull/11033?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/220c410df4284b1a1681ac99b4db6c36a1407049?el=desc) will **decrease** coverage by `4.27%`.
   > The diff coverage is `97.19%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11033/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11033?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11033      +/-   ##
   ==========================================
   - Coverage   65.76%   61.49%   -4.28%     
   ==========================================
     Files         816      816              
     Lines       38374    38489     +115     
     Branches     3606     3606              
   ==========================================
   - Hits        25238    23667    -1571     
   - Misses      13028    14636    +1608     
   - Partials      108      186      +78     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `61.94% <97.19%> (+0.24%)` | :arrow_up: |
   | #python | `61.22% <ø> (-0.18%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11033?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...rontend/src/components/ErrorMessage/ErrorAlert.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11033/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL0Vycm9yQWxlcnQudHN4) | `20.83% <0.00%> (ø)` | |
   | [superset-frontend/src/components/FaveStar.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11033/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRmF2ZVN0YXIudHN4) | `80.95% <ø> (-19.05%)` | :arrow_down: |
   | [...rset-frontend/src/components/Icon/icon.stories.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11033/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvbi9pY29uLnN0b3JpZXMuanN4) | `0.00% <0.00%> (ø)` | |
   | [...c/components/ListViewCard/ListViewCard.stories.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11033/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXdDYXJkL0xpc3RWaWV3Q2FyZC5zdG9yaWVzLnRzeA==) | `0.00% <ø> (ø)` | |
   | [...src/dashboard/components/HeaderActionsDropdown.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11033/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0hlYWRlckFjdGlvbnNEcm9wZG93bi5qc3g=) | `62.22% <ø> (-6.67%)` | :arrow_down: |
   | [...perset-frontend/src/views/CRUD/chart/ChartList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11033/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY2hhcnQvQ2hhcnRMaXN0LnRzeA==) | `71.79% <ø> (-10.97%)` | :arrow_down: |
   | [...rontend/src/views/CRUD/dashboard/DashboardList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11033/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGFzaGJvYXJkL0Rhc2hib2FyZExpc3QudHN4) | `70.08% <ø> (-6.64%)` | :arrow_down: |
   | [...tend/src/views/CRUD/data/database/DatabaseList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11033/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZUxpc3QudHN4) | `82.05% <ø> (ø)` | |
   | [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11033/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `60.76% <ø> (ø)` | |
   | [...nd/src/views/CRUD/data/dataset/AddDatasetModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11033/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhc2V0L0FkZERhdGFzZXRNb2RhbC50c3g=) | `57.57% <ø> (ø)` | |
   | ... and [200 more](https://codecov.io/gh/apache/incubator-superset/pull/11033/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11033?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11033?src=pr&el=footer). Last update [220c410...b299555](https://codecov.io/gh/apache/incubator-superset/pull/11033?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] zhouyao1994 commented on pull request #11033: feat: adding all icons from the design system to the codebase

Posted by GitBox <gi...@apache.org>.
zhouyao1994 commented on pull request #11033:
URL: https://github.com/apache/incubator-superset/pull/11033#issuecomment-698210297


   it's great~


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] mistercrunch commented on pull request #11033: feat: adding all icons from the design system to the codebase

Posted by GitBox <gi...@apache.org>.
mistercrunch commented on pull request #11033:
URL: https://github.com/apache/incubator-superset/pull/11033#issuecomment-698703804


   OMG yes!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] mistercrunch commented on pull request #11033: feat: adding all icons from the design system to the codebase

Posted by GitBox <gi...@apache.org>.
mistercrunch commented on pull request #11033:
URL: https://github.com/apache/incubator-superset/pull/11033#issuecomment-698703804


   OMG yes!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] rusackas merged pull request #11033: feat: adding all icons from the design system to the codebase

Posted by GitBox <gi...@apache.org>.
rusackas merged pull request #11033:
URL: https://github.com/apache/incubator-superset/pull/11033


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] rusackas commented on a change in pull request #11033: Adding all icons from the design system to the codebase

Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #11033:
URL: https://github.com/apache/incubator-superset/pull/11033#discussion_r494036870



##########
File path: superset-frontend/src/explore/main.less
##########
@@ -36,7 +36,6 @@
   margin-bottom: 40px;
 }
 
-.fave-unfave-icon,

Review comment:
       this doesn't appear necessary these days. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] rusackas commented on a change in pull request #11033: Adding all icons from the design system to the codebase

Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #11033:
URL: https://github.com/apache/incubator-superset/pull/11033#discussion_r494036559



##########
File path: superset-frontend/src/components/NavDropdown/index.tsx
##########
@@ -33,16 +33,16 @@ const NavDropdown = styled(ReactBootstrapNavDropdown)`
 
   :after {
     content: '';
-    height: ${({ theme }) => theme.gridUnit}px;
-    width: ${({ theme }) => theme.gridUnit * 2}px;
-    background: url('/static/assets/images/icons/dropdown-arrow.svg');

Review comment:
       the dropdown-arrow was small. The triangle-down button is bigger, with padding around it. These changes accommodate the layout change.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #11033: feat: adding all icons from the design system to the codebase

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #11033:
URL: https://github.com/apache/incubator-superset/pull/11033#issuecomment-698578102


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11033?src=pr&el=h1) Report
   > Merging [#11033](https://codecov.io/gh/apache/incubator-superset/pull/11033?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/220c410df4284b1a1681ac99b4db6c36a1407049?el=desc) will **decrease** coverage by `4.16%`.
   > The diff coverage is `97.19%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11033/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11033?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11033      +/-   ##
   ==========================================
   - Coverage   65.76%   61.60%   -4.17%     
   ==========================================
     Files         816      816              
     Lines       38374    38489     +115     
     Branches     3606     3606              
   ==========================================
   - Hits        25238    23712    -1526     
   - Misses      13028    14591    +1563     
   - Partials      108      186      +78     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `61.94% <97.19%> (+0.24%)` | :arrow_up: |
   | #python | `61.40% <ø> (+0.01%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11033?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...rontend/src/components/ErrorMessage/ErrorAlert.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11033/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL0Vycm9yQWxlcnQudHN4) | `20.83% <0.00%> (ø)` | |
   | [superset-frontend/src/components/FaveStar.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11033/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRmF2ZVN0YXIudHN4) | `80.95% <ø> (-19.05%)` | :arrow_down: |
   | [...rset-frontend/src/components/Icon/icon.stories.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11033/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvbi9pY29uLnN0b3JpZXMuanN4) | `0.00% <0.00%> (ø)` | |
   | [...c/components/ListViewCard/ListViewCard.stories.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11033/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXdDYXJkL0xpc3RWaWV3Q2FyZC5zdG9yaWVzLnRzeA==) | `0.00% <ø> (ø)` | |
   | [...src/dashboard/components/HeaderActionsDropdown.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11033/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0hlYWRlckFjdGlvbnNEcm9wZG93bi5qc3g=) | `62.22% <ø> (-6.67%)` | :arrow_down: |
   | [...perset-frontend/src/views/CRUD/chart/ChartList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11033/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY2hhcnQvQ2hhcnRMaXN0LnRzeA==) | `71.79% <ø> (-10.97%)` | :arrow_down: |
   | [...rontend/src/views/CRUD/dashboard/DashboardList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11033/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGFzaGJvYXJkL0Rhc2hib2FyZExpc3QudHN4) | `70.08% <ø> (-6.64%)` | :arrow_down: |
   | [...tend/src/views/CRUD/data/database/DatabaseList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11033/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZUxpc3QudHN4) | `82.05% <ø> (ø)` | |
   | [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11033/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `60.76% <ø> (ø)` | |
   | [...nd/src/views/CRUD/data/dataset/AddDatasetModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11033/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhc2V0L0FkZERhdGFzZXRNb2RhbC50c3g=) | `57.57% <ø> (ø)` | |
   | ... and [195 more](https://codecov.io/gh/apache/incubator-superset/pull/11033/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11033?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11033?src=pr&el=footer). Last update [220c410...b299555](https://codecov.io/gh/apache/incubator-superset/pull/11033?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #11033: feat: adding all icons from the design system to the codebase

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #11033:
URL: https://github.com/apache/incubator-superset/pull/11033#issuecomment-698578102






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter commented on pull request #11033: feat: adding all icons from the design system to the codebase

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #11033:
URL: https://github.com/apache/incubator-superset/pull/11033#issuecomment-698578102


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11033?src=pr&el=h1) Report
   > Merging [#11033](https://codecov.io/gh/apache/incubator-superset/pull/11033?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/220c410df4284b1a1681ac99b4db6c36a1407049?el=desc) will **decrease** coverage by `4.27%`.
   > The diff coverage is `97.19%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11033/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11033?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11033      +/-   ##
   ==========================================
   - Coverage   65.76%   61.49%   -4.28%     
   ==========================================
     Files         816      816              
     Lines       38374    38489     +115     
     Branches     3606     3606              
   ==========================================
   - Hits        25238    23667    -1571     
   - Misses      13028    14636    +1608     
   - Partials      108      186      +78     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `61.94% <97.19%> (+0.24%)` | :arrow_up: |
   | #python | `61.22% <ø> (-0.18%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11033?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...rontend/src/components/ErrorMessage/ErrorAlert.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11033/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL0Vycm9yQWxlcnQudHN4) | `20.83% <0.00%> (ø)` | |
   | [superset-frontend/src/components/FaveStar.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11033/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRmF2ZVN0YXIudHN4) | `80.95% <ø> (-19.05%)` | :arrow_down: |
   | [...rset-frontend/src/components/Icon/icon.stories.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11033/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvbi9pY29uLnN0b3JpZXMuanN4) | `0.00% <0.00%> (ø)` | |
   | [...c/components/ListViewCard/ListViewCard.stories.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11033/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXdDYXJkL0xpc3RWaWV3Q2FyZC5zdG9yaWVzLnRzeA==) | `0.00% <ø> (ø)` | |
   | [...src/dashboard/components/HeaderActionsDropdown.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11033/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0hlYWRlckFjdGlvbnNEcm9wZG93bi5qc3g=) | `62.22% <ø> (-6.67%)` | :arrow_down: |
   | [...perset-frontend/src/views/CRUD/chart/ChartList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11033/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY2hhcnQvQ2hhcnRMaXN0LnRzeA==) | `71.79% <ø> (-10.97%)` | :arrow_down: |
   | [...rontend/src/views/CRUD/dashboard/DashboardList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11033/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGFzaGJvYXJkL0Rhc2hib2FyZExpc3QudHN4) | `70.08% <ø> (-6.64%)` | :arrow_down: |
   | [...tend/src/views/CRUD/data/database/DatabaseList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11033/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZUxpc3QudHN4) | `82.05% <ø> (ø)` | |
   | [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11033/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `60.76% <ø> (ø)` | |
   | [...nd/src/views/CRUD/data/dataset/AddDatasetModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11033/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhc2V0L0FkZERhdGFzZXRNb2RhbC50c3g=) | `57.57% <ø> (ø)` | |
   | ... and [200 more](https://codecov.io/gh/apache/incubator-superset/pull/11033/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11033?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11033?src=pr&el=footer). Last update [220c410...b299555](https://codecov.io/gh/apache/incubator-superset/pull/11033?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] zhouyao1994 commented on pull request #11033: feat: adding all icons from the design system to the codebase

Posted by GitBox <gi...@apache.org>.
zhouyao1994 commented on pull request #11033:
URL: https://github.com/apache/incubator-superset/pull/11033#issuecomment-698210297


   it's great~


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] rusackas commented on a change in pull request #11033: Adding all icons from the design system to the codebase

Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #11033:
URL: https://github.com/apache/incubator-superset/pull/11033#discussion_r494036337



##########
File path: superset-frontend/stylesheets/superset.less
##########
@@ -529,17 +529,6 @@ tr.reactable-column-header th.reactable-header-sortable {
   padding-right: 17px;
 }
 
-.fave-unfave-icon {

Review comment:
       this... doesn't seem to really do anything.

##########
File path: superset-frontend/src/components/NavDropdown/index.tsx
##########
@@ -33,16 +33,16 @@ const NavDropdown = styled(ReactBootstrapNavDropdown)`
 
   :after {
     content: '';
-    height: ${({ theme }) => theme.gridUnit}px;
-    width: ${({ theme }) => theme.gridUnit * 2}px;
-    background: url('/static/assets/images/icons/dropdown-arrow.svg');

Review comment:
       the dropdown-arrow was small. The triangle-down button is bigger, with padding around it. These changes accommodate the layout change.

##########
File path: superset-frontend/src/explore/main.less
##########
@@ -36,7 +36,6 @@
   margin-bottom: 40px;
 }
 
-.fave-unfave-icon,

Review comment:
       this doesn't appear necessary these days. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org