[GitHub] [hbase] Apache9 commented on pull request #4125: HBASE-26666 Add native TLS encryption support to RPC server/client

[GitBox <gi...@apache.org>]

Apache9 commented on PR #4125:
URL: https://github.com/apache/hbase/pull/4125#issuecomment-1190285426

   > Anyone has a clue what would be the spotless-friendly formatting of these ZK references?
   > 
   > Spotless merges them with the existing paragraphs which looks ugly:
   > 
   > ```diff
   >  /**
   >   * Utility code for X509 handling Default cipher suites: Performance testing done by Facebook
   >   * engineers shows that on Intel x86_64 machines, Java9 performs better with GCM and Java8 performs
   > - * better with CBC, so these seem like reasonable defaults.
   > - *
   > - * This file has been copied from the Apache ZooKeeper project.
   > - * @see <a href="https://github.com/apache/zookeeper/blob/c74658d398cdc1d207aa296cb6e20de00faec03e/zookeeper-server/src/main/java/org/apache/zookeeper/common/X509Util.java">Base revision</a>
   > + * better with CBC, so these seem like reasonable defaults. This file has been copied from the
   > + * Apache ZooKeeper project.
   > + * @see <a href=
   > + *      "https://github.com/apache/zookeeper/blob/c74658d398cdc1d207aa296cb6e20de00faec03e/zookeeper-server/src/main/java/org/apache/zookeeper/common/X509Util.java">Base
   > + *      revision</a>
   >   */
   > ```
   
   The see line is too long so the formatter tries to break it into several lines.
   
   And for the summary part, just add a <p> to avoid the formatter join the two paragraphs.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org