[jira] [Commented] (TUBEMQ-166) Hide `bdbStore` configs in master.ini

["Guocheng Zhang (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TUBEMQ-166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17120142#comment-17120142 ] 

Guocheng Zhang commented on TUBEMQ-166:
---------------------------------------

[~pingyu] You are right, (y)

We use bdb for metadata storage, and use bdb's multi-node replication function to achieve the hot switch function between Master nodes

The initial use did not consider it as carefully as you did, and directly exposed its original parameters. In fact, the bdb configuration expresses the cluster group infos, it should be more understandable to separate this information from bdb.

I think your proposal makes the intelligibility of this system clearer. If you can give a complete adjustment plan and provide a PR, it will be an honor for this system. 

Can you provide a complete and complete modification?  I Can provide related helps.

> Hide `bdbStore` configs in master.ini
> -------------------------------------
>
>                 Key: TUBEMQ-166
>                 URL: https://issues.apache.org/jira/browse/TUBEMQ-166
>             Project: Apache TubeMQ
>          Issue Type: Improvement
>            Reporter: Ping Yu
>            Priority: Major
>             Fix For: 0.5.0
>
>
> I was quit confused when I saw the `[bdbStore]` section in `master.ini`.
> After read some codes and intro of "Oracle Berkeley DB Java Edition", I realized that `bdbStore` is the embedded database, used for meta data storage, and replication between masters. (Am I right ?)
> I suggest that hiding `bdbStore` configs in `master.ini`, as `bdb` is an implementation detail, better not to bother users.
> Necessary configs for `bdbStore` can be renamed to another ones, to be more reasonable.
> E.g. `bdbNodePort` rename to `replicationPort` in `[master]` section.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)