You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/08/28 19:11:38 UTC
[GitHub] [beam] TheNeuralBit commented on a change in pull request #12720: Linked SchemaIOProvider development guide in Javadoc
TheNeuralBit commented on a change in pull request #12720:
URL: https://github.com/apache/beam/pull/12720#discussion_r479487518
##########
File path: sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/io/SchemaIO.java
##########
@@ -36,6 +36,9 @@
* <p><b>Internal only:</b> This interface is actively being worked on and it will likely change as
* we provide implementations for more standard Beam IOs. We provide no backwards compatibility
* guarantees and it should not be implemented outside of the Beam repository.
+ *
+ * <p>For a detailed walkthrough of implementation, see <a
+ * href="s.apache.org/schemaio-development-guide">s.apache.org/schemaio-development-guide </a>
Review comment:
```suggestion
* href="https://s.apache.org/schemaio-development-guide">s.apache.org/schemaio-development-guide </a>
```
##########
File path: sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/io/SchemaIOProvider.java
##########
@@ -31,6 +31,9 @@
* <p><b>Internal only:</b> This interface is actively being worked on and it will likely change as
* we provide implementations for more standard Beam IOs. We provide no backwards compatibility
* guarantees and it should not be implemented outside of the Beam repository.
+ *
+ * <p>For a detailed walkthrough of implementation, see <a
+ * href="s.apache.org/schemaio-development-guide">s.apache.org/schemaio-development-guide </a>
Review comment:
```suggestion
* href="https://s.apache.org/schemaio-development-guide">s.apache.org/schemaio-development-guide </a>
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org