You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2021/06/24 00:02:41 UTC

[GitHub] [trafficserver] maskit commented on a change in pull request #7981: Reject TLS if client offers alpn with no match

maskit commented on a change in pull request #7981:
URL: https://github.com/apache/trafficserver/pull/7981#discussion_r657535267



##########
File path: iocore/net/ALPNSupport.cc
##########
@@ -98,18 +98,24 @@ ALPNSupport::select_next_protocol(SSL *ssl, const unsigned char **out, unsigned
 {
   const unsigned char *npnptr = nullptr;
   unsigned int npnsize        = 0;
-  if (this->getNPN(&npnptr, &npnsize)) {
+  int retval                  = SSL_TLSEXT_ERR_ALERT_FATAL;

Review comment:
       I don't think we can use this error code for 1.0.2.
   https://www.openssl.org/docs/man1.0.2/man3/SSL_set_alpn_protos.html




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org