[jira] [Commented] (HIVE-2138) Exception when no splits returned from index

["jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-2138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13076007#comment-13076007 ] 

jiraposter@reviews.apache.org commented on HIVE-2138:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1255/
-----------------------------------------------------------

Review request for hive, John Sichi and Yongqiang He.


Summary
-------

return an empty array of input splits when we get back no results from the hiveIndexResult


This addresses bug HIVE-2138.
    https://issues.apache.org/jira/browse/HIVE-2138


Diffs
-----

  ql/src/java/org/apache/hadoop/hive/ql/index/HiveIndexedInputFormat.java 1a1ecd7 
  ql/src/test/queries/clientpositive/index_auto_test_if_used.q PRE-CREATION 
  ql/src/test/results/clientpositive/index_auto_test_if_used.q.out PRE-CREATION 

Diff: https://reviews.apache.org/r/1255/diff


Testing
-------

added index_auto_test_if_used.q to the test suite


Thanks,

Syed



> Exception when no splits returned from index
> --------------------------------------------
>
>                 Key: HIVE-2138
>                 URL: https://issues.apache.org/jira/browse/HIVE-2138
>             Project: Hive
>          Issue Type: Bug
>          Components: Indexing
>    Affects Versions: 0.8.0
>            Reporter: Russell Melick
>            Assignee: Syed S. Albiz
>         Attachments: HIVE-2138.1.patch, index_auto_test_if_used.q
>
>
> Running a query that uses indexing but doesn't return any results give an exception.
> {code} java.lang.IllegalArgumentException: Can not create a Path from an empty string
> at org.apache.hadoop.fs.Path.checkPathArg(Path.java:82)
> at org.apache.hadoop.fs.Path.<init>(Path.java:90)
> at org.apache.hadoop.util.StringUtils.stringToPath(StringUtils.java:224)
> at org.apache.hadoop.mapred.FileInputFormat.setInputPaths(FileInputFormat.java:282)
> at org.apache.hadoop.hive.ql.index.HiveIndexedInputFormat.getSplits(HiveIndexedInputFormat.java:123) {code}
> This could potentially be fixed by creating a new empty file to use for the splits.
> Once this is fixed, the index_auto_test_if_used.q can be used.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira