You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2021/03/19 17:36:40 UTC

[GitHub] [fineract-cn-mobile] PatelVatsalB21 opened a new pull request #163: Fix-298: Pin and Country error fixed in FormCustomerAddressFragment

PatelVatsalB21 opened a new pull request #163:
URL: https://github.com/apache/fineract-cn-mobile/pull/163


   Fixes [FINCN-298](https://issues.apache.org/jira/browse/FINCN-298)
   
   **Error**
   
   https://user-images.githubusercontent.com/70195106/111820355-6360d980-8907-11eb-8eb4-c54a22b10bb9.mp4
   
   **Solution**
   
   https://user-images.githubusercontent.com/70195106/111820436-8095a800-8907-11eb-9eab-b31ce870e97f.mp4
   
   - [x] Apply the `AndroidStyle.xml` style template to your code in Android Studio.
   
   - [x] Run the unit tests with `./gradlew check` to make sure you didn't break anything.
   
   - [x] If you have multiple commits please combine them into one commit by squashing them.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract-cn-mobile] PatelVatsalB21 commented on pull request #163: Fix-298: Pin and Country error fixed in FormCustomerAddressFragment

Posted by GitBox <gi...@apache.org>.
PatelVatsalB21 commented on pull request #163:
URL: https://github.com/apache/fineract-cn-mobile/pull/163#issuecomment-803019821


   Ok sorry. Then let me change title and code fixes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract-cn-mobile] PatelVatsalB21 edited a comment on pull request #163: Fix-298: Pin and Country error fixed in FormCustomerAddressFragment

Posted by GitBox <gi...@apache.org>.
PatelVatsalB21 edited a comment on pull request #163:
URL: https://github.com/apache/fineract-cn-mobile/pull/163#issuecomment-803020313


   But @EGOR-IND we have numeric input in Groups. I forgot to mention that. Now what to do. Anyone has to be changed. Should i change groups one or let this be as it is ?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract-cn-mobile] EGOR-IND commented on pull request #163: Fix-298: Pin and Country error fixed in FormCustomerAddressFragment

Posted by GitBox <gi...@apache.org>.
EGOR-IND commented on pull request #163:
URL: https://github.com/apache/fineract-cn-mobile/pull/163#issuecomment-803021227


   > But @EGOR-IND we have numeric input in Groups. I for got to mention that
   
   Then maybe we should change it to alphanumeric.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract-cn-mobile] PatelVatsalB21 commented on pull request #163: Fix-298: Pin and Country error fixed in FormCustomerAddressFragment

Posted by GitBox <gi...@apache.org>.
PatelVatsalB21 commented on pull request #163:
URL: https://github.com/apache/fineract-cn-mobile/pull/163#issuecomment-803020313


   But @EGOR-IND we have numeric input in Groups. I for got to mention that
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract-cn-mobile] EGOR-IND commented on pull request #163: Fix-298: Pin and Country error fixed in FormCustomerAddressFragment

Posted by GitBox <gi...@apache.org>.
EGOR-IND commented on pull request #163:
URL: https://github.com/apache/fineract-cn-mobile/pull/163#issuecomment-803018548


   @PatelVatsalB21 actually the postal code found earlier but I searched on google and it shows some countries have alphanumeric postal codes so it would be good to keep to alphanumeric:).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract-cn-mobile] PatelVatsalB21 commented on pull request #163: Fix-298: Pin and Country error fixed in FormCustomerAddressFragment

Posted by GitBox <gi...@apache.org>.
PatelVatsalB21 commented on pull request #163:
URL: https://github.com/apache/fineract-cn-mobile/pull/163#issuecomment-803021804


   Ok then i will include it in this pr is it ok?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org