[GitHub] [jena] afs commented on a diff in pull request #1960: Fuseki improvements for access control, servlet context, and configurations with shared datasets.

["afs (via GitHub)" <gi...@apache.org>]

afs commented on code in PR #1960:
URL: https://github.com/apache/jena/pull/1960#discussion_r1267269559


##########
jena-fuseki2/jena-fuseki-main/src/main/java/org/apache/jena/fuseki/main/FusekiServer.java:
##########
@@ -867,6 +874,25 @@ private static boolean argBoolean(Resource r, Property p, boolean dftValue) {
             }
         }
 
+        private static String argString(Resource r, Property p, String dftValue) {
+            try { GraphUtils.atmostOneProperty(r, p); }
+            catch (NotUniqueException ex) {
+                throw new FusekiConfigException(ex.getMessage());

Review Comment:
   In this case, the original exception will in the function called, not with a deeper stack. There isn't more context. The effect is to change the name of the exception to `FusekiConfiguration`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org