You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <bb...@apache.org> on 2019/08/22 13:17:47 UTC
Review Request 71351: Sped up `ExampleTest.DiskFullFramework` test.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71351/
-----------------------------------------------------------
Review request for mesos and Till Toenshoff.
Bugs: MESOS-9952
https://issues.apache.org/jira/browse/MESOS-9952
Repository: mesos
Description
-------
This patch lowers the authentication timeout and increases the disk
watch interval which can speed up the test by about 10s.
Diffs
-----
src/tests/disk_full_framework_test.sh 83ae0947d4f5ec0a960e8cefa925cacbe6c6808e
Diff: https://reviews.apache.org/r/71351/diff/1/
Testing
-------
`make check`
With this and the preceeding patch the test takes <3s on my setup from >17s before.
Thanks,
Benjamin Bannier
Re: Review Request 71351: Sped up `ExampleTest.DiskFullFramework`
test.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71351/#review217389
-----------------------------------------------------------
Patch looks great!
Reviews applied: [71350, 71351]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Aug. 22, 2019, 6:17 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71351/
> -----------------------------------------------------------
>
> (Updated Aug. 22, 2019, 6:17 a.m.)
>
>
> Review request for mesos and Till Toenshoff.
>
>
> Bugs: MESOS-9952
> https://issues.apache.org/jira/browse/MESOS-9952
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch lowers the authentication timeout and increases the disk
> watch interval which can speed up the test by about 10s.
>
>
> Diffs
> -----
>
> src/tests/disk_full_framework_test.sh 83ae0947d4f5ec0a960e8cefa925cacbe6c6808e
>
>
> Diff: https://reviews.apache.org/r/71351/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
> With this and the preceeding patch the test takes <3s on my setup from >17s before.
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 71351: Sped up `ExampleTest.DiskFullFramework`
test.
Posted by Benjamin Bannier <bb...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71351/
-----------------------------------------------------------
(Updated Aug. 23, 2019, 1:08 p.m.)
Review request for mesos and Till Toenshoff.
Changes
-------
Rebase
Bugs: MESOS-9952
https://issues.apache.org/jira/browse/MESOS-9952
Repository: mesos
Description
-------
This patch lowers the authentication timeout and increases the disk
watch interval which can speed up the test by about 10s.
Diffs (updated)
-----
src/tests/disk_full_framework_test.sh 83ae0947d4f5ec0a960e8cefa925cacbe6c6808e
Diff: https://reviews.apache.org/r/71351/diff/2/
Changes: https://reviews.apache.org/r/71351/diff/1-2/
Testing
-------
`make check`
With this and the preceeding patch the test takes <3s on my setup from >17s before.
Thanks,
Benjamin Bannier
Re: Review Request 71351: Sped up `ExampleTest.DiskFullFramework`
test.
Posted by Jan Schlicht <ja...@d2iq.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71351/#review217396
-----------------------------------------------------------
Ship it!
Ship It!
- Jan Schlicht
On Aug. 22, 2019, 3:17 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71351/
> -----------------------------------------------------------
>
> (Updated Aug. 22, 2019, 3:17 p.m.)
>
>
> Review request for mesos and Till Toenshoff.
>
>
> Bugs: MESOS-9952
> https://issues.apache.org/jira/browse/MESOS-9952
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch lowers the authentication timeout and increases the disk
> watch interval which can speed up the test by about 10s.
>
>
> Diffs
> -----
>
> src/tests/disk_full_framework_test.sh 83ae0947d4f5ec0a960e8cefa925cacbe6c6808e
>
>
> Diff: https://reviews.apache.org/r/71351/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
> With this and the preceeding patch the test takes <3s on my setup from >17s before.
>
>
> Thanks,
>
> Benjamin Bannier
>
>