Non-gui broken on Linux - Attn: Oliver

[Scott Eade <se...@backstagetech.com.au>]

Oliver,

When PluginManager loads the icons for the JMeter instance that is created
when JMeter is started, it runs into problems in non-gui mode when no
graphical display can be located (the problem occurs on Linux and presumable
other *nix variants, but not on win2k).  I think the problem statement is
the instantiation of the ImageIcon.

Here is the stack trace:

java.lang.reflect.InvocationTargetException
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39
)
        at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl
.java:25)
        at java.lang.reflect.Method.invoke(Method.java:324)
        at org.apache.jmeter.NewDriver.main(NewDriver.java:165)
Caused by: java.lang.InternalError: Can't connect to X11 window server using
':0.0' as the value of the DISPLAY variable.
        at sun.awt.X11GraphicsEnvironment.initDisplay(Native Method)
        at 
sun.awt.X11GraphicsEnvironment.<clinit>(X11GraphicsEnvironment.java:125)
        at java.lang.Class.forName0(Native Method)
        at java.lang.Class.forName(Class.java:140)
        at 
java.awt.GraphicsEnvironment.getLocalGraphicsEnvironment(GraphicsEnvironment
.java:62)
        at sun.awt.motif.MToolkit.<clinit>(MToolkit.java:72)
        at java.lang.Class.forName0(Native Method)
        at java.lang.Class.forName(Class.java:140)
        at java.awt.Toolkit$2.run(Toolkit.java:712)
        at java.security.AccessController.doPrivileged(Native Method)
        at java.awt.Toolkit.getDefaultToolkit(Toolkit.java:703)
        at javax.swing.ImageIcon.<init>(ImageIcon.java:119)
        at javax.swing.ImageIcon.<init>(ImageIcon.java:138)
        at 
org.apache.jmeter.plugin.PluginManager.installPlugin(PluginManager.java:106)
        at 
org.apache.jmeter.plugin.PluginManager.install(PluginManager.java:85)
        at org.apache.jmeter.JMeter.startNonGui(JMeter.java:332)
        at org.apache.jmeter.JMeter.start(JMeter.java:252)
        ... 5 more
 
Whether or not the attached fix is correct depends on the long term plans
are for PluginManager.  I have taken the view that it may actually do more
than just deal with icons and have thus passed it a flag indicating whether
or not a gui is to be used so that it can then only load the images when it
is appropriate to do so.  The attached patch is prepared on this basis - let
me know if you agree with this approach and I will commit it (note that the
patch fixes the indentation of PluginManager, but doesn't convert the tabs
to spaces (it contains a mixture of both)).

Cheers,

Scott
-- 
Scott Eade
Backstage Technologies Pty. Ltd.
http://www.backstagetech.com.au
.Mac Chat/AIM: seade at mac dot com

Re: Non-gui broken on Linux - Attn: Oliver

[Oliver Rossmueller <ol...@tuxerra.com>]

Scott Eade wrote:
> [snip]
> Whether or not the attached fix is correct depends on the long term plans
> are for PluginManager.  I have taken the view that it may actually do more
> than just deal with icons and have thus passed it a flag indicating whether
> or not a gui is to be used so that it can then only load the images when it
> is appropriate to do so.  The attached patch is prepared on this basis - let
> me know if you agree with this approach and I will commit it (note that the
> patch fixes the indentation of PluginManager, but doesn't convert the tabs
> to spaces (it contains a mixture of both)).

Scott,

the patch is a good solution for the moment, so please commit it.

Oliver


> Cheers,
> 
> Scott
> 
> 
> ------------------------------------------------------------------------
> 
> --
> To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
> For additional commands, e-mail: <ma...@jakarta.apache.org>