You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2020/06/09 16:38:28 UTC
[GitHub] [phoenix] kadirozde commented on a change in pull request #797: PHOENIX-5932 View Index rebuild results in surplus rows from other vi…
kadirozde commented on a change in pull request #797:
URL: https://github.com/apache/phoenix/pull/797#discussion_r437000303
##########
File path: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/UngroupedAggregateRegionObserver.java
##########
@@ -1081,7 +1083,11 @@ private RegionScanner rebuildIndices(final RegionScanner innerScanner, final Reg
rawScan.setRaw(true);
rawScan.setMaxVersions();
rawScan.getFamilyMap().clear();
- rawScan.setFilter(null);
+ if (scan.getFilter() instanceof FirstKeyOnlyFilter) {
+ rawScan.setFilter(null);
+ } else if (scan.getFilter() != null) {
+ rawScan.setFilter(new AllVersionsIndexRebuildFilter(scan.getFilter()));
+ }
Review comment:
Yes, we get raw scan only for the old design partial rebuilds (i.e., auto-rebuilds).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org