You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by bu...@apache.org on 2006/03/12 03:29:15 UTC
DO NOT REPLY [Bug 38936] New: - FileUploadBase::parseRequest has to be more tolerant of errors
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=38936>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=38936
Summary: FileUploadBase::parseRequest has to be more tolerant of
errors
Product: Commons
Version: 1.1.0
Platform: Other
OS/Version: other
Status: NEW
Severity: normal
Priority: P2
Component: File Upload
AssignedTo: commons-dev@jakarta.apache.org
ReportedBy: kenkyee@excite.com
I found a bad multipart upload client (I know, it's flaky and it should be
fixed), but the FileUpload should be more tolerant of errors. In particular, I
found that the http post was badly formatted:
--7d237d5a03c6
Content-Disposition: form-data; name="ekclientname"
ekmediatransfer
--7d237d5a03c6
Content-Disposition: form-data; name="ekclientversion"
1.0
--7d237d5a03c6
Upload File
--7d237d5a03c6--
Note that the last segment is badly formatted...invalidly formatted header,
missing CRLF, etc.
I modified parseRequest to do this when catching the IOException:
if (items.size() > 0) {
//TODO: log error somewhere so programs can check for it
// return parsed items if there were any
return items;
} else {
throw new FileUploadException(
"Processing of " + MULTIPART_FORM_DATA
+ " request failed. " + e.getMessage());
}
Basically, I want it to give me all the parts it could decode while also
flagging an error that the upload client is buggy/flaky. Unfortunately, there
doesn't seem to be a way to flag the error and if you throw a
FileUploadException, you can't pass the decoded parts back :-(
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
DO NOT REPLY [Bug 38936] - FileUploadBase::parseRequest has to be more tolerant of errors
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=38936>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=38936
------- Additional Comments From kenkyee@excite.com 2006-03-12 02:31 -------
Forgot to mention that the exception I got without this modification was:
"Stream ended unexpectedly".
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
DO NOT REPLY [Bug 38936] - FileUploadBase::parseRequest has to be more tolerant of errors
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=38936>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=38936
martinc@apache.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Severity|normal |enhancement
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
DO NOT REPLY [Bug 38936] - [fileupload] FileUploadBase::parseRequest has to be more tolerant of errors
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=38936>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=38936
martinc@apache.org changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |wshao@perpetual.com
------- Additional Comments From martinc@apache.org 2006-04-14 19:03 -------
*** Bug 39316 has been marked as a duplicate of this bug. ***
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
DO NOT REPLY [Bug 38936] - [fileupload] FileUploadBase::parseRequest has to be more tolerant of errors
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=38936>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=38936
sandymac@apache.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|FileUploadBase::parseRequest|[fileupload]
|has to be more tolerant of |FileUploadBase::parseRequest
|errors |has to be more tolerant of
| |errors
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org