You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Donghui Xu (Code Review)" <ge...@cloudera.org> on 2017/06/14 05:54:22 UTC
[Impala-ASF-CR] IMPALA-5506: Add stdin description to help information of query file option
Donghui Xu has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7178
Change subject: IMPALA-5506: Add stdin description to help information of query_file option
......................................................................
IMPALA-5506: Add stdin description to help information of query_file option
Help information of query_file option in impala-shell misses stdin
description.
I fix this issue by adding stdin description to help information of
query_file option.
Change-Id: I0264174fd062497c72891b31cf9ac1ba6c00f716
---
M shell/option_parser.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/78/7178/1
--
To view, visit http://gerrit.cloudera.org:8080/7178
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0264174fd062497c72891b31cf9ac1ba6c00f716
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu <xu...@zte.com.cn>
[Impala-ASF-CR] IMPALA-5506: Add stdin description to help information of query file option
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged.
Change subject: IMPALA-5506: Add stdin description to help information of query_file option
......................................................................
IMPALA-5506: Add stdin description to help information of query_file option
Help information of query_file option in impala-shell misses stdin
description.
I fix this issue by adding stdin description to help information of
query_file option.
Change-Id: I0264174fd062497c72891b31cf9ac1ba6c00f716
Reviewed-on: http://gerrit.cloudera.org:8080/7178
Reviewed-by: Henry Robinson <he...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M shell/option_parser.py
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Impala Public Jenkins: Verified
Henry Robinson: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/7178
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0264174fd062497c72891b31cf9ac1ba6c00f716
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu <xu...@zte.com.cn>
Gerrit-Reviewer: Donghui Xu <xu...@zte.com.cn>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
[Impala-ASF-CR] IMPALA-5506: Add stdin description to help information of query file option
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5506: Add stdin description to help information of query_file option
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/7178
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0264174fd062497c72891b31cf9ac1ba6c00f716
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu <xu...@zte.com.cn>
Gerrit-Reviewer: Donghui Xu <xu...@zte.com.cn>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5506: Add stdin description to help information of query file option
Posted by "Donghui Xu (Code Review)" <ge...@cloudera.org>.
Donghui Xu has uploaded a new patch set (#2).
Change subject: IMPALA-5506: Add stdin description to help information of query_file option
......................................................................
IMPALA-5506: Add stdin description to help information of query_file option
Help information of query_file option in impala-shell misses stdin
description.
I fix this issue by adding stdin description to help information of
query_file option.
Change-Id: I0264174fd062497c72891b31cf9ac1ba6c00f716
---
M shell/option_parser.py
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/78/7178/2
--
To view, visit http://gerrit.cloudera.org:8080/7178
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0264174fd062497c72891b31cf9ac1ba6c00f716
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu <xu...@zte.com.cn>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
[Impala-ASF-CR] IMPALA-5506: Add stdin description to help information of query file option
Posted by "Donghui Xu (Code Review)" <ge...@cloudera.org>.
Donghui Xu has posted comments on this change.
Change subject: IMPALA-5506: Add stdin description to help information of query_file option
......................................................................
Patch Set 2:
(1 comment)
I have modified the code according to your opinion.
http://gerrit.cloudera.org:8080/#/c/7178/1/shell/option_parser.py
File shell/option_parser.py:
Line 87: help="Execute the queries in the query file, delimited by ;."
> Please wrap to 90 chars.
Done
--
To view, visit http://gerrit.cloudera.org:8080/7178
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0264174fd062497c72891b31cf9ac1ba6c00f716
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu <xu...@zte.com.cn>
Gerrit-Reviewer: Donghui Xu <xu...@zte.com.cn>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5506: Add stdin description to help information of query file option
Posted by "Henry Robinson (Code Review)" <ge...@cloudera.org>.
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5506: Add stdin description to help information of query_file option
......................................................................
Patch Set 1:
(1 comment)
Thanks for doing this!
http://gerrit.cloudera.org:8080/#/c/7178/1/shell/option_parser.py
File shell/option_parser.py:
Line 87: help="Execute the queries in the query file or from STDIN indicated by - and end input with ctrl+d, delimited by ;")
Please wrap to 90 chars.
The message is good - but may I suggest a minor reword? How about:
"Execute the queries in the query file, delimited by ;. Queries
may be read from stdin if the argument to -f is -."
--
To view, visit http://gerrit.cloudera.org:8080/7178
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0264174fd062497c72891b31cf9ac1ba6c00f716
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu <xu...@zte.com.cn>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5506: Add stdin description to help information of query file option
Posted by "Henry Robinson (Code Review)" <ge...@cloudera.org>.
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5506: Add stdin description to help information of query_file option
......................................................................
Patch Set 2: Code-Review+2
Thanks!
--
To view, visit http://gerrit.cloudera.org:8080/7178
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0264174fd062497c72891b31cf9ac1ba6c00f716
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu <xu...@zte.com.cn>
Gerrit-Reviewer: Donghui Xu <xu...@zte.com.cn>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5506: Add stdin description to help information of query file option
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5506: Add stdin description to help information of query_file option
......................................................................
Patch Set 2:
Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/730/
--
To view, visit http://gerrit.cloudera.org:8080/7178
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0264174fd062497c72891b31cf9ac1ba6c00f716
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu <xu...@zte.com.cn>
Gerrit-Reviewer: Donghui Xu <xu...@zte.com.cn>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-HasComments: No