You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "cstamas (via GitHub)" <gi...@apache.org> on 2023/02/22 14:37:07 UTC
[GitHub] [maven-resolver] cstamas opened a new pull request, #251: IO Fixes
cstamas opened a new pull request, #251:
URL: https://github.com/apache/maven-resolver/pull/251
Seems tracking file is concurrently being read/written.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-resolver] laeubi commented on a diff in pull request #251: IO Fixes
Posted by "laeubi (via GitHub)" <gi...@apache.org>.
laeubi commented on code in PR #251:
URL: https://github.com/apache/maven-resolver/pull/251#discussion_r1114500030
##########
maven-resolver-util/src/main/java/org/eclipse/aether/util/FileUtils.java:
##########
@@ -103,9 +105,14 @@ public Path getPath() {
return tempFile;
}
+ @SuppressWarnings("checkstyle:magicnumber")
@Override
public void move() throws IOException {
- Files.move(tempFile, file, StandardCopyOption.ATOMIC_MOVE);
+ retry(
+ 3,
+ 50,
+ () -> Files.move(tempFile, file, StandardCopyOption.ATOMIC_MOVE),
Review Comment:
should this then not be handled on a higher level?
e.g. in this case one might start all over again (read the current file contents, set new properties, write gain...)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-resolver] michael-o commented on pull request #251: IO Fixes
Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on PR #251:
URL: https://github.com/apache/maven-resolver/pull/251#issuecomment-1440318094
I will try to take a look at this next couple of days...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-resolver] cstamas commented on pull request #251: IO Fixes
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas commented on PR #251:
URL: https://github.com/apache/maven-resolver/pull/251#issuecomment-1443833216
Superseded by:
* https://github.com/apache/maven-resolver/pull/258
* https://github.com/apache/maven-resolver/pull/257
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-resolver] cstamas closed pull request #251: IO Fixes
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas closed pull request #251: IO Fixes
URL: https://github.com/apache/maven-resolver/pull/251
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-resolver] laeubi commented on pull request #251: IO Fixes
Posted by "laeubi (via GitHub)" <gi...@apache.org>.
laeubi commented on PR #251:
URL: https://github.com/apache/maven-resolver/pull/251#issuecomment-1440327752
I have now created a PR that is more "semantically" and retries the full operation if it fails with a randomized timeout:
- https://github.com/apache/maven-resolver/pull/252
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org