You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "mimaison (via GitHub)" <gi...@apache.org> on 2023/09/27 16:36:12 UTC

[GitHub] [kafka] mimaison opened a new pull request, #14464: MINOR: Fix build failure in genConnectOpenAPIDocs

mimaison opened a new pull request, #14464:
URL: https://github.com/apache/kafka/pull/14464

   We bumped the `swagger-gradle-plugin` version in https://github.com/apache/kafka/commit/d1ad1d7b7013ea2c24a3f71c485a2a914adf1348
   
   This breaks the `genConnectOpenAPIDocs` task:
   ```
   > Task :connect:runtime:genConnectOpenAPIDocs FAILED
   
   FAILURE: Build failed with an exception.
   
   * What went wrong:
   Execution failed for task ':connect:runtime:genConnectOpenAPIDocs'.
   > io.swagger.v3.jaxrs2.integration.SwaggerLoader.setSkipResolveAppPath(java.lang.Boolean)
   ```
   
   We've had a similar [breakage](https://github.com/apache/kafka/pull/13387) in the past when `swagger-gradle-plugin` and `swaggerAnnotations`/`swaggerJaxrs2` used different versions. 
   
   As far as I can tell `swaggerAnnotations` and `swaggerJaxrs2` are stuck with 2.2.8 as it's the last version that supports Java 8. I get the build working using `swagger-gradle-plugin` 2.2.10 but it's probably safer, at least for now, to keep these versions aligned.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [kafka] yashmayya commented on pull request #14464: MINOR: Fix build failure in genConnectOpenAPIDocs

Posted by "yashmayya (via GitHub)" <gi...@apache.org>.
yashmayya commented on PR #14464:
URL: https://github.com/apache/kafka/pull/14464#issuecomment-1739637687

   One potential option to prevent such breakages in the future could be to use [this workaround](https://github.com/gradle/gradle/issues/1697#issuecomment-386824663) and set a common Swagger version in the `gradle.properties` that is used in both the `plugins` section (for the `swagger-gradle-plugin`) as well as the `dependencies` section (for `swaggerAnnotations` / `swaggerJaxrs2 `)?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [kafka] mimaison commented on pull request #14464: MINOR: Fix build failure in genConnectOpenAPIDocs

Posted by "mimaison (via GitHub)" <gi...@apache.org>.
mimaison commented on PR #14464:
URL: https://github.com/apache/kafka/pull/14464#issuecomment-1740754108

   Yes it would be good to have the version in a single place to avoid these issues. I created https://issues.apache.org/jira/browse/KAFKA-15521 to track that work.
   
   I'll merge that now to fix the build.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [kafka] mimaison merged pull request #14464: MINOR: Fix build failure in genConnectOpenAPIDocs

Posted by "mimaison (via GitHub)" <gi...@apache.org>.
mimaison merged PR #14464:
URL: https://github.com/apache/kafka/pull/14464


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org