[GitHub] [beam] tvalentyn commented on a change in pull request #13382: [BEAM-9980] do not use hardcoded python versions in validate container dataflow jobs

[GitBox <gi...@apache.org>]

tvalentyn commented on a change in pull request #13382:
URL: https://github.com/apache/beam/pull/13382#discussion_r529087404



##########
File path: .test-infra/jenkins/PythonTestProperties.groovy
##########
@@ -23,8 +23,14 @@ class PythonTestProperties {
     LOWEST_SUPPORTED,
     HIGHEST_SUPPORTED
   ]
+  final static List<String> ALL_SUPPORTED_VERSIONS = [
+    LOWEST_SUPPORTED,

Review comment:
       Let's spell out the versions and if possible assign LOWEST_SUPPORTED=ALL_SUPPORTED_VERSIONS[0], 
   HIGHEST_SUPPORTED=ALL_SUPPORTED_VERSIONS[-1] 
   (I'm not sure of the exact syntax).

##########
File path: .test-infra/jenkins/job_PostCommit_Python_ValidatesContainer_Dataflow.groovy
##########
@@ -19,6 +19,8 @@
 import CommonJobProperties as commonJobProperties
 import PostcommitJobBuilder

Review comment:
       nit: s/VALIDATE_CONTAINER_DATAFLOW_PYTHON_VERSIONS/VALIDATES_CONTAINER_DATAFLOW_PYTHON_VERSIONS/ for consistency with current naming elsewhere.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org