[GitHub] [hive] wecharyu commented on a diff in pull request #4344: HIVE-27362: Migrate Filter.g to Antlr4

["wecharyu (via GitHub)" <gi...@apache.org>]

wecharyu commented on code in PR #4344:
URL: https://github.com/apache/hive/pull/4344#discussion_r1199573216


##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/PartFilterExprUtil.java:
##########
@@ -109,14 +110,22 @@ private static ExpressionTree makeExpressionTree(String filter) throws MetaExcep
     LOG.debug("Filter specified is " + filter);
     ExpressionTree tree = null;
     try {
-      tree = getFilterParser(filter).tree;
+      tree = parseFilterTree(filter);
     } catch (MetaException ex) {
       LOG.info("Unable to make the expression tree from expression string ["
           + filter + "]" + ex.getMessage()); // Don't log the stack, this is normal.
     }
     return tree;
   }
 
+  public static ExpressionTree parseFilterTree(String filter) throws MetaException {
+    return PartFilterParser.parseFilter(filter);
+  }
+
+  /**
+   * @Deprecated Use {@link PartFilterParser#parseFilter(String)} instead.
+   */
+  @Deprecated

Review Comment:
   I will remove the ANTLR3 code in the follow up.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org