[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #1180: MINIFICPP-1530 Put Kafka tests in order

[GitBox <gi...@apache.org>]

lordgamez commented on a change in pull request #1180:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1180#discussion_r724809518



##########
File path: docker/test/integration/features/kafka.feature
##########
@@ -9,15 +9,41 @@ Feature: Sending data to using Kafka streaming platform using PublishKafka
   Scenario: A MiNiFi instance transfers data to a kafka broker
     Given a GetFile processor with the "Input Directory" property set to "/tmp/input"
     And a file with the content "test" is present in "/tmp/input"
+    And a UpdateAttribute processor
+    And these processor properties are set:
+      | processor name  | property name          | property value                        |
+      | UpdateAttribute | kafka_require_num_acks | 1                                     |
+      | UpdateAttribute | kafka_message_key      | unique_message_key_123                |
     And a PublishKafka processor set up to communicate with a kafka broker instance
+    And these processor properties are set:
+      | processor name | property name          | property value                         |
+      | PublishKafka   | Topic Name             | test                                   |
+      | PublishKafka   | Delivery Guarantee     | ${kafka_require_num_acks}              |
+      | PublishKafka   | Request Timeout        | 12 s                                   |
+      | PublishKafka   | Message Timeout        | 13 s                                   |
+      | PublishKafka   | Known Brokers          | kafka-broker:${literal(9000):plus(92)} |
+      | PublishKafka   | Client Name            | client_no_${literal(6):multiply(7)}    |
+      | PublishKafka   | Kafka Key              | ${kafka_message_key}                   |
+      | PublishKafka   | retry.backoff.ms       | ${literal(2):multiply(25):multiply(3)} |
+      | PublishKafka   | Message Key Field      | kafka.key                              |
     And a PutFile processor with the "Directory" property set to "/tmp/output"
-    And the "success" relationship of the GetFile processor is connected to the PublishKafka
+    And the "success" relationship of the GetFile processor is connected to the UpdateAttribute
+    And the "success" relationship of the UpdateAttribute processor is connected to the PublishKafka
     And the "success" relationship of the PublishKafka processor is connected to the PutFile
 
     And a kafka broker is set up in correspondence with the PublishKafka
 
     When both instances start up
     Then a flowfile with the content "test" is placed in the monitored directory in less than 60 seconds
+    And the Minifi logs contain the following message: " is 'test'" in less than 60 seconds
+    And the Minifi logs contain the following message: "PublishKafka: request.required.acks [1]" in less than 60 seconds
+    And the Minifi logs contain the following message: "PublishKafka: request.timeout.ms [12000]" in less than 60 seconds
+    And the Minifi logs contain the following message: "PublishKafka: message.timeout.ms [13000]" in less than 60 seconds
+    And the Minifi logs contain the following message: "PublishKafka: bootstrap.servers [kafka-broker:9092]" in less than 60 seconds
+    And the Minifi logs contain the following message: "PublishKafka: client.id [client_no_42]" in less than 60 seconds
+    And the Minifi logs contain the following message: "PublishKafka: Message Key [unique_message_key_123]" in less than 60 seconds
+    And the Minifi logs contain the following message: "PublishKafka: DynamicProperty: [retry.backoff.ms] -> [150]" in less than 60 seconds
+    And the Minifi logs contain the following message: "The Message Key Field property is set. This property is DEPRECATED and has no effect; please use Kafka Key instead." in less than 60 seconds

Review comment:
       You are right it was missing, I added the check in c8e330072c80476d03d3a84fb001f6a2d3d6a5a9 borrowing regex check functionality from #1172 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org