You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by GitBox <gi...@apache.org> on 2022/09/05 08:29:58 UTC
[GitHub] [incubator-devlake] abeizn commented on a diff in pull request #2950: fix: cached plan must not change result type
abeizn commented on code in PR #2950:
URL: https://github.com/apache/incubator-devlake/pull/2950#discussion_r962631310
##########
plugins/jira/models/migrationscripts/20220716_add_init_tables.go:
##########
@@ -99,8 +117,15 @@ func (*addInitTables) Up(ctx context.Context, db *gorm.DB) error {
}
defer db.Migrator().DropTable(&JiraConnectionTemp{})
+ // cached plan must not change result type in postgres, so need to update db name
+ err = db.Migrator().RenameTable(JiraConnectionV011{}, JiraConnectionV011Bak{})
Review Comment:
> Seems like we could pass the table name as `string` directly, will it be simpler? 
updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org