You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by Brock Noland <br...@cloudera.com> on 2012/07/31 03:55:47 UTC
Review Request: FLUME-1408: ScheduledExecutorService does not log uncaught
Throwables, we should log them
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6220/
-----------------------------------------------------------
Review request for Flume.
Description
-------
Logs uncaught throwables when they would not have been logged.
This addresses bug FLUME-1408.
https://issues.apache.org/jira/browse/FLUME-1408
Diffs
-----
flume-ng-core/src/main/java/org/apache/flume/instrumentation/GangliaServer.java 1104141
flume-ng-core/src/main/java/org/apache/flume/lifecycle/LifecycleSupervisor.java 2ac94df
flume-ng-node/src/main/java/org/apache/flume/conf/file/AbstractFileConfigurationProvider.java 9f900d3
flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/BucketWriter.java 75ff069
flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSEventSink.java d65c5a8
Diff: https://reviews.apache.org/r/6220/diff/
Testing
-------
Thanks,
Brock Noland
Re: Review Request: FLUME-1408: ScheduledExecutorService does not log
uncaught Throwables, we should log them
Posted by Hari Shreedharan <hs...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6220/#review9624
-----------------------------------------------------------
Ship it!
+1.
The HDFS sink comment was my mistake, so let's commit this.
We can add the code in AvroSink later.
- Hari Shreedharan
On July 31, 2012, 1:55 a.m., Brock Noland wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6220/
> -----------------------------------------------------------
>
> (Updated July 31, 2012, 1:55 a.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Logs uncaught throwables when they would not have been logged.
>
>
> This addresses bug FLUME-1408.
> https://issues.apache.org/jira/browse/FLUME-1408
>
>
> Diffs
> -----
>
> flume-ng-core/src/main/java/org/apache/flume/instrumentation/GangliaServer.java 1104141
> flume-ng-core/src/main/java/org/apache/flume/lifecycle/LifecycleSupervisor.java 2ac94df
> flume-ng-node/src/main/java/org/apache/flume/conf/file/AbstractFileConfigurationProvider.java 9f900d3
> flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/BucketWriter.java 75ff069
> flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSEventSink.java d65c5a8
>
> Diff: https://reviews.apache.org/r/6220/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Brock Noland
>
>
Re: Review Request: FLUME-1408: ScheduledExecutorService does not log
uncaught Throwables, we should log them
Posted by Hari Shreedharan <hs...@cloudera.com>.
> On July 31, 2012, 3:16 a.m., Brock Noland wrote:
> > flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/BucketWriter.java, line 221
> > <https://reviews.apache.org/r/6220/diff/2/?file=130913#file130913line221>
> >
> > Where are we calling the .get() method on timedRollFuture?
Ah, it seems we call cancel, not get. You can ignore this comment, sorry about that.
- Hari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6220/#review9622
-----------------------------------------------------------
On July 31, 2012, 1:55 a.m., Brock Noland wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6220/
> -----------------------------------------------------------
>
> (Updated July 31, 2012, 1:55 a.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Logs uncaught throwables when they would not have been logged.
>
>
> This addresses bug FLUME-1408.
> https://issues.apache.org/jira/browse/FLUME-1408
>
>
> Diffs
> -----
>
> flume-ng-core/src/main/java/org/apache/flume/instrumentation/GangliaServer.java 1104141
> flume-ng-core/src/main/java/org/apache/flume/lifecycle/LifecycleSupervisor.java 2ac94df
> flume-ng-node/src/main/java/org/apache/flume/conf/file/AbstractFileConfigurationProvider.java 9f900d3
> flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/BucketWriter.java 75ff069
> flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSEventSink.java d65c5a8
>
> Diff: https://reviews.apache.org/r/6220/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Brock Noland
>
>
Re: Review Request: FLUME-1408: ScheduledExecutorService does not log
uncaught Throwables, we should log them
Posted by Brock Noland <br...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6220/#review9622
-----------------------------------------------------------
flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/BucketWriter.java
<https://reviews.apache.org/r/6220/#comment20532>
Where are we calling the .get() method on timedRollFuture?
- Brock Noland
On July 31, 2012, 1:55 a.m., Brock Noland wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6220/
> -----------------------------------------------------------
>
> (Updated July 31, 2012, 1:55 a.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Logs uncaught throwables when they would not have been logged.
>
>
> This addresses bug FLUME-1408.
> https://issues.apache.org/jira/browse/FLUME-1408
>
>
> Diffs
> -----
>
> flume-ng-core/src/main/java/org/apache/flume/instrumentation/GangliaServer.java 1104141
> flume-ng-core/src/main/java/org/apache/flume/lifecycle/LifecycleSupervisor.java 2ac94df
> flume-ng-node/src/main/java/org/apache/flume/conf/file/AbstractFileConfigurationProvider.java 9f900d3
> flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/BucketWriter.java 75ff069
> flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSEventSink.java d65c5a8
>
> Diff: https://reviews.apache.org/r/6220/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Brock Noland
>
>
Re: Review Request: FLUME-1408: ScheduledExecutorService does not log
uncaught Throwables, we should log them
Posted by Hari Shreedharan <hs...@cloudera.com>.
> On July 31, 2012, 2:57 a.m., Hari Shreedharan wrote:
> > Generally looks good. I have one small suggestion though.
Also, there is at least one other place where we should throw the throwable as is:
NettyAvroRpcClient#append method has an future.get call. I think we should catch throw the cause of the ExecutionException if it is instance of RuntimeException or Error.
- Hari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6220/#review9620
-----------------------------------------------------------
On July 31, 2012, 1:55 a.m., Brock Noland wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6220/
> -----------------------------------------------------------
>
> (Updated July 31, 2012, 1:55 a.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Logs uncaught throwables when they would not have been logged.
>
>
> This addresses bug FLUME-1408.
> https://issues.apache.org/jira/browse/FLUME-1408
>
>
> Diffs
> -----
>
> flume-ng-core/src/main/java/org/apache/flume/instrumentation/GangliaServer.java 1104141
> flume-ng-core/src/main/java/org/apache/flume/lifecycle/LifecycleSupervisor.java 2ac94df
> flume-ng-node/src/main/java/org/apache/flume/conf/file/AbstractFileConfigurationProvider.java 9f900d3
> flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/BucketWriter.java 75ff069
> flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSEventSink.java d65c5a8
>
> Diff: https://reviews.apache.org/r/6220/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Brock Noland
>
>
Re: Review Request: FLUME-1408: ScheduledExecutorService does not log
uncaught Throwables, we should log them
Posted by Hari Shreedharan <hs...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6220/#review9620
-----------------------------------------------------------
Generally looks good. I have one small suggestion though.
flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/BucketWriter.java
<https://reviews.apache.org/r/6220/#comment20531>
Why not rethrow this? There is a method waiting on the future.get() call, so this throwable will eventually cause an ExecutionException.
- Hari Shreedharan
On July 31, 2012, 1:55 a.m., Brock Noland wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6220/
> -----------------------------------------------------------
>
> (Updated July 31, 2012, 1:55 a.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Logs uncaught throwables when they would not have been logged.
>
>
> This addresses bug FLUME-1408.
> https://issues.apache.org/jira/browse/FLUME-1408
>
>
> Diffs
> -----
>
> flume-ng-core/src/main/java/org/apache/flume/instrumentation/GangliaServer.java 1104141
> flume-ng-core/src/main/java/org/apache/flume/lifecycle/LifecycleSupervisor.java 2ac94df
> flume-ng-node/src/main/java/org/apache/flume/conf/file/AbstractFileConfigurationProvider.java 9f900d3
> flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/BucketWriter.java 75ff069
> flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSEventSink.java d65c5a8
>
> Diff: https://reviews.apache.org/r/6220/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Brock Noland
>
>