You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by haosdent huang <ha...@gmail.com> on 2015/08/18 20:29:44 UTC
Review Request 37586: Generate usage help information in libprocess.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37586/
-----------------------------------------------------------
Review request for mesos.
Bugs: MESOS-3239
https://issues.apache.org/jira/browse/MESOS-3239
Repository: mesos
Description
-------
Generate usage help information in libprocess.
Diffs
-----
3rdparty/libprocess/include/process/help.hpp 441f6d1c15afebdd98b73bb7430fcd8c8cf1e333
3rdparty/libprocess/include/process/system.hpp 7c8b49e78f76f9e131a4367f411c6dba447ccd90
3rdparty/libprocess/src/help.cpp e4e0bb617956c7f79380069015b7170aa7716231
3rdparty/libprocess/src/logging.cpp 3d855e90e83a54cd344e49f075af0eadef1a1358
3rdparty/libprocess/src/metrics/metrics.cpp b9617507a16318b7de25d4875d6bc0b4409fcd29
3rdparty/libprocess/src/profiler.cpp 65a2e05e8f6005a378ae3647698dcba60fb95e9f
Diff: https://reviews.apache.org/r/37586/diff/
Testing
-------
manual test
Thanks,
haosdent huang
Re: Review Request 37586: Generate usage help information in
libprocess.
Posted by haosdent huang <ha...@gmail.com>.
> On Aug. 19, 2015, 1:24 a.m., Guangya Liu wrote:
> > Just curious: If change the 3rd party code directly in mesos source code, then how to handle the case when mesos want to upgrade the 3rd party libraries?
because libprocess is maintained in mesos, so we could do it like this here. For other libraries, we use patch way.
- haosdent
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37586/#review95807
-----------------------------------------------------------
On Aug. 18, 2015, 6:32 p.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37586/
> -----------------------------------------------------------
>
> (Updated Aug. 18, 2015, 6:32 p.m.)
>
>
> Review request for mesos, Michael Park and Vinod Kone.
>
>
> Bugs: MESOS-3239
> https://issues.apache.org/jira/browse/MESOS-3239
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Generate usage help information in libprocess.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/help.hpp 441f6d1c15afebdd98b73bb7430fcd8c8cf1e333
> 3rdparty/libprocess/include/process/system.hpp 7c8b49e78f76f9e131a4367f411c6dba447ccd90
> 3rdparty/libprocess/src/help.cpp e4e0bb617956c7f79380069015b7170aa7716231
> 3rdparty/libprocess/src/logging.cpp 3d855e90e83a54cd344e49f075af0eadef1a1358
> 3rdparty/libprocess/src/metrics/metrics.cpp b9617507a16318b7de25d4875d6bc0b4409fcd29
> 3rdparty/libprocess/src/profiler.cpp 65a2e05e8f6005a378ae3647698dcba60fb95e9f
>
> Diff: https://reviews.apache.org/r/37586/diff/
>
>
> Testing
> -------
>
> manual test
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 37586: Generate usage help information in
libprocess.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37586/#review95807
-----------------------------------------------------------
Just curious: If change the 3rd party code directly in mesos source code, then how to handle the case when mesos want to upgrade the 3rd party libraries?
- Guangya Liu
On 八月 18, 2015, 6:32 p.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37586/
> -----------------------------------------------------------
>
> (Updated 八月 18, 2015, 6:32 p.m.)
>
>
> Review request for mesos, Michael Park and Vinod Kone.
>
>
> Bugs: MESOS-3239
> https://issues.apache.org/jira/browse/MESOS-3239
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Generate usage help information in libprocess.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/help.hpp 441f6d1c15afebdd98b73bb7430fcd8c8cf1e333
> 3rdparty/libprocess/include/process/system.hpp 7c8b49e78f76f9e131a4367f411c6dba447ccd90
> 3rdparty/libprocess/src/help.cpp e4e0bb617956c7f79380069015b7170aa7716231
> 3rdparty/libprocess/src/logging.cpp 3d855e90e83a54cd344e49f075af0eadef1a1358
> 3rdparty/libprocess/src/metrics/metrics.cpp b9617507a16318b7de25d4875d6bc0b4409fcd29
> 3rdparty/libprocess/src/profiler.cpp 65a2e05e8f6005a378ae3647698dcba60fb95e9f
>
> Diff: https://reviews.apache.org/r/37586/diff/
>
>
> Testing
> -------
>
> manual test
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 37586: Generate usage help information in
libprocess.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37586/#review95846
-----------------------------------------------------------
Ship it!
Ship It!
- Guangya Liu
On 八月 18, 2015, 6:32 p.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37586/
> -----------------------------------------------------------
>
> (Updated 八月 18, 2015, 6:32 p.m.)
>
>
> Review request for mesos, Michael Park and Vinod Kone.
>
>
> Bugs: MESOS-3239
> https://issues.apache.org/jira/browse/MESOS-3239
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Generate usage help information in libprocess.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/help.hpp 441f6d1c15afebdd98b73bb7430fcd8c8cf1e333
> 3rdparty/libprocess/include/process/system.hpp 7c8b49e78f76f9e131a4367f411c6dba447ccd90
> 3rdparty/libprocess/src/help.cpp e4e0bb617956c7f79380069015b7170aa7716231
> 3rdparty/libprocess/src/logging.cpp 3d855e90e83a54cd344e49f075af0eadef1a1358
> 3rdparty/libprocess/src/metrics/metrics.cpp b9617507a16318b7de25d4875d6bc0b4409fcd29
> 3rdparty/libprocess/src/profiler.cpp 65a2e05e8f6005a378ae3647698dcba60fb95e9f
>
> Diff: https://reviews.apache.org/r/37586/diff/
>
>
> Testing
> -------
>
> manual test
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 37586: Generate usage help information in
libprocess.
Posted by haosdent huang <ha...@gmail.com>.
> On Aug. 30, 2015, 10:16 p.m., Michael Park wrote:
> > 3rdparty/libprocess/src/profiler.cpp, lines 45-46
> > <https://reviews.apache.org/r/37586/diff/2/?file=1043288#file1043288line45>
> >
> > Do you happen to know what the deal is with all the instances of `...` in this particular help message?
Because it is not need any params here, I update the description here.
- haosdent
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37586/#review97038
-----------------------------------------------------------
On Sept. 4, 2015, 6:43 p.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37586/
> -----------------------------------------------------------
>
> (Updated Sept. 4, 2015, 6:43 p.m.)
>
>
> Review request for mesos, Michael Park and Vinod Kone.
>
>
> Bugs: MESOS-3239
> https://issues.apache.org/jira/browse/MESOS-3239
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Generate usage help information in libprocess.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/help.hpp 441f6d1c15afebdd98b73bb7430fcd8c8cf1e333
> 3rdparty/libprocess/include/process/system.hpp 7c8b49e78f76f9e131a4367f411c6dba447ccd90
> 3rdparty/libprocess/src/help.cpp e4e0bb617956c7f79380069015b7170aa7716231
> 3rdparty/libprocess/src/logging.cpp 3d855e90e83a54cd344e49f075af0eadef1a1358
> 3rdparty/libprocess/src/metrics/metrics.cpp b9617507a16318b7de25d4875d6bc0b4409fcd29
> 3rdparty/libprocess/src/profiler.cpp 65a2e05e8f6005a378ae3647698dcba60fb95e9f
>
> Diff: https://reviews.apache.org/r/37586/diff/
>
>
> Testing
> -------
>
> manual test
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 37586: Generate usage help information in
libprocess.
Posted by Michael Park <mc...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37586/#review97038
-----------------------------------------------------------
3rdparty/libprocess/src/help.cpp (line 75)
<https://reviews.apache.org/r/37586/#comment152748>
Not yours, but could you fix the formatting here?
3rdparty/libprocess/src/help.cpp (lines 81 - 84)
<https://reviews.apache.org/r/37586/#comment152750>
If the intention is that we shouldn't have trailing slashes, I think we should simply remove trailing slashes?
```
const string path = "/" + id + strings::remove(name, "/", strings::SUFFIX);
```
In which case we should also update the `const string path = id.get() + name;` call below in `Help::help`. Maybe even pull it out to a helper in order to facilitate keeping them in sync.
A deeper question here for me is: Currently the route `/` is only provided by `help` and `__processes__`, and we already disable `help` with the `if (id != "help")`. Should we also disable `__processes__`?
3rdparty/libprocess/src/help.cpp (line 138)
<https://reviews.apache.org/r/37586/#comment152751>
This is the `path` construction that should stay in sync with the one in `Help::add`.
3rdparty/libprocess/src/logging.cpp (lines 92 - 93)
<https://reviews.apache.org/r/37586/#comment152752>
I don't think you need to add this part. All other `GET` endpoints such as `/files/browse.json` just lists them under `Query parameters:`.
The only thing I would say is that perhaps we should (1) `s/Required query parameters:/Query parameters:/` or (2) `s/Query parameters:/Required query parameters:/` for consistency. I would vote for (1) as it seems to have majority at this point.
3rdparty/libprocess/src/profiler.cpp
<https://reviews.apache.org/r/37586/#comment152749>
Do you happen to know what the deal is with all the instances of `...` in this particular help message?
- Michael Park
On Aug. 18, 2015, 6:32 p.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37586/
> -----------------------------------------------------------
>
> (Updated Aug. 18, 2015, 6:32 p.m.)
>
>
> Review request for mesos, Michael Park and Vinod Kone.
>
>
> Bugs: MESOS-3239
> https://issues.apache.org/jira/browse/MESOS-3239
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Generate usage help information in libprocess.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/help.hpp 441f6d1c15afebdd98b73bb7430fcd8c8cf1e333
> 3rdparty/libprocess/include/process/system.hpp 7c8b49e78f76f9e131a4367f411c6dba447ccd90
> 3rdparty/libprocess/src/help.cpp e4e0bb617956c7f79380069015b7170aa7716231
> 3rdparty/libprocess/src/logging.cpp 3d855e90e83a54cd344e49f075af0eadef1a1358
> 3rdparty/libprocess/src/metrics/metrics.cpp b9617507a16318b7de25d4875d6bc0b4409fcd29
> 3rdparty/libprocess/src/profiler.cpp 65a2e05e8f6005a378ae3647698dcba60fb95e9f
>
> Diff: https://reviews.apache.org/r/37586/diff/
>
>
> Testing
> -------
>
> manual test
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 37586: Generate usage help information in
libprocess.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37586/
-----------------------------------------------------------
(Updated Sept. 4, 2015, 6:53 p.m.)
Review request for mesos, Michael Park and Vinod Kone.
Bugs: MESOS-3239
https://issues.apache.org/jira/browse/MESOS-3239
Repository: mesos
Description
-------
Generate usage help information in libprocess.
Diffs (updated)
-----
3rdparty/libprocess/include/process/help.hpp 441f6d1c15afebdd98b73bb7430fcd8c8cf1e333
3rdparty/libprocess/include/process/system.hpp 7c8b49e78f76f9e131a4367f411c6dba447ccd90
3rdparty/libprocess/src/help.cpp e4e0bb617956c7f79380069015b7170aa7716231
3rdparty/libprocess/src/logging.cpp 3d855e90e83a54cd344e49f075af0eadef1a1358
3rdparty/libprocess/src/metrics/metrics.cpp b9617507a16318b7de25d4875d6bc0b4409fcd29
3rdparty/libprocess/src/profiler.cpp 65a2e05e8f6005a378ae3647698dcba60fb95e9f
Diff: https://reviews.apache.org/r/37586/diff/
Testing
-------
manual test
Thanks,
haosdent huang
Re: Review Request 37586: Generate usage help information in
libprocess.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37586/
-----------------------------------------------------------
(Updated Sept. 4, 2015, 6:43 p.m.)
Review request for mesos, Michael Park and Vinod Kone.
Changes
-------
Update according @mcypark reviews.
Bugs: MESOS-3239
https://issues.apache.org/jira/browse/MESOS-3239
Repository: mesos
Description
-------
Generate usage help information in libprocess.
Diffs (updated)
-----
3rdparty/libprocess/include/process/help.hpp 441f6d1c15afebdd98b73bb7430fcd8c8cf1e333
3rdparty/libprocess/include/process/system.hpp 7c8b49e78f76f9e131a4367f411c6dba447ccd90
3rdparty/libprocess/src/help.cpp e4e0bb617956c7f79380069015b7170aa7716231
3rdparty/libprocess/src/logging.cpp 3d855e90e83a54cd344e49f075af0eadef1a1358
3rdparty/libprocess/src/metrics/metrics.cpp b9617507a16318b7de25d4875d6bc0b4409fcd29
3rdparty/libprocess/src/profiler.cpp 65a2e05e8f6005a378ae3647698dcba60fb95e9f
Diff: https://reviews.apache.org/r/37586/diff/
Testing
-------
manual test
Thanks,
haosdent huang
Re: Review Request 37586: Generate usage help information in
libprocess.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37586/
-----------------------------------------------------------
(Updated Aug. 18, 2015, 6:32 p.m.)
Review request for mesos, Michael Park and Vinod Kone.
Bugs: MESOS-3239
https://issues.apache.org/jira/browse/MESOS-3239
Repository: mesos
Description
-------
Generate usage help information in libprocess.
Diffs (updated)
-----
3rdparty/libprocess/include/process/help.hpp 441f6d1c15afebdd98b73bb7430fcd8c8cf1e333
3rdparty/libprocess/include/process/system.hpp 7c8b49e78f76f9e131a4367f411c6dba447ccd90
3rdparty/libprocess/src/help.cpp e4e0bb617956c7f79380069015b7170aa7716231
3rdparty/libprocess/src/logging.cpp 3d855e90e83a54cd344e49f075af0eadef1a1358
3rdparty/libprocess/src/metrics/metrics.cpp b9617507a16318b7de25d4875d6bc0b4409fcd29
3rdparty/libprocess/src/profiler.cpp 65a2e05e8f6005a378ae3647698dcba60fb95e9f
Diff: https://reviews.apache.org/r/37586/diff/
Testing
-------
manual test
Thanks,
haosdent huang