You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Saurabh Seth <sa...@gmail.com> on 2018/09/25 10:07:04 UTC

Review Request 68836: HIVE-17917 VectorizedOrcAcidRowBatchReader.computeOffsetAndBucket optimization

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68836/
-----------------------------------------------------------

Review request for hive and Eugene Koifman.


Bugs: HIVE-17917
    https://issues.apache.org/jira/browse/HIVE-17917


Repository: hive-git


Description
-------

VectorizedOrcAcidRowBatchReader.computeOffsetAndBucket optimization() computation is currently (after HIVE-17458) is done once per split. It could instead be done once per file (since the result is the same for each split of the same file) and passed along in OrcSplit


Diffs
-----

  ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java f34f393fb8 
  ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcSplit.java bce7977929 
  ql/src/java/org/apache/hadoop/hive/ql/io/orc/VectorizedOrcAcidRowBatchReader.java 1841cfaa2e 
  ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestInputOutputFormat.java 208aeb5b1f 
  ql/src/test/queries/clientpositive/acid_vectorization_original.q 5082aedf90 
  ql/src/test/results/clientpositive/llap/acid_vectorization_original.q.out 99c741c7bd 


Diff: https://reviews.apache.org/r/68836/diff/1/


Testing
-------


Thanks,

Saurabh Seth


Re: Review Request 68836: HIVE-17917 VectorizedOrcAcidRowBatchReader.computeOffsetAndBucket optimization

Posted by Saurabh Seth <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68836/
-----------------------------------------------------------

(Updated Sept. 26, 2018, 10:06 a.m.)


Review request for hive and Eugene Koifman.


Changes
-------

Fixed the checkstyle and findbugs errors. These were pre-existing ones but because they were on lines where I made minor changes, they were reported as new ones. These were trivial ones, so I fixed them:

./ql/src/java/org/apache/hadoop/hive/ql/io/orc/VectorizedOrcAcidRowBatchReader.java:266:        return new OrcSplit.OffsetAndBucketProperty(-1,-1, syntheticTxnInfo.syntheticWriteId);:56: warning: ',' is not followed by whitespace.

Redundant null check at VectorizedOrcAcidRowBatchReader.java:[line 495]


Bugs: HIVE-17917
    https://issues.apache.org/jira/browse/HIVE-17917


Repository: hive-git


Description
-------

VectorizedOrcAcidRowBatchReader.computeOffsetAndBucket optimization() computation is currently (after HIVE-17458) is done once per split. It could instead be done once per file (since the result is the same for each split of the same file) and passed along in OrcSplit


Diffs (updated)
-----

  ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java f34f393fb8 
  ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcSplit.java bce7977929 
  ql/src/java/org/apache/hadoop/hive/ql/io/orc/VectorizedOrcAcidRowBatchReader.java 1841cfaa2e 
  ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestInputOutputFormat.java 208aeb5b1f 
  ql/src/test/queries/clientpositive/acid_vectorization_original.q 5082aedf90 
  ql/src/test/results/clientpositive/llap/acid_vectorization_original.q.out 99c741c7bd 


Diff: https://reviews.apache.org/r/68836/diff/2/

Changes: https://reviews.apache.org/r/68836/diff/1-2/


Testing
-------


Thanks,

Saurabh Seth