You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by "clolov (via GitHub)" <gi...@apache.org> on 2023/02/02 11:47:51 UTC

[GitHub] [kafka] clolov commented on pull request #13184: KAFKA-14671: Refactor PredicatedTransformation to not implement Transformation

clolov commented on PR #13184:
URL: https://github.com/apache/kafka/pull/13184#issuecomment-1413610633

   To be honest, when I read this code a class which is "kind of" like a Transformation but throws because some methods are not implemented made more sense than wrapping Transformations in a (Maybe)PredicatedTransformation. As such, I am more in favour of the approach currently taken. @tombentley what is your opinion since you implemented this class?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org