You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/08/11 04:07:08 UTC
[GitHub] [inlong] GanfengTan opened a new pull request, #5475: [INLONG-5474][Manager][Agent] Add metadata parameter
GanfengTan opened a new pull request, #5475:
URL: https://github.com/apache/inlong/pull/5475
Support metadata filters by labels.
- Fixes #5474
### Motivation
No
### Modifications
No
### Verifying this change
*(Please pick either of the following options)*
- [x] This change is a trivial rework/code cleanup without any test coverage.
- [ ] This change is already covered by existing tests, such as:
*(please describe tests)*
- [ ] This change added tests and can be verified as follows:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] healchow commented on a diff in pull request #5475: [INLONG-5474][Manager][Agent] Add metadata parameter
Posted by GitBox <gi...@apache.org>.
healchow commented on code in PR #5475:
URL: https://github.com/apache/inlong/pull/5475#discussion_r943543251
##########
inlong-manager/manager-pojo/src/main/java/org/apache/inlong/manager/pojo/source/file/FileSourceDTO.java:
##########
@@ -82,6 +82,9 @@ public class FileSourceDTO {
@ApiModelProperty("Column separator of data source ")
private String dataSeparator;
+ @ApiModelProperty("Metadata filters by label")
+ private Map<String, String> filterMetaByLabels;
Review Comment:
Why is this field in `FileSource` is `List<Map<>>`, but here is `Map<>`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] GanfengTan commented on a diff in pull request #5475: [INLONG-5474][Manager][Agent] Add metadata parameter
Posted by GitBox <gi...@apache.org>.
GanfengTan commented on code in PR #5475:
URL: https://github.com/apache/inlong/pull/5475#discussion_r943557742
##########
inlong-manager/manager-pojo/src/main/java/org/apache/inlong/manager/pojo/source/file/FileSourceDTO.java:
##########
@@ -82,6 +82,9 @@ public class FileSourceDTO {
@ApiModelProperty("Column separator of data source ")
private String dataSeparator;
+ @ApiModelProperty("Metadata filters by label")
+ private Map<String, String> filterMetaByLabels;
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] healchow merged pull request #5475: [INLONG-5474][Manager][Agent] Add metadata parameter
Posted by GitBox <gi...@apache.org>.
healchow merged PR #5475:
URL: https://github.com/apache/inlong/pull/5475
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org