You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by ma...@apache.org on 2016/01/26 11:24:56 UTC

svn commit: r1726760 [2/3] - in /james/project/trunk: mailbox/api/src/main/java/org/apache/james/mailbox/ mailbox/api/src/main/java/org/apache/james/mailbox/acl/ mailbox/api/src/main/java/org/apache/james/mailbox/model/ mailbox/caching/src/main/java/or...

Modified: james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/api/ImapConstants.java
URL: http://svn.apache.org/viewvc/james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/api/ImapConstants.java?rev=1726760&r1=1726759&r2=1726760&view=diff
==============================================================================
--- james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/api/ImapConstants.java (original)
+++ james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/api/ImapConstants.java Tue Jan 26 10:24:54 2016
@@ -21,278 +21,278 @@ package org.apache.james.imap.api;
 
 public interface ImapConstants {
     // Basic response types
-    public static final String OK = "OK";
+    String OK = "OK";
 
-    public static final String NO = "NO";
+    String NO = "NO";
 
-    public static final String BAD = "BAD";
+    String BAD = "BAD";
 
-    public static final String BYE = "BYE";
+    String BYE = "BYE";
 
-    public static final String UNTAGGED = "*";
+    String UNTAGGED = "*";
 
-    public static final String CONTINUATION = "+";
+    String CONTINUATION = "+";
 
-    public static final String SP = " ";
+    String SP = " ";
 
-    public static final String NIL = "NIL";
+    String NIL = "NIL";
 
-    public static final String UID = "UID";
+    String UID = "UID";
 
-    public static final String MIME_HEADER_CONTENT_LOCATION = "Content-Location";
+    String MIME_HEADER_CONTENT_LOCATION = "Content-Location";
 
-    public static final String MIME_HEADER_CONTENT_MD5 = "Content-MD5";
+    String MIME_HEADER_CONTENT_MD5 = "Content-MD5";
 
-    public static final String MIME_HEADER_CONTENT_LANGUAGE = "Content-Language";
+    String MIME_HEADER_CONTENT_LANGUAGE = "Content-Language";
 
-    public static final String[] EMPTY_STRING_ARRAY = {};
+    String[] EMPTY_STRING_ARRAY = {};
 
-    public static final byte BYTE_OPENING_PARENTHESIS = 0x28;
+    byte BYTE_OPENING_PARENTHESIS = 0x28;
 
-    public static final byte BYTE_CLOSING_PARENTHESIS = 0x29;
+    byte BYTE_CLOSING_PARENTHESIS = 0x29;
 
-    public static final byte BYTE_SP = 0x20;
+    byte BYTE_SP = 0x20;
 
-    public static final byte BYTE_DQUOTE = 0x22;
+    byte BYTE_DQUOTE = 0x22;
 
-    public static final byte BYTE_BACK_SLASH = 0x5C;
+    byte BYTE_BACK_SLASH = 0x5C;
 
-    public static final byte BYTE_QUESTION = 0x3F;
+    byte BYTE_QUESTION = 0x3F;
 
-    public static final byte BYTE_OPEN_SQUARE_BRACKET = 0x5B;
+    byte BYTE_OPEN_SQUARE_BRACKET = 0x5B;
 
-    public static final byte BYTE_CLOSE_SQUARE_BRACKET = 0x5D;
+    byte BYTE_CLOSE_SQUARE_BRACKET = 0x5D;
 
-    public static final byte BYTE_OPEN_BRACE = 0x7B;
+    byte BYTE_OPEN_BRACE = 0x7B;
 
-    public static final byte BYTE_CLOSE_BRACE = 0x7D;
+    byte BYTE_CLOSE_BRACE = 0x7D;
 
-    public static final char OPENING_PARENTHESIS = '(';
+    char OPENING_PARENTHESIS = '(';
 
-    public static final char CLOSING_PARENTHESIS = ')';
+    char CLOSING_PARENTHESIS = ')';
 
-    public static final char OPENING_SQUARE_BRACKET = '[';
+    char OPENING_SQUARE_BRACKET = '[';
 
-    public static final char CLOSING_SQUARE_BRACKET = ']';
+    char CLOSING_SQUARE_BRACKET = ']';
 
-    public static final char SP_CHAR = ' ';
+    char SP_CHAR = ' ';
 
-    public static final char DQUOTE = '\"';
+    char DQUOTE = '\"';
 
-    public static final String VERSION = "IMAP4rev1";
+    String VERSION = "IMAP4rev1";
 
-    public static final String SUPPORTS_LITERAL_PLUS = "LITERAL+";
+    String SUPPORTS_LITERAL_PLUS = "LITERAL+";
 
-    public static final String SUPPORTS_RFC3348 = "CHILDREN";
+    String SUPPORTS_RFC3348 = "CHILDREN";
 
-    public static final String UTF8 = "UTF-8";
+    String UTF8 = "UTF-8";
     
-    public static final String SUPPORTS_I18NLEVEL_1 = "I18NLEVEL=1";
+    String SUPPORTS_I18NLEVEL_1 = "I18NLEVEL=1";
 
-    public static final String SUPPORTS_NAMESPACES = "NAMESPACE";
+    String SUPPORTS_NAMESPACES = "NAMESPACE";
 
-    public static final String SUPPORTS_STARTTLS = "STARTTLS";
+    String SUPPORTS_STARTTLS = "STARTTLS";
 
-    public static final String SUPPORTS_IDLE = "IDLE";
+    String SUPPORTS_IDLE = "IDLE";
 
-    public static final String SUPPORTS_XLIST = "XLIST";
+    String SUPPORTS_XLIST = "XLIST";
 
-    public static final String SUPPORTS_ENABLE = "ENABLE";
+    String SUPPORTS_ENABLE = "ENABLE";
     
-    public static final String SUPPORTS_CONDSTORE = "CONDSTORE";
+    String SUPPORTS_CONDSTORE = "CONDSTORE";
     
-    public static final String SUPPORTS_QRESYNC = "QRESYNC";
+    String SUPPORTS_QRESYNC = "QRESYNC";
 
-    public static final String SUPPORTS_ACL = "ACL";
+    String SUPPORTS_ACL = "ACL";
 
-    public static final String SUPPORTS_QUOTA = "QUOTA";
+    String SUPPORTS_QUOTA = "QUOTA";
     
-    public static final String INBOX_NAME = "INBOX";
+    String INBOX_NAME = "INBOX";
 
-    public static final String MIME_TYPE_TEXT = "TEXT";
+    String MIME_TYPE_TEXT = "TEXT";
 
-    public static final String MIME_TYPE_MULTIPART = "MULTIPART";
+    String MIME_TYPE_MULTIPART = "MULTIPART";
 
-    public static final String MIME_SUBTYPE_PLAIN = "PLAIN";
+    String MIME_SUBTYPE_PLAIN = "PLAIN";
 
-    public static final String MIME_TYPE_MESSAGE = "MESSAGE";
+    String MIME_TYPE_MESSAGE = "MESSAGE";
 
-    public static final String MIME_SUBTYPE_RFC822 = "RFC822";
+    String MIME_SUBTYPE_RFC822 = "RFC822";
 
     // RFC822 CONSTANTS:
     // TODO: Consider switching to standard case
-    public static final String RFC822_BCC = "Bcc";
+    String RFC822_BCC = "Bcc";
 
-    public static final String RFC822_CC = "Cc";
+    String RFC822_CC = "Cc";
 
-    public static final String RFC822_FROM = "From";
+    String RFC822_FROM = "From";
 
-    public static final String RFC822_DATE = "Date";
+    String RFC822_DATE = "Date";
 
-    public static final String RFC822_SUBJECT = "Subject";
+    String RFC822_SUBJECT = "Subject";
 
-    public static final String RFC822_TO = "To";
+    String RFC822_TO = "To";
 
-    public static final String RFC822_SENDER = "Sender";
+    String RFC822_SENDER = "Sender";
 
-    public static final String RFC822_REPLY_TO = "Reply-To";
+    String RFC822_REPLY_TO = "Reply-To";
 
-    public static final String RFC822_IN_REPLY_TO = "In-Reply-To";
+    String RFC822_IN_REPLY_TO = "In-Reply-To";
 
-    public static final String RFC822_MESSAGE_ID = "Message-ID";
+    String RFC822_MESSAGE_ID = "Message-ID";
 
-    public static final String NAME_ATTRIBUTE_HAS_CHILDREN = "\\HasChildren";
+    String NAME_ATTRIBUTE_HAS_CHILDREN = "\\HasChildren";
 
-    public static final String NAME_ATTRIBUTE_HAS_NO_CHILDREN = "\\HasNoChildren";
+    String NAME_ATTRIBUTE_HAS_NO_CHILDREN = "\\HasNoChildren";
 
-    public static final String NAMESPACE_COMMAND_NAME = "NAMESPACE";
+    String NAMESPACE_COMMAND_NAME = "NAMESPACE";
 
-    public static final char BACK_SLASH = '\\';
+    char BACK_SLASH = '\\';
 
-    public static final String STATUS_UNSEEN = "UNSEEN";
+    String STATUS_UNSEEN = "UNSEEN";
 
-    public static final String STATUS_UIDVALIDITY = "UIDVALIDITY";
+    String STATUS_UIDVALIDITY = "UIDVALIDITY";
 
-    public static final String STATUS_UIDNEXT = "UIDNEXT";
+    String STATUS_UIDNEXT = "UIDNEXT";
 
-    public static final String STATUS_RECENT = "RECENT";
+    String STATUS_RECENT = "RECENT";
 
-    public static final String STATUS_MESSAGES = "MESSAGES";
+    String STATUS_MESSAGES = "MESSAGES";
     
-    public static final String STATUS_HIGHESTMODSEQ = "HIGHESTMODSEQ";
+    String STATUS_HIGHESTMODSEQ = "HIGHESTMODSEQ";
 
-    public static final String UNSUBSCRIBE_COMMAND_NAME = "UNSUBSCRIBE";
+    String UNSUBSCRIBE_COMMAND_NAME = "UNSUBSCRIBE";
 
-    public static final String UID_COMMAND_NAME = "UID";
+    String UID_COMMAND_NAME = "UID";
 
-    public static final String SUBSCRIBE_COMMAND_NAME = "SUBSCRIBE";
+    String SUBSCRIBE_COMMAND_NAME = "SUBSCRIBE";
 
-    public static final String STORE_COMMAND_NAME = "STORE";
+    String STORE_COMMAND_NAME = "STORE";
 
-    public static final String STATUS_COMMAND_NAME = "STATUS";
+    String STATUS_COMMAND_NAME = "STATUS";
 
-    public static final String SELECT_COMMAND_NAME = "SELECT";
+    String SELECT_COMMAND_NAME = "SELECT";
 
-    public static final String UNSELECT_COMMAND_NAME = "UNSELECT";
+    String UNSELECT_COMMAND_NAME = "UNSELECT";
 
-    public static final String SEARCH_COMMAND_NAME = "SEARCH";
+    String SEARCH_COMMAND_NAME = "SEARCH";
 
-    public static final String RENAME_COMMAND_NAME = "RENAME";
+    String RENAME_COMMAND_NAME = "RENAME";
 
-    public static final String NOOP_COMMAND_NAME = "NOOP";
+    String NOOP_COMMAND_NAME = "NOOP";
 
-    public static final String IDLE_COMMAND_NAME = "IDLE";
+    String IDLE_COMMAND_NAME = "IDLE";
 
-    public static final String LSUB_COMMAND_NAME = "LSUB";
+    String LSUB_COMMAND_NAME = "LSUB";
 
-    public static final String LOGOUT_COMMAND_NAME = "LOGOUT";
+    String LOGOUT_COMMAND_NAME = "LOGOUT";
 
-    public static final String LOGIN_COMMAND_NAME = "LOGIN";
+    String LOGIN_COMMAND_NAME = "LOGIN";
 
-    public static final String LIST_COMMAND_NAME = "LIST";
+    String LIST_COMMAND_NAME = "LIST";
 
-    public static final String XLIST_COMMAND_NAME = "XLIST";
+    String XLIST_COMMAND_NAME = "XLIST";
 
-    public static final String FETCH_COMMAND_NAME = "FETCH";
+    String FETCH_COMMAND_NAME = "FETCH";
 
-    public static final String EXPUNGE_COMMAND_NAME = "EXPUNGE";
+    String EXPUNGE_COMMAND_NAME = "EXPUNGE";
 
-    public static final String EXAMINE_COMMAND_NAME = "EXAMINE";
+    String EXAMINE_COMMAND_NAME = "EXAMINE";
 
-    public static final String DELETE_COMMAND_NAME = "DELETE";
+    String DELETE_COMMAND_NAME = "DELETE";
 
-    public static final String CREATE_COMMAND_NAME = "CREATE";
+    String CREATE_COMMAND_NAME = "CREATE";
 
-    public static final String COPY_COMMAND_NAME = "COPY";
+    String COPY_COMMAND_NAME = "COPY";
 
-    public static final String MOVE_COMMAND_NAME = "MOVE";
+    String MOVE_COMMAND_NAME = "MOVE";
 
-    public static final String CLOSE_COMMAND_NAME = "CLOSE";
+    String CLOSE_COMMAND_NAME = "CLOSE";
 
-    public static final String CHECK_COMMAND_NAME = "CHECK";
+    String CHECK_COMMAND_NAME = "CHECK";
 
-    public static final String CAPABILITY_COMMAND_NAME = "CAPABILITY";
+    String CAPABILITY_COMMAND_NAME = "CAPABILITY";
 
-    public static final String AUTHENTICATE_COMMAND_NAME = "AUTHENTICATE";
+    String AUTHENTICATE_COMMAND_NAME = "AUTHENTICATE";
 
-    public static final String APPEND_COMMAND_NAME = "APPEND";
+    String APPEND_COMMAND_NAME = "APPEND";
     
-    public static final String ENABLE_COMMAND_NAME = "ENABLE";
+    String ENABLE_COMMAND_NAME = "ENABLE";
     
-    public static final String GETACL_COMMAND_NAME = "GETACL";
+    String GETACL_COMMAND_NAME = "GETACL";
 
-    public static final String SETACL_COMMAND_NAME = "SETACL";
+    String SETACL_COMMAND_NAME = "SETACL";
     
-    public static final String DELETEACL_COMMAND_NAME = "DELETEACL";
+    String DELETEACL_COMMAND_NAME = "DELETEACL";
     
-    public static final String LISTRIGHTS_COMMAND_NAME = "LISTRIGHTS";
+    String LISTRIGHTS_COMMAND_NAME = "LISTRIGHTS";
     
-    public static final String MYRIGHTS_COMMAND_NAME = "MYRIGHTS";
+    String MYRIGHTS_COMMAND_NAME = "MYRIGHTS";
 
-    public static final String GETQUOTAROOT_COMMAND_NAME = "GETQUOTAROOT";
+    String GETQUOTAROOT_COMMAND_NAME = "GETQUOTAROOT";
 
-    public static final String GETQUOTA_COMMAND_NAME = "GETQUOTA";
+    String GETQUOTA_COMMAND_NAME = "GETQUOTA";
 
-    public static final String SETQUOTA_COMMAND_NAME = "SETQUOTA";
+    String SETQUOTA_COMMAND_NAME = "SETQUOTA";
 
-    public static final String LIST_RESPONSE_NAME = "LIST";
+    String LIST_RESPONSE_NAME = "LIST";
 
-    public static final String XLIST_RESPONSE_NAME = "XLIST";
+    String XLIST_RESPONSE_NAME = "XLIST";
 
-    public static final String LSUB_RESPONSE_NAME = "LSUB";
+    String LSUB_RESPONSE_NAME = "LSUB";
 
-    public static final String SEARCH_RESPONSE_NAME = "SEARCH";
+    String SEARCH_RESPONSE_NAME = "SEARCH";
 
-    public static final String ACL_RESPONSE_NAME = "ACL";
+    String ACL_RESPONSE_NAME = "ACL";
 
-    public static final String QUOTA_RESPONSE_NAME = "QUOTA";
+    String QUOTA_RESPONSE_NAME = "QUOTA";
 
-    public static final String QUOTAROOT_RESPONSE_NAME = "QUOTAROOT";
+    String QUOTAROOT_RESPONSE_NAME = "QUOTAROOT";
 
-    public static final String LISTRIGHTS_RESPONSE_NAME = "LISTRIGHTS";
+    String LISTRIGHTS_RESPONSE_NAME = "LISTRIGHTS";
     
-    public static final String MYRIGHTS_RESPONSE_NAME = "MYRIGHTS";
+    String MYRIGHTS_RESPONSE_NAME = "MYRIGHTS";
 
-    public static final String NAME_ATTRIBUTE_NOINFERIORS = "\\Noinferiors";
+    String NAME_ATTRIBUTE_NOINFERIORS = "\\Noinferiors";
 
-    public static final String NAME_ATTRIBUTE_NOSELECT = "\\Noselect";
+    String NAME_ATTRIBUTE_NOSELECT = "\\Noselect";
 
-    public static final String NAME_ATTRIBUTE_MARKED = "\\Marked";
+    String NAME_ATTRIBUTE_MARKED = "\\Marked";
 
-    public static final String NAME_ATTRIBUTE_UNMARKED = "\\Unmarked";
+    String NAME_ATTRIBUTE_UNMARKED = "\\Unmarked";
 
-    public static final String PS_TEXT = "TEXT";
+    String PS_TEXT = "TEXT";
 
-    public static final String PS_HEADER = "HEADER";
+    String PS_HEADER = "HEADER";
 
-    public static final String PS_MIME = "MIME";
+    String PS_MIME = "MIME";
 
-    public static final String FETCH_RFC822 = "RFC822";
+    String FETCH_RFC822 = "RFC822";
 
-    public static final String FETCH_RFC822_HEADER = "RFC822.HEADER";
+    String FETCH_RFC822_HEADER = "RFC822.HEADER";
 
-    public static final String FETCH_RFC822_TEXT = "RFC822.TEXT";
+    String FETCH_RFC822_TEXT = "RFC822.TEXT";
 
-    public static final String FETCH_BODY_STRUCTURE = "BODYSTRUCTURE";
+    String FETCH_BODY_STRUCTURE = "BODYSTRUCTURE";
 
-    public static final String FETCH_BODY = "BODY";
+    String FETCH_BODY = "BODY";
     
-    public static final String FETCH_MODSEQ = "MODSEQ";
+    String FETCH_MODSEQ = "MODSEQ";
 
     
-    public static final String STARTTLS = "STARTTLS";
+    String STARTTLS = "STARTTLS";
 
-    public static final String LINE_END = "\r\n";
-    public static final long MAX_NZ_NUMBER = 4294967295L;
-    public static final long MIN_NZ_NUMBER = 1L;
+    String LINE_END = "\r\n";
+    long MAX_NZ_NUMBER = 4294967295L;
+    long MIN_NZ_NUMBER = 1L;
 
-    public static final String COMPRESS_COMMAND_NAME = "COMPRESS";
+    String COMPRESS_COMMAND_NAME = "COMPRESS";
 
-    public static final int DEFAULT_BATCH_SIZE = 100;
+    int DEFAULT_BATCH_SIZE = 100;
 
     // Quota resources definition
 
-    public static final String STORAGE_QUOTA_RESOURCE = "STORAGE";
+    String STORAGE_QUOTA_RESOURCE = "STORAGE";
 
-    public static final String MESSAGE_QUOTA_RESOURCE = "MESSAGE";
+    String MESSAGE_QUOTA_RESOURCE = "MESSAGE";
 }

Modified: james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/api/display/Localizer.java
URL: http://svn.apache.org/viewvc/james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/api/display/Localizer.java?rev=1726760&r1=1726759&r2=1726760&view=diff
==============================================================================
--- james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/api/display/Localizer.java (original)
+++ james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/api/display/Localizer.java Tue Jan 26 10:24:54 2016
@@ -54,5 +54,5 @@ public interface Localizer {
      *            describes preferences, not null
      * @return localized message not null
      */
-    public String localize(HumanReadableText text, Locales locales);
+    String localize(HumanReadableText text, Locales locales);
 }

Modified: james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/api/message/request/ImapRequest.java
URL: http://svn.apache.org/viewvc/james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/api/message/request/ImapRequest.java?rev=1726760&r1=1726759&r2=1726760&view=diff
==============================================================================
--- james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/api/message/request/ImapRequest.java (original)
+++ james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/api/message/request/ImapRequest.java Tue Jan 26 10:24:54 2016
@@ -32,13 +32,13 @@ public interface ImapRequest extends Ima
      * 
      * @return <code>ImapCommand</code>, not null
      */
-    public abstract ImapCommand getCommand();
+    ImapCommand getCommand();
 
     /**
      * Gets the prefix tag identifying this request.
      * 
      * @return the tag identifying the client request, not null
      */
-    public abstract String getTag();
+    String getTag();
 
 }
\ No newline at end of file

Modified: james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/api/message/response/StatusResponse.java
URL: http://svn.apache.org/viewvc/james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/api/message/response/StatusResponse.java?rev=1726760&r1=1726759&r2=1726760&view=diff
==============================================================================
--- james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/api/message/response/StatusResponse.java (original)
+++ james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/api/message/response/StatusResponse.java Tue Jan 26 10:24:54 2016
@@ -47,40 +47,40 @@ public interface StatusResponse extends
      * @return The type, either {@link Type#BAD}, {@link Type#BYE}, {@link Type#NO},
      *         {@link Type#OK} or {@link Type#PREAUTH}
      */
-    public Type getServerResponseType();
+    Type getServerResponseType();
 
     /**
      * Gets the tag.
      * 
      * @return if tagged response, the tag. Otherwise null.
      */
-    public String getTag();
+    String getTag();
 
     /**
      * Gets the command.
      * 
      * @return if tagged response, the command. Otherwise null
      */
-    public ImapCommand getCommand();
+    ImapCommand getCommand();
 
     /**
      * Gets the key to the human readable text to be displayed. Required.
      * 
      * @return key for the text message to be displayed, not null
      */
-    public HumanReadableText getTextKey();
+    HumanReadableText getTextKey();
 
     /**
      * Gets the response code. Optional.
      * 
      * @return <code>ResponseCode</code>, or null if there is no response code
      */
-    public ResponseCode getResponseCode();
+    ResponseCode getResponseCode();
 
     /**
      * Enumerates types of RC2060 status response
      */
-    public enum Type {
+    enum Type {
         /** RFC2060 <code>OK</code> server response */
         OK("OK"),
         /** RFC2060 <code>OK</code> server response */
@@ -110,7 +110,7 @@ public interface StatusResponse extends
     /**
      * Enumerates response codes.
      */
-    public static final class ResponseCode {
+    final class ResponseCode {
 
         /** RFC2060 <code>ALERT</code> response code */
         private static final ResponseCode ALERT = new ResponseCode("ALERT");

Modified: james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/api/message/response/StatusResponseFactory.java
URL: http://svn.apache.org/viewvc/james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/api/message/response/StatusResponseFactory.java?rev=1726760&r1=1726759&r2=1726760&view=diff
==============================================================================
--- james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/api/message/response/StatusResponseFactory.java (original)
+++ james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/api/message/response/StatusResponseFactory.java Tue Jan 26 10:24:54 2016
@@ -41,7 +41,7 @@ public interface StatusResponseFactory {
      *            <code>ResponseCode</code>, not null
      * @return <code>StatusResponse</code>, not null
      */
-    public StatusResponse taggedOk(String tag, ImapCommand command, HumanReadableText displayTextKey, StatusResponse.ResponseCode code);
+    StatusResponse taggedOk(String tag, ImapCommand command, HumanReadableText displayTextKey, StatusResponse.ResponseCode code);
 
     /**
      * Creates a tagged NO status response.
@@ -56,7 +56,7 @@ public interface StatusResponseFactory {
      *            <code>ResponseCode</code>, not null
      * @return <code>StatusResponse</code>, not null
      */
-    public StatusResponse taggedNo(String tag, ImapCommand command, HumanReadableText displayTextKey, StatusResponse.ResponseCode code);
+    StatusResponse taggedNo(String tag, ImapCommand command, HumanReadableText displayTextKey, StatusResponse.ResponseCode code);
 
     /**
      * Creates a tagged BAD status response.
@@ -71,7 +71,7 @@ public interface StatusResponseFactory {
      *            <code>ResponseCode</code>, not null
      * @return <code>StatusResponse</code>, not null
      */
-    public StatusResponse taggedBad(String tag, ImapCommand command, HumanReadableText displayTextKey, StatusResponse.ResponseCode code);
+    StatusResponse taggedBad(String tag, ImapCommand command, HumanReadableText displayTextKey, StatusResponse.ResponseCode code);
 
     /**
      * Creates a untagged OK status response.
@@ -82,7 +82,7 @@ public interface StatusResponseFactory {
      *            <code>ResponseCode</code>, not null
      * @return <code>StatusResponse</code>, not null
      */
-    public StatusResponse untaggedOk(HumanReadableText displayTextKey, StatusResponse.ResponseCode code);
+    StatusResponse untaggedOk(HumanReadableText displayTextKey, StatusResponse.ResponseCode code);
 
     /**
      * Creates a untagged NO status response.
@@ -93,7 +93,7 @@ public interface StatusResponseFactory {
      *            <code>ResponseCode</code>, not null
      * @return <code>StatusResponse</code>, not null
      */
-    public StatusResponse untaggedNo(HumanReadableText displayTextKey, StatusResponse.ResponseCode code);
+    StatusResponse untaggedNo(HumanReadableText displayTextKey, StatusResponse.ResponseCode code);
 
     /**
      * Creates a untagged BAD status response.
@@ -104,7 +104,7 @@ public interface StatusResponseFactory {
      *            <code>ResponseCode</code>, not null
      * @return <code>StatusResponse</code>, not null
      */
-    public StatusResponse untaggedBad(HumanReadableText displayTextKey, StatusResponse.ResponseCode code);
+    StatusResponse untaggedBad(HumanReadableText displayTextKey, StatusResponse.ResponseCode code);
 
     /**
      * Creates a PREAUTH status response. These are always untagged.
@@ -115,7 +115,7 @@ public interface StatusResponseFactory {
      *            <code>ResponseCode</code>, not null
      * @return <code>StatusResponse</code>, not null
      */
-    public StatusResponse preauth(HumanReadableText displayTextKey, StatusResponse.ResponseCode code);
+    StatusResponse preauth(HumanReadableText displayTextKey, StatusResponse.ResponseCode code);
 
     /**
      * Creates a BYE status response. These are always untagged.
@@ -126,7 +126,7 @@ public interface StatusResponseFactory {
      *            <code>ResponseCode</code>, not null
      * @return <code>StatusResponse</code>, not null
      */
-    public StatusResponse bye(HumanReadableText displayTextKey, StatusResponse.ResponseCode code);
+    StatusResponse bye(HumanReadableText displayTextKey, StatusResponse.ResponseCode code);
 
     /**
      * Creates a tagged OK status response.
@@ -139,7 +139,7 @@ public interface StatusResponseFactory {
      *            key to the human readable code to be displayed
      * @return <code>StatusResponse</code>, not null
      */
-    public StatusResponse taggedOk(String tag, ImapCommand command, HumanReadableText displayTextKey);
+    StatusResponse taggedOk(String tag, ImapCommand command, HumanReadableText displayTextKey);
 
     /**
      * Creates a tagged NO status response.
@@ -152,7 +152,7 @@ public interface StatusResponseFactory {
      *            key to the human readable code to be displayed
      * @return <code>StatusResponse</code>, not null
      */
-    public StatusResponse taggedNo(String tag, ImapCommand command, HumanReadableText displayTextKey);
+    StatusResponse taggedNo(String tag, ImapCommand command, HumanReadableText displayTextKey);
 
     /**
      * Creates a tagged BAD status response.
@@ -165,7 +165,7 @@ public interface StatusResponseFactory {
      *            key to the human readable code to be displayed
      * @return <code>StatusResponse</code>, not null
      */
-    public StatusResponse taggedBad(String tag, ImapCommand command, HumanReadableText displayTextKey);
+    StatusResponse taggedBad(String tag, ImapCommand command, HumanReadableText displayTextKey);
 
     /**
      * Creates a untagged OK status response.
@@ -174,7 +174,7 @@ public interface StatusResponseFactory {
      *            key to the human readable code to be displayed
      * @return <code>StatusResponse</code>, not null
      */
-    public StatusResponse untaggedOk(HumanReadableText displayTextKey);
+    StatusResponse untaggedOk(HumanReadableText displayTextKey);
 
     /**
      * Creates a untagged NO status response.
@@ -183,7 +183,7 @@ public interface StatusResponseFactory {
      *            key to the human readable code to be displayed
      * @return <code>StatusResponse</code>, not null
      */
-    public StatusResponse untaggedNo(HumanReadableText displayTextKey);
+    StatusResponse untaggedNo(HumanReadableText displayTextKey);
 
     /**
      * Creates a untagged BAD status response.
@@ -192,7 +192,7 @@ public interface StatusResponseFactory {
      *            key to the human readable code to be displayed
      * @return <code>StatusResponse</code>, not null
      */
-    public StatusResponse untaggedBad(HumanReadableText displayTextKey);
+    StatusResponse untaggedBad(HumanReadableText displayTextKey);
 
     /**
      * Creates a PREAUTH status response. These are always untagged.
@@ -201,7 +201,7 @@ public interface StatusResponseFactory {
      *            key to the human readable code to be displayed
      * @return <code>StatusResponse</code>, not null
      */
-    public StatusResponse preauth(HumanReadableText displayTextKey);
+    StatusResponse preauth(HumanReadableText displayTextKey);
 
     /**
      * Creates a BYE status response. These are always untagged.
@@ -210,6 +210,6 @@ public interface StatusResponseFactory {
      *            key to the human readable code to be displayed
      * @return <code>StatusResponse</code>, not null
      */
-    public StatusResponse bye(HumanReadableText displayTextKey);
+    StatusResponse bye(HumanReadableText displayTextKey);
 
 }

Modified: james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/api/process/ImapLineHandler.java
URL: http://svn.apache.org/viewvc/james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/api/process/ImapLineHandler.java?rev=1726760&r1=1726759&r2=1726760&view=diff
==============================================================================
--- james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/api/process/ImapLineHandler.java (original)
+++ james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/api/process/ImapLineHandler.java Tue Jan 26 10:24:54 2016
@@ -21,5 +21,5 @@ package org.apache.james.imap.api.proces
 
 public interface ImapLineHandler {
 
-    public void onLine(ImapSession session, byte[] data);
+    void onLine(ImapSession session, byte[] data);
 }

Modified: james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/api/process/ImapProcessor.java
URL: http://svn.apache.org/viewvc/james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/api/process/ImapProcessor.java?rev=1726760&r1=1726759&r2=1726760&view=diff
==============================================================================
--- james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/api/process/ImapProcessor.java (original)
+++ james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/api/process/ImapProcessor.java Tue Jan 26 10:24:54 2016
@@ -42,17 +42,17 @@ public interface ImapProcessor {
      * @param responder <code>not null</code>, the responder use write response for message
      * @param session the imap session
      */
-    public void process(ImapMessage message, Responder responder, ImapSession session);
+    void process(ImapMessage message, Responder responder, ImapSession session);
 
     /**
      * Response message sink.
      */
-    public interface Responder {
+    interface Responder {
         /**
          * Writes the given response.
          * 
          * @param message <code>not null</code>
          */
-        public void respond(ImapResponseMessage message);
+        void respond(ImapResponseMessage message);
     }
 }

Modified: james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/api/process/ImapSession.java
URL: http://svn.apache.org/viewvc/james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/api/process/ImapSession.java?rev=1726760&r1=1726759&r2=1726760&view=diff
==============================================================================
--- james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/api/process/ImapSession.java (original)
+++ james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/api/process/ImapSession.java Tue Jan 26 10:24:54 2016
@@ -90,7 +90,7 @@ public interface ImapSession {
      *            name of the key, not null
      * @return <code>Object</code> value or null if this attribute has unvalued
      */
-    public Object getAttribute(String key);
+    Object getAttribute(String key);
 
     /**
      * Sets an attribute of this session by name. Implementations should ensure
@@ -102,7 +102,7 @@ public interface ImapSession {
      *            <code>Object</code> value or null to set this attribute as
      *            unvalued
      */
-    public void setAttribute(String key, Object value);
+    void setAttribute(String key, Object value);
 
     /**
      * Start TLS encryption of the session after the next response was written.
@@ -110,28 +110,28 @@ public interface ImapSession {
      * 
      * @return true if the encryption of the session was successfully
      */
-    public boolean startTLS();
+    boolean startTLS();
 
     /**
      * Return true if the session is bound to a TLS encrypted socket.
      * 
      * @return tlsActive
      */
-    public boolean isTLSActive();
+    boolean isTLSActive();
  
     /**
      * Support startTLS ?
      * 
      * @return true if startTLS is supported
      */
-    public boolean supportStartTLS();
+    boolean supportStartTLS();
 
     /**
      * Return true if compression is active
      * 
      * @return compActive
      */
-    public boolean isCompressionActive();
+    boolean isCompressionActive();
 
     /**
      * Return true if compression is supported. This is related to COMPRESS extension.
@@ -139,34 +139,34 @@ public interface ImapSession {
      * 
      * @return compressSupport
      */
-    public boolean isCompressionSupported();
+    boolean isCompressionSupported();
 
     /**
      * Start the compression
      * 
      * @return success
      */
-    public boolean startCompression();
+    boolean startCompression();
 
     /**
      * Push in a new {@link ImapLineHandler} which is called for the next line received
      * 
      * @param lineHandler
      */
-    public void pushLineHandler(ImapLineHandler lineHandler);
+    void pushLineHandler(ImapLineHandler lineHandler);
 
     /**
      * Pop the current {@link ImapLineHandler}
      * 
      */
-    public void popLineHandler();
+    void popLineHandler();
     
     /**
      * Return true if multiple namespaces are supported
      * 
      * @return multipleNamespaces
      */
-    public boolean supportMultipleNamespaces();
+    boolean supportMultipleNamespaces();
     
     /**
      * Return true if the login / authentication via plain username / password is
@@ -174,6 +174,6 @@ public interface ImapSession {
      * 
      * @return plainDisallowed
      */
-    public boolean isPlainAuthDisallowed();
+    boolean isPlainAuthDisallowed();
 
 }

Modified: james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/api/process/SelectedMailbox.java
URL: http://svn.apache.org/viewvc/james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/api/process/SelectedMailbox.java?rev=1726760&r1=1726759&r2=1726760&view=diff
==============================================================================
--- james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/api/process/SelectedMailbox.java (original)
+++ james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/api/process/SelectedMailbox.java Tue Jan 26 10:24:54 2016
@@ -30,12 +30,12 @@ import org.apache.james.mailbox.model.Ma
  */
 public interface SelectedMailbox {
 
-    public final static int NO_SUCH_MESSAGE = -1;
+    int NO_SUCH_MESSAGE = -1;
 
     /**
      * Deselect the Mailbox
      */
-    public abstract void deselect();
+    void deselect();
 
     /**
      * Return the msg index of the given uid or {@link #NO_SUCH_MESSAGE} if no
@@ -44,7 +44,7 @@ public interface SelectedMailbox {
      * @param uid
      * @return index
      */
-    public int msn(long uid);
+    int msn(long uid);
 
     /**
      * Return the uid of the message for the given index or
@@ -53,7 +53,7 @@ public interface SelectedMailbox {
      * @param index
      * @return uid
      */
-    public abstract long uid(int index);
+    long uid(int index);
 
     /**
      * Add a recent uid
@@ -61,7 +61,7 @@ public interface SelectedMailbox {
      * @param uid
      * @return true if it was successfully
      */
-    public boolean addRecent(long uid);
+    boolean addRecent(long uid);
 
     /**
      * Remove a recent uid
@@ -69,35 +69,35 @@ public interface SelectedMailbox {
      * @param uid
      * @return true if it was successfully
      */
-    public boolean removeRecent(long uid);
+    boolean removeRecent(long uid);
 
     /**
      * Return a Collection of all recent uids
      * 
      * @return recentUids
      */
-    public Collection<Long> getRecent();
+    Collection<Long> getRecent();
 
     /**
      * Return the count of all recent uids
      * 
      * @return recentCount
      */
-    public int recentCount();
+    int recentCount();
 
     /**
      * Return the count of all existing uids
      * 
      * @return existsCount
      */
-    public long existsCount();
+    long existsCount();
 
     /**
      * Return the path of the selected Mailbox
      * 
      * @return path
      */
-    public MailboxPath getPath();
+    MailboxPath getPath();
 
     /**
      * Is the given uid recent ?
@@ -105,7 +105,7 @@ public interface SelectedMailbox {
      * @param uid
      * @return true if the given uid is recent
      */
-    public boolean isRecent(long uid);
+    boolean isRecent(long uid);
 
     /**
      * Is the mailbox deleted?
@@ -113,42 +113,42 @@ public interface SelectedMailbox {
      * @return true when the mailbox has been deleted by another session, false
      *         otherwise
      */
-    public boolean isDeletedByOtherSession();
+    boolean isDeletedByOtherSession();
 
     /**
      * Is the size of the mailbox changed ?
      * 
      * @return true if the mailbox size was changed
      */
-    public boolean isSizeChanged();
+    boolean isSizeChanged();
 
     /**
      * Was the recent uid removed ?
      * 
      * @return true if the recent uid for this mailbox was removed
      */
-    public boolean isRecentUidRemoved();
+    boolean isRecentUidRemoved();
 
     /**
      * 
      */
-    public void resetRecentUidRemoved();
+    void resetRecentUidRemoved();
 
 
     /**
      * Reset all events
      */
-    public void resetEvents();
+    void resetEvents();
 
     /**
      * Return a Collection which holds all uids which were expunged
      * 
      * @return expungedUids
      */
-    public Collection<Long> expungedUids();
+    Collection<Long> expungedUids();
 
     
-    public void resetExpungedUids();
+    void resetExpungedUids();
     
     /**
      * Removes the given UID.
@@ -159,7 +159,7 @@ public interface SelectedMailbox {
      *         {@link #NO_SUCH_MESSAGE} if no message with the given uid was
      *         found being expunged
      */
-    public int remove(Long uid);
+    int remove(Long uid);
 
     /**
      * Return a Collection which holds all uids reflecting the Messages which
@@ -167,7 +167,7 @@ public interface SelectedMailbox {
      * 
      * @return flagsUids
      */
-    public Collection<Long> flagUpdateUids();
+    Collection<Long> flagUpdateUids();
 
     /**
      * Return the uid of the first message in the mailbox or -1 if the mailbox
@@ -175,7 +175,7 @@ public interface SelectedMailbox {
      * 
      * @return firstUid
      */
-    public long getFirstUid();
+    long getFirstUid();
 
     /**
      * Return the uid of the last message in the mailbox or -1 if the mailbox is
@@ -183,18 +183,18 @@ public interface SelectedMailbox {
      * 
      * @return lastUid
      */
-    public long getLastUid();
+    long getLastUid();
     
     /**
      * Return all applicable Flags for the selected mailbox
      * 
      * @return flags
      */
-    public Flags getApplicableFlags();
+    Flags getApplicableFlags();
     
     
-    public boolean hasNewApplicableFlags();
+    boolean hasNewApplicableFlags();
     
-    public void resetNewApplicableFlags();
+    void resetNewApplicableFlags();
 
 }
\ No newline at end of file

Modified: james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/decode/DelegatingImapCommandParser.java
URL: http://svn.apache.org/viewvc/james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/decode/DelegatingImapCommandParser.java?rev=1726760&r1=1726759&r2=1726760&view=diff
==============================================================================
--- james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/decode/DelegatingImapCommandParser.java (original)
+++ james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/decode/DelegatingImapCommandParser.java Tue Jan 26 10:24:54 2016
@@ -20,8 +20,8 @@ package org.apache.james.imap.decode;
 
 public interface DelegatingImapCommandParser {
 
-    public abstract ImapCommandParserFactory getParserFactory();
+    ImapCommandParserFactory getParserFactory();
 
-    public abstract void setParserFactory(ImapCommandParserFactory imapCommandFactory);
+    void setParserFactory(ImapCommandParserFactory imapCommandFactory);
 
 }

Modified: james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/decode/ImapCommandParserFactory.java
URL: http://svn.apache.org/viewvc/james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/decode/ImapCommandParserFactory.java?rev=1726760&r1=1726759&r2=1726760&view=diff
==============================================================================
--- james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/decode/ImapCommandParserFactory.java (original)
+++ james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/decode/ImapCommandParserFactory.java Tue Jan 26 10:24:54 2016
@@ -21,6 +21,6 @@ package org.apache.james.imap.decode;
 
 public interface ImapCommandParserFactory {
 
-    public abstract ImapCommandParser getParser(String commandName);
+    ImapCommandParser getParser(String commandName);
 
 }
\ No newline at end of file

Modified: james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/decode/ImapDecoder.java
URL: http://svn.apache.org/viewvc/james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/decode/ImapDecoder.java?rev=1726760&r1=1726759&r2=1726760&view=diff
==============================================================================
--- james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/decode/ImapDecoder.java (original)
+++ james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/decode/ImapDecoder.java Tue Jan 26 10:24:54 2016
@@ -22,5 +22,5 @@ import org.apache.james.imap.api.ImapMes
 import org.apache.james.imap.api.process.ImapSession;
 
 public interface ImapDecoder {
-    public ImapMessage decode(final ImapRequestLineReader request, ImapSession session);
+    ImapMessage decode(final ImapRequestLineReader request, ImapSession session);
 }

Modified: james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/decode/ImapDecoderFactory.java
URL: http://svn.apache.org/viewvc/james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/decode/ImapDecoderFactory.java?rev=1726760&r1=1726759&r2=1726760&view=diff
==============================================================================
--- james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/decode/ImapDecoderFactory.java (original)
+++ james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/decode/ImapDecoderFactory.java Tue Jan 26 10:24:54 2016
@@ -21,5 +21,5 @@ package org.apache.james.imap.decode;
 
 public interface ImapDecoderFactory {
 
-    public ImapDecoder buildImapDecoder();
+    ImapDecoder buildImapDecoder();
 }

Modified: james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/decode/MessagingImapCommandParser.java
URL: http://svn.apache.org/viewvc/james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/decode/MessagingImapCommandParser.java?rev=1726760&r1=1726759&r2=1726760&view=diff
==============================================================================
--- james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/decode/MessagingImapCommandParser.java (original)
+++ james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/decode/MessagingImapCommandParser.java Tue Jan 26 10:24:54 2016
@@ -22,7 +22,7 @@ import org.apache.james.imap.api.message
 
 public interface MessagingImapCommandParser extends ImapCommandParser {
 
-    public abstract StatusResponseFactory getStatusResponseFactory();
+    StatusResponseFactory getStatusResponseFactory();
 
-    public abstract void setStatusResponseFactory(StatusResponseFactory statusResponseFactory);
+    void setStatusResponseFactory(StatusResponseFactory statusResponseFactory);
 }

Modified: james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/encode/ImapEncoderFactory.java
URL: http://svn.apache.org/viewvc/james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/encode/ImapEncoderFactory.java?rev=1726760&r1=1726759&r2=1726760&view=diff
==============================================================================
--- james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/encode/ImapEncoderFactory.java (original)
+++ james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/encode/ImapEncoderFactory.java Tue Jan 26 10:24:54 2016
@@ -21,5 +21,5 @@ package org.apache.james.imap.encode;
 
 public interface ImapEncoderFactory {
 
-    public ImapEncoder buildImapEncoder();
+    ImapEncoder buildImapEncoder();
 }

Modified: james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/encode/ImapResponseComposer.java
URL: http://svn.apache.org/viewvc/james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/encode/ImapResponseComposer.java?rev=1726760&r1=1726759&r2=1726760&view=diff
==============================================================================
--- james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/encode/ImapResponseComposer.java (original)
+++ james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/encode/ImapResponseComposer.java Tue Jan 26 10:24:54 2016
@@ -39,7 +39,7 @@ public interface ImapResponseComposer {
      * @param responseCode
      *            response code or null when there is no response code
      */
-    public ImapResponseComposer untaggedNoResponse(String displayMessage, String responseCode) throws IOException;
+    ImapResponseComposer untaggedNoResponse(String displayMessage, String responseCode) throws IOException;
 
     /**
      * Compose flags to output using standard format.
@@ -47,14 +47,14 @@ public interface ImapResponseComposer {
      * @param flags
      *            <code>Flags</code>, not null
      */
-    public ImapResponseComposer flags(Flags flags) throws IOException;
+    ImapResponseComposer flags(Flags flags) throws IOException;
 
     /**
      * Composes a <code>NIL</code>.
      * 
      * @throws IOException
      */
-    public ImapResponseComposer nil() throws IOException;
+    ImapResponseComposer nil() throws IOException;
 
     /**
      * Compose a response which contains the {@link ImapCommand} to which the
@@ -65,7 +65,7 @@ public interface ImapResponseComposer {
      * @return self
      * @throws IOException
      */
-    public ImapResponseComposer commandResponse(ImapCommand command, String message) throws IOException;
+    ImapResponseComposer commandResponse(ImapCommand command, String message) throws IOException;
 
     /**
      * Writes the message provided to the client, prepended with the request
@@ -74,7 +74,7 @@ public interface ImapResponseComposer {
      * @param message
      *            The message to write to the client.
      */
-    public ImapResponseComposer taggedResponse(String message, String tag) throws IOException;
+    ImapResponseComposer taggedResponse(String message, String tag) throws IOException;
 
     /**
      * Writes the message provided to the client, prepended with the untagged
@@ -83,7 +83,7 @@ public interface ImapResponseComposer {
      * @param message
      *            The message to write to the client.
      */
-    public ImapResponseComposer untaggedResponse(String message) throws IOException;
+    ImapResponseComposer untaggedResponse(String message) throws IOException;
 
     /**
      * Write a '*'
@@ -91,7 +91,7 @@ public interface ImapResponseComposer {
      * @return composer
      * @throws IOException
      */
-    public ImapResponseComposer untagged() throws IOException;
+    ImapResponseComposer untagged() throws IOException;
 
     /**
      * 
@@ -99,7 +99,7 @@ public interface ImapResponseComposer {
      * @return composer
      * @throws IOException
      */
-    public ImapResponseComposer commandName(final String name) throws IOException;
+    ImapResponseComposer commandName(final String name) throws IOException;
 
     /**
      * Write the message of type <code>String</code>
@@ -108,7 +108,7 @@ public interface ImapResponseComposer {
      * @return composer
      * @throws IOException
      */
-    public ImapResponseComposer message(final String message) throws IOException;
+    ImapResponseComposer message(final String message) throws IOException;
 
     /**
      * Write the message of type <code>Long</code>
@@ -117,7 +117,7 @@ public interface ImapResponseComposer {
      * @return composer
      * @throws IOException
      */
-    public ImapResponseComposer message(final long number) throws IOException;
+    ImapResponseComposer message(final long number) throws IOException;
 
     /**
      * First encodes the given {@code mailboxName} using
@@ -128,7 +128,7 @@ public interface ImapResponseComposer {
      * @return
      * @throws IOException
      */
-    public ImapResponseComposer mailbox(final String mailboxName) throws IOException;
+    ImapResponseComposer mailbox(final String mailboxName) throws IOException;
 
     /**
      * Write the given sequence-set
@@ -137,7 +137,7 @@ public interface ImapResponseComposer {
      * @return composer
      * @throws IOException
      */
-    public ImapResponseComposer sequenceSet(final IdRange[] ranges) throws IOException;
+    ImapResponseComposer sequenceSet(final IdRange[] ranges) throws IOException;
 
     /**
      * Write a CRLF and flush the composer which will write the content of it to
@@ -146,7 +146,7 @@ public interface ImapResponseComposer {
      * @return composer
      * @throws IOException
      */
-    public ImapResponseComposer end() throws IOException;
+    ImapResponseComposer end() throws IOException;
 
     /**
      * Write a tag
@@ -155,7 +155,7 @@ public interface ImapResponseComposer {
      * @return composer
      * @throws IOException
      */
-    public ImapResponseComposer tag(String tag) throws IOException;
+    ImapResponseComposer tag(String tag) throws IOException;
 
     /**
      * Write a quoted message
@@ -164,7 +164,7 @@ public interface ImapResponseComposer {
      * @return composer
      * @throws IOException
      */
-    public ImapResponseComposer quote(String message) throws IOException;
+    ImapResponseComposer quote(String message) throws IOException;
 
     /**
      * Compose a {@link Literal} and write it to the socket. Everything which
@@ -174,7 +174,7 @@ public interface ImapResponseComposer {
      * @return self
      * @throws IOException
      */
-    public ImapResponseComposer literal(Literal literal) throws IOException;
+    ImapResponseComposer literal(Literal literal) throws IOException;
 
     /**
      * Write a '('
@@ -182,7 +182,7 @@ public interface ImapResponseComposer {
      * @return composer
      * @throws IOException
      */
-    public ImapResponseComposer openParen() throws IOException;
+    ImapResponseComposer openParen() throws IOException;
 
     /**
      * Write a ')'
@@ -190,7 +190,7 @@ public interface ImapResponseComposer {
      * @return composer
      * @throws IOException
      */
-    public ImapResponseComposer closeParen() throws IOException;
+    ImapResponseComposer closeParen() throws IOException;
 
     /**
      * Appends the given message after conversion to upper case. The message may
@@ -202,7 +202,7 @@ public interface ImapResponseComposer {
      * @return self, not null
      * @throws IOException
      */
-    public ImapResponseComposer upperCaseAscii(final String message) throws IOException;
+    ImapResponseComposer upperCaseAscii(final String message) throws IOException;
 
     /**
      * Appends the given message after conversion to upper case. The message may
@@ -214,7 +214,7 @@ public interface ImapResponseComposer {
      * @return self, not null
      * @throws IOException
      */
-    public ImapResponseComposer quoteUpperCaseAscii(final String message) throws IOException;
+    ImapResponseComposer quoteUpperCaseAscii(final String message) throws IOException;
 
     /**
      * Tell the {@link ImapResponseComposer} to skip the next written space
@@ -222,7 +222,7 @@ public interface ImapResponseComposer {
      * @return composer
      * @throws IOException
      */
-    public ImapResponseComposer skipNextSpace() throws IOException;
+    ImapResponseComposer skipNextSpace() throws IOException;
 
     /**
      * Writes a continuation response.
@@ -230,7 +230,7 @@ public interface ImapResponseComposer {
      * @param message
      *            message for display, not null
      */
-    public ImapResponseComposer continuationResponse(String message) throws IOException;
+    ImapResponseComposer continuationResponse(String message) throws IOException;
 
     /**
      * Write a '}'
@@ -238,7 +238,7 @@ public interface ImapResponseComposer {
      * @return composer
      * @throws IOException
      */
-    public ImapResponseComposer closeSquareBracket() throws IOException;
+    ImapResponseComposer closeSquareBracket() throws IOException;
 
     /**
      * Write a '{'
@@ -246,6 +246,6 @@ public interface ImapResponseComposer {
      * @return composer
      * @throws IOException
      */
-    public ImapResponseComposer openSquareBracket() throws IOException;
+    ImapResponseComposer openSquareBracket() throws IOException;
 
 }

Modified: james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/message/response/FetchResponse.java
URL: http://svn.apache.org/viewvc/james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/message/response/FetchResponse.java?rev=1726760&r1=1726759&r2=1726760&view=diff
==============================================================================
--- james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/message/response/FetchResponse.java (original)
+++ james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/message/response/FetchResponse.java Tue Jan 26 10:24:54 2016
@@ -171,49 +171,49 @@ public final class FetchResponse impleme
          * 
          * @return media type, or null if default
          */
-        public String getMediaType();
+        String getMediaType();
 
         /**
          * Gets the MIME content subtype
          * 
          * @return subtype of null if default
          */
-        public String getSubType();
+        String getSubType();
 
         /**
          * Gets body type parameters.
          * 
          * @return parameters, or null
          */
-        public List<String> getParameters();
+        List<String> getParameters();
 
         /**
          * Gets <code>Content-ID</code>.
          * 
          * @return MIME content ID, possibly null
          */
-        public String getId();
+        String getId();
 
         /**
          * Gets <code>Content-Description</code>.
          * 
          * @return MIME <code>Content-Description</code>, possibly null
          */
-        public String getDescription();
+        String getDescription();
 
         /**
          * Gets content transfer encoding.
          * 
          * @return MIME <code>Content-Transfer-Encoding</code>, possibly null
          */
-        public String getEncoding();
+        String getEncoding();
 
         /**
          * Gets the size of message body the in octets.
          * 
          * @return number of octets in the message.
          */
-        public long getOctets();
+        long getOctets();
 
         /**
          * Gets the number of lines fo transfer encoding for a <code>TEXT</code>
@@ -221,14 +221,14 @@ public final class FetchResponse impleme
          * 
          * @return number of lines when <code>TEXT</code>, -1 otherwise
          */
-        public long getLines();
+        long getLines();
 
         /**
          * Gets <code>Content-MD5</code>.
          * 
          * @return Content-MD5 or null if <code>BODY</code> FETCH or not present
          */
-        public String getMD5();
+        String getMD5();
 
         /**
          * Gets header field-value from <code>Content-Disposition</code>.
@@ -237,14 +237,14 @@ public final class FetchResponse impleme
          *         <code>String</code> or null if <code>BODY</code> FETCH or not
          *         present
          */
-        public Map<String, String> getDispositionParams();
+        Map<String, String> getDispositionParams();
 
         /**
          * Gets header field-value from <code>Content-Disposition</code>.
          * 
          * @return disposition or null if <code>BODY</code> FETCH or not present
          */
-        public String getDisposition();
+        String getDisposition();
 
         /**
          * Gets MIME <code>Content-Language</code>'s.
@@ -253,7 +253,7 @@ public final class FetchResponse impleme
          *         <code>String</code>'s possibly null or null when
          *         <code>BODY</code> FETCH
          */
-        public List<String> getLanguages();
+        List<String> getLanguages();
 
         /**
          * Gets <code>Content-Location</code>.
@@ -261,7 +261,7 @@ public final class FetchResponse impleme
          * @return Content-Location possibly null; or null when
          *         <code>BODY</code> FETCH
          */
-        public String getLocation();
+        String getLocation();
 
         /**
          * Iterates parts of a composite media type.
@@ -269,7 +269,7 @@ public final class FetchResponse impleme
          * @return <code>Structure</code> <code>Iterator</code> when composite
          *         type, null otherwise
          */
-        public Iterator<Structure> parts();
+        Iterator<Structure> parts();
 
         /**
          * Gets the envelope of an embedded mail.
@@ -277,7 +277,7 @@ public final class FetchResponse impleme
          * @return <code>Envelope</code> when <code>message/rfc822</code>
          *         otherwise null
          */
-        public Envelope getEnvelope();
+        Envelope getEnvelope();
 
         /**
          * Gets the envelope of an embedded mail.
@@ -285,7 +285,7 @@ public final class FetchResponse impleme
          * @return <code>Structure</code> when when <code>message/rfc822</code>
          *         otherwise null
          */
-        public Structure getBody();
+        Structure getBody();
     }
 
     /**
@@ -299,7 +299,7 @@ public final class FetchResponse impleme
          * 
          * @return name, not null
          */
-        public String getName();
+        String getName();
 
     }
 
@@ -314,7 +314,7 @@ public final class FetchResponse impleme
          * 
          * @return envelope Date or null if this attribute is <code>NIL</code>
          */
-        public String getDate();
+        String getDate();
 
         /**
          * Gets the envelope <code>subject</code>. This is the value of the
@@ -322,71 +322,71 @@ public final class FetchResponse impleme
          * 
          * @return subject, or null if this attribute is <code>NIL</code>
          */
-        public String getSubject();
+        String getSubject();
 
         /**
          * Gets the envelope <code>from</code> addresses.
          * 
          * @return from addresses, not null
          */
-        public Address[] getFrom();
+        Address[] getFrom();
 
         /**
          * Gets the envelope <code>sender</code> addresses.
          * 
          * @return <code>sender</code> addresses, not null
          */
-        public Address[] getSender();
+        Address[] getSender();
 
         /**
          * Gets the envelope <code>reply-to</code> addresses.
          * 
          * @return <code>reply-to</code>, not null
          */
-        public Address[] getReplyTo();
+        Address[] getReplyTo();
 
         /**
          * Gets the envelope <code>to</code> addresses.
          * 
          * @return <code>to</code>, or null if <code>NIL</code>
          */
-        public Address[] getTo();
+        Address[] getTo();
 
         /**
          * Gets the envelope <code>cc</code> addresses.
          * 
          * @return <code>cc</code>, or null if <code>NIL</code>
          */
-        public Address[] getCc();
+        Address[] getCc();
 
         /**
          * Gets the envelope <code>bcc</code> addresses.
          * 
          * @return <code>bcc</code>, or null if <code>NIL</code>
          */
-        public Address[] getBcc();
+        Address[] getBcc();
 
         /**
          * Gets the envelope <code>in-reply-to</code>.
          * 
          * @return <code>in-reply-to</code> or null if <code>NIL</code>
          */
-        public String getInReplyTo();
+        String getInReplyTo();
 
         /**
          * Gets the envelope <code>message
          * 
          * @return the message id
          */
-        public String getMessageId();
+        String getMessageId();
 
         /**
          * Values an envelope address.
          */
-        public interface Address {
+        interface Address {
 
             /** Empty array */
-            public static final Address[] EMPTY = {};
+            Address[] EMPTY = {};
 
             /**
              * Gets the personal name.
@@ -394,7 +394,7 @@ public final class FetchResponse impleme
              * @return personal name, or null if the personal name is
              *         <code>NIL</code>
              */
-            public String getPersonalName();
+            String getPersonalName();
 
             /**
              * Gets the SMTP source route.
@@ -402,7 +402,7 @@ public final class FetchResponse impleme
              * @return SMTP at-domain-list, or null if the list if
              *         <code>NIL</code>
              */
-            public String getAtDomainList();
+            String getAtDomainList();
 
             /**
              * Gets the mailbox name.
@@ -410,7 +410,7 @@ public final class FetchResponse impleme
              * @return the mailbox name or the group name when
              *         {@link #getHostName()} is null
              */
-            public String getMailboxName();
+            String getMailboxName();
 
             /**
              * Gets the host name.
@@ -418,7 +418,7 @@ public final class FetchResponse impleme
              * @return the host name, or null when this address marks the start
              *         or end of a group
              */
-            public String getHostName();
+            String getHostName();
         }
     }
 }

Modified: james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/message/response/Literal.java
URL: http://svn.apache.org/viewvc/james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/message/response/Literal.java?rev=1726760&r1=1726759&r2=1726760&view=diff
==============================================================================
--- james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/message/response/Literal.java (original)
+++ james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/message/response/Literal.java Tue Jan 26 10:24:54 2016
@@ -30,7 +30,7 @@ public interface Literal {
      *         put onto the channel
      * @throws IOException 
      */
-    public long size() throws IOException;
+    long size() throws IOException;
 
 
     /**
@@ -39,5 +39,5 @@ public interface Literal {
      * @return elementIn
      * @throws IOException
      */
-    public InputStream getInputStream() throws IOException;
+    InputStream getInputStream() throws IOException;
 }

Modified: james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/processor/CapabilityImplementingProcessor.java
URL: http://svn.apache.org/viewvc/james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/processor/CapabilityImplementingProcessor.java?rev=1726760&r1=1726759&r2=1726760&view=diff
==============================================================================
--- james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/processor/CapabilityImplementingProcessor.java (original)
+++ james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/processor/CapabilityImplementingProcessor.java Tue Jan 26 10:24:54 2016
@@ -35,5 +35,5 @@ public interface CapabilityImplementingP
      * @param session
      * @return list not null
      */
-    public List<String> getImplementedCapabilities(ImapSession session);
+    List<String> getImplementedCapabilities(ImapSession session);
 }

Modified: james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/processor/PermitEnableCapabilityProcessor.java
URL: http://svn.apache.org/viewvc/james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/processor/PermitEnableCapabilityProcessor.java?rev=1726760&r1=1726759&r2=1726760&view=diff
==============================================================================
--- james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/processor/PermitEnableCapabilityProcessor.java (original)
+++ james/project/trunk/protocols/imap/src/main/java/org/apache/james/imap/processor/PermitEnableCapabilityProcessor.java Tue Jan 26 10:24:54 2016
@@ -36,7 +36,7 @@ public interface PermitEnableCapabilityP
      * @param session
      * @return permitCaps
      */
-    public List<String> getPermitEnableCapabilities(ImapSession session);
+    List<String> getPermitEnableCapabilities(ImapSession session);
     
     /**
      * Callback which is used when a ENABLED command was used to enable on of the CAPABILITIES which is managed by this implementation
@@ -47,14 +47,14 @@ public interface PermitEnableCapabilityP
      * @param capability
      * @throws EnableException
      */
-    public void enable(ImapMessage message, Responder responder, ImapSession session, String capability) throws EnableException;
+    void enable(ImapMessage message, Responder responder, ImapSession session, String capability) throws EnableException;
 
     /**
      * Exception which should get thrown if for whatever reason its not possible to enable a capability
      * 
      *
      */
-    public final static class EnableException extends Exception {
+    final class EnableException extends Exception {
         /**
          * 
          */

Modified: james/project/trunk/protocols/imap/src/main/java/org/apache/james/protocols/imap/IMAPSession.java
URL: http://svn.apache.org/viewvc/james/project/trunk/protocols/imap/src/main/java/org/apache/james/protocols/imap/IMAPSession.java?rev=1726760&r1=1726759&r2=1726760&view=diff
==============================================================================
--- james/project/trunk/protocols/imap/src/main/java/org/apache/james/protocols/imap/IMAPSession.java (original)
+++ james/project/trunk/protocols/imap/src/main/java/org/apache/james/protocols/imap/IMAPSession.java Tue Jan 26 10:24:54 2016
@@ -82,7 +82,7 @@ public interface IMAPSession extends Pro
      * 
      * @return compActive
      */
-    public boolean isCompressionActive();
+    boolean isCompressionActive();
 
     /**
      * Return true if compression is supported. This is related to COMPRESS extension.
@@ -90,21 +90,21 @@ public interface IMAPSession extends Pro
      * 
      * @return compressSupport
      */
-    public boolean isCompressionSupported();
+    boolean isCompressionSupported();
 
     /**
      * Start the compression
      * 
      * @return success
      */
-    public boolean startCompression();
+    boolean startCompression();
 
     /**
      * Return true if multiple namespaces are supported
      * 
      * @return multipleNamespaces
      */
-    public boolean supportMultipleNamespaces();
+    boolean supportMultipleNamespaces();
     
     /**
      * Return true if the login / authentication via plain username / password is
@@ -112,5 +112,5 @@ public interface IMAPSession extends Pro
      * 
      * @return plainDisallowed
      */
-    public boolean isPlainAuthDisallowed();
+    boolean isPlainAuthDisallowed();
 }

Modified: james/project/trunk/protocols/lmtp/src/main/java/org/apache/james/protocols/lmtp/hook/DeliverToRecipientHook.java
URL: http://svn.apache.org/viewvc/james/project/trunk/protocols/lmtp/src/main/java/org/apache/james/protocols/lmtp/hook/DeliverToRecipientHook.java?rev=1726760&r1=1726759&r2=1726760&view=diff
==============================================================================
--- james/project/trunk/protocols/lmtp/src/main/java/org/apache/james/protocols/lmtp/hook/DeliverToRecipientHook.java (original)
+++ james/project/trunk/protocols/lmtp/src/main/java/org/apache/james/protocols/lmtp/hook/DeliverToRecipientHook.java Tue Jan 26 10:24:54 2016
@@ -40,6 +40,6 @@ public interface DeliverToRecipientHook
      * @param envelope
      * @return response
      */
-    public HookResult deliver(SMTPSession session, MailAddress recipient, MailEnvelope envelope);
+    HookResult deliver(SMTPSession session, MailAddress recipient, MailEnvelope envelope);
     
 }

Modified: james/project/trunk/protocols/netty/src/main/java/org/apache/james/protocols/netty/HandlerConstants.java
URL: http://svn.apache.org/viewvc/james/project/trunk/protocols/netty/src/main/java/org/apache/james/protocols/netty/HandlerConstants.java?rev=1726760&r1=1726759&r2=1726760&view=diff
==============================================================================
--- james/project/trunk/protocols/netty/src/main/java/org/apache/james/protocols/netty/HandlerConstants.java (original)
+++ james/project/trunk/protocols/netty/src/main/java/org/apache/james/protocols/netty/HandlerConstants.java Tue Jan 26 10:24:54 2016
@@ -29,22 +29,22 @@ import org.jboss.netty.channel.ChannelPi
  */
 public interface HandlerConstants {
 
-    public static final String SSL_HANDLER = "sslHandler";
+    String SSL_HANDLER = "sslHandler";
 
-    public static final String GROUP_HANDLER = "groupHandler";
+    String GROUP_HANDLER = "groupHandler";
 
-    public static final String CONNECTION_LIMIT_HANDLER = " connectionLimit";
+    String CONNECTION_LIMIT_HANDLER = " connectionLimit";
 
-    public static final String CONNECTION_PER_IP_LIMIT_HANDLER = "connectionPerIpLimit";
+    String CONNECTION_PER_IP_LIMIT_HANDLER = "connectionPerIpLimit";
 
-    public static final String FRAMER = "framer";
+    String FRAMER = "framer";
 
-    public static final String EXECUTION_HANDLER = "executionHandler";
+    String EXECUTION_HANDLER = "executionHandler";
 
-    public static final String TIMEOUT_HANDLER = "timeoutHandler";
+    String TIMEOUT_HANDLER = "timeoutHandler";
 
-    public static final String CORE_HANDLER = "coreHandler";
+    String CORE_HANDLER = "coreHandler";
 
-    public static final String CHUNK_HANDLER = "chunkHandler";
+    String CHUNK_HANDLER = "chunkHandler";
 
 }

Modified: james/project/trunk/protocols/pop3/src/main/java/org/apache/james/protocols/pop3/POP3Session.java
URL: http://svn.apache.org/viewvc/james/project/trunk/protocols/pop3/src/main/java/org/apache/james/protocols/pop3/POP3Session.java?rev=1726760&r1=1726759&r2=1726760&view=diff
==============================================================================
--- james/project/trunk/protocols/pop3/src/main/java/org/apache/james/protocols/pop3/POP3Session.java (original)
+++ james/project/trunk/protocols/pop3/src/main/java/org/apache/james/protocols/pop3/POP3Session.java Tue Jan 26 10:24:54 2016
@@ -28,20 +28,20 @@ import org.apache.james.protocols.pop3.m
 
 public interface POP3Session extends ProtocolSession {
 
-    final static String UID_LIST = "UID_LIST";
-    final static String DELETED_UID_LIST = "DELETED_UID_LIST";
-    final static String APOP_TIMESTAMP = "APOP_TIMESTAMP";
+    String UID_LIST = "UID_LIST";
+    String DELETED_UID_LIST = "DELETED_UID_LIST";
+    String APOP_TIMESTAMP = "APOP_TIMESTAMP";
 
     // Authentication states for the POP3 interaction
     /** Waiting for user id */
-    final static int AUTHENTICATION_READY = 0;
+    int AUTHENTICATION_READY = 0;
     /** User id provided, waiting for password */
-    final static int AUTHENTICATION_USERSET = 1;
+    int AUTHENTICATION_USERSET = 1;
     /**
      * A valid user id/password combination has been provided. In this state the
      * client can access the mailbox of the specified user.
      */
-    final static int TRANSACTION = 2;
+    int TRANSACTION = 2;
 
     /**
      * Returns the current handler state

Modified: james/project/trunk/protocols/smtp/src/main/java/org/apache/james/protocols/smtp/SMTPSession.java
URL: http://svn.apache.org/viewvc/james/project/trunk/protocols/smtp/src/main/java/org/apache/james/protocols/smtp/SMTPSession.java?rev=1726760&r1=1726759&r2=1726760&view=diff
==============================================================================
--- james/project/trunk/protocols/smtp/src/main/java/org/apache/james/protocols/smtp/SMTPSession.java (original)
+++ james/project/trunk/protocols/smtp/src/main/java/org/apache/james/protocols/smtp/SMTPSession.java Tue Jan 26 10:24:54 2016
@@ -30,12 +30,12 @@ public interface SMTPSession extends Pro
 
     // Keys used to store/lookup data in the internal state hash map
     /** Sender's email address */
-    final static String SENDER = "SENDER_ADDRESS";
+    String SENDER = "SENDER_ADDRESS";
     /** The message recipients */
-    final static String RCPT_LIST = "RCPT_LIST";  
+    String RCPT_LIST = "RCPT_LIST";
     /** HELO or EHLO */
-    final static String CURRENT_HELO_MODE = "CURRENT_HELO_MODE";
-    final static String CURRENT_HELO_NAME = "CURRENT_HELO_NAME";
+    String CURRENT_HELO_MODE = "CURRENT_HELO_MODE";
+    String CURRENT_HELO_NAME = "CURRENT_HELO_NAME";
 
     /**
      * Returns the service wide configuration

Modified: james/project/trunk/server/container/cli/src/main/java/org/apache/james/cli/probe/ServerProbe.java
URL: http://svn.apache.org/viewvc/james/project/trunk/server/container/cli/src/main/java/org/apache/james/cli/probe/ServerProbe.java?rev=1726760&r1=1726759&r2=1726760&view=diff
==============================================================================
--- james/project/trunk/server/container/cli/src/main/java/org/apache/james/cli/probe/ServerProbe.java (original)
+++ james/project/trunk/server/container/cli/src/main/java/org/apache/james/cli/probe/ServerProbe.java Tue Jan 26 10:24:54 2016
@@ -22,8 +22,8 @@ import java.io.Closeable;
 import java.util.Collection;
 import java.util.Map;
 
-import org.apache.james.rrt.lib.Mappings;
-
+import org.apache.james.rrt.lib.Mappings;
+
 import org.apache.james.adapter.mailbox.SerializableQuota;
 import org.apache.james.mailbox.exception.MailboxException;
 
@@ -37,7 +37,7 @@ public interface ServerProbe extends Clo
      *            The password of the user being added.
      * @throws Exception
      */
-    public void addUser(String userName, String password) throws Exception;
+    void addUser(String userName, String password) throws Exception;
 
     /**
      * Delete a user from this mail server.
@@ -46,7 +46,7 @@ public interface ServerProbe extends Clo
      *            The name of the user being deleted.
      * @throws Exception
      */
-    public void removeUser(String username) throws Exception;
+    void removeUser(String username) throws Exception;
 
     /**
      * Get a List the names of all users.
@@ -54,7 +54,7 @@ public interface ServerProbe extends Clo
      * @return a List of all user names.
      * @throws Exception
      */
-    public String[] listUsers() throws Exception;
+    String[] listUsers() throws Exception;
 
     /**
      * Set a user's password.
@@ -65,7 +65,7 @@ public interface ServerProbe extends Clo
      *            The new password.
      * @throws Exception
      */
-    public void setPassword(String userName, String password) throws Exception;
+    void setPassword(String userName, String password) throws Exception;
 
     /**
      * Add domain to the service.
@@ -74,7 +74,7 @@ public interface ServerProbe extends Clo
      *            The domain to add.
      * @throws Exception
      */
-    public void addDomain(String domain) throws Exception;
+    void addDomain(String domain) throws Exception;
 
     /**
      * Return true if the domain exists in the service
@@ -83,7 +83,7 @@ public interface ServerProbe extends Clo
      *            The domain to remove.
      * @throws Exception
      */
-    public boolean containsDomain(String domain) throws Exception;
+    boolean containsDomain(String domain) throws Exception;
 
     /**
      * Remove domain from the service
@@ -92,7 +92,7 @@ public interface ServerProbe extends Clo
      *            The domain to remove.
      * @throws Exception
      */
-    public void removeDomain(String domain) throws Exception;
+    void removeDomain(String domain) throws Exception;
 
     /**
      * Get a list of domains for the service.
@@ -100,7 +100,7 @@ public interface ServerProbe extends Clo
      * @return domains an array of domains, or null if no domains exist.
      * @throws Exception
      */
-    public String[] listDomains() throws Exception;
+    String[] listDomains() throws Exception;
 
     /**
      * Get a Map which holds all mappings. The key is the user@domain and the
@@ -109,7 +109,7 @@ public interface ServerProbe extends Clo
      * @return a Map which holds all mappings.
      * @throws Exception
      */
-	public Map<String, Mappings> listMappings() throws Exception;
+    Map<String, Mappings> listMappings() throws Exception;
 
     /**
      * Add address mapping.
@@ -122,7 +122,7 @@ public interface ServerProbe extends Clo
      *            The address.
      * @throws Exception
      */
-    public void addAddressMapping(String user, String domain, String toAddress) throws Exception;
+    void addAddressMapping(String user, String domain, String toAddress) throws Exception;
 
     /**
      * Remove address mapping.
@@ -135,7 +135,7 @@ public interface ServerProbe extends Clo
      *            The address.
      * @throws Exception
      */
-    public void removeAddressMapping(String user, String domain, String fromAddress) throws Exception;
+    void removeAddressMapping(String user, String domain, String fromAddress) throws Exception;
 
     /**
      * Return the explicit mapping stored for the given user and domain. Return
@@ -149,7 +149,7 @@ public interface ServerProbe extends Clo
      *         found.
      * @throws Exception
      */
-	public Mappings listUserDomainMappings(String user, String domain) throws Exception;
+    Mappings listUserDomainMappings(String user, String domain) throws Exception;
 
     /**
      * Remove regex mapping.
@@ -162,7 +162,7 @@ public interface ServerProbe extends Clo
      *            The regex.
      * @throws Exception
      */
-    public void addRegexMapping(String user, String domain, String regex) throws Exception;
+    void addRegexMapping(String user, String domain, String regex) throws Exception;
 
     /**
      * Remove regex mapping.
@@ -175,7 +175,7 @@ public interface ServerProbe extends Clo
      *            The regex.
      * @throws Exception
      */
-    public void removeRegexMapping(String user, String domain, String regex) throws Exception;
+    void removeRegexMapping(String user, String domain, String regex) throws Exception;
 
     /**
      * Copy Mailbox.

Modified: james/project/trunk/server/container/filesystem-api/src/main/java/org/apache/james/filesystem/api/FileSystem.java
URL: http://svn.apache.org/viewvc/james/project/trunk/server/container/filesystem-api/src/main/java/org/apache/james/filesystem/api/FileSystem.java?rev=1726760&r1=1726759&r2=1726760&view=diff
==============================================================================
--- james/project/trunk/server/container/filesystem-api/src/main/java/org/apache/james/filesystem/api/FileSystem.java (original)
+++ james/project/trunk/server/container/filesystem-api/src/main/java/org/apache/james/filesystem/api/FileSystem.java Tue Jan 26 10:24:54 2016
@@ -35,27 +35,27 @@ public interface FileSystem {
     /**
      * Prefix for loading of a filesystem based on the current directory
      */
-    static final String FILE_PROTOCOL = "file://";
+    String FILE_PROTOCOL = "file://";
 
     /**
      * Prefix for loading of a filesystem using the absolute path
      */
-    static final String FILE_PROTOCOL_ABSOLUTE = "file:///";
+    String FILE_PROTOCOL_ABSOLUTE = "file:///";
 
     /**
      * Prefix for loading of the config directory
      */
-    static final String FILE_PROTOCOL_AND_CONF = "file://conf/";
+    String FILE_PROTOCOL_AND_CONF = "file://conf/";
 
     /**
      * Prefix for loading of the var directory
      */
-    static final String FILE_PROTOCOL_AND_VAR = "file://var/";
+    String FILE_PROTOCOL_AND_VAR = "file://var/";
 
     /**
      * Prefix for loading of the classpath
      */
-    static final String CLASSPATH_PROTOCOL = "classpath:";
+    String CLASSPATH_PROTOCOL = "classpath:";
 
     /**
      * to retrieve a resource. this is typically a file resource, but depending

Modified: james/project/trunk/server/container/util/src/main/java/org/apache/james/util/retry/api/ExceptionRetryingProxy.java
URL: http://svn.apache.org/viewvc/james/project/trunk/server/container/util/src/main/java/org/apache/james/util/retry/api/ExceptionRetryingProxy.java?rev=1726760&r1=1726759&r2=1726760&view=diff
==============================================================================
--- james/project/trunk/server/container/util/src/main/java/org/apache/james/util/retry/api/ExceptionRetryingProxy.java (original)
+++ james/project/trunk/server/container/util/src/main/java/org/apache/james/util/retry/api/ExceptionRetryingProxy.java Tue Jan 26 10:24:54 2016
@@ -30,13 +30,13 @@ public interface ExceptionRetryingProxy
      * @return a new instance that the proxy delegates to
      * @throws Exception
      */
-    abstract public Object newDelegate() throws Exception;
+    Object newDelegate() throws Exception;
     
     /**
      * @return the current instance of the proxy delegate
      * @throws Exception
      */
-    abstract public Object getDelegate();
+    Object getDelegate();
     
     /**
      * Resets the delegate instance to a state from which it can perform the 
@@ -44,6 +44,6 @@ public interface ExceptionRetryingProxy
      *
      * @throws Exception
      */
-    abstract public void resetDelegate() throws Exception;
+    void resetDelegate() throws Exception;
 
 }

Modified: james/project/trunk/server/container/util/src/main/java/org/apache/james/util/retry/api/RetryHandler.java
URL: http://svn.apache.org/viewvc/james/project/trunk/server/container/util/src/main/java/org/apache/james/util/retry/api/RetryHandler.java?rev=1726760&r1=1726759&r2=1726760&view=diff
==============================================================================
--- james/project/trunk/server/container/util/src/main/java/org/apache/james/util/retry/api/RetryHandler.java (original)
+++ james/project/trunk/server/container/util/src/main/java/org/apache/james/util/retry/api/RetryHandler.java Tue Jan 26 10:24:54 2016
@@ -30,7 +30,7 @@ public interface RetryHandler {
      * @return the result of invoking an operation
      * @throws Exception
      */
-    public abstract Object perform() throws Exception;
+    Object perform() throws Exception;
 
     /**
      * A hook invoked each time an operation fails if a retry is scheduled
@@ -40,13 +40,13 @@ public interface RetryHandler {
      * @param retryCount
      *      The number of times  
      */
-    public abstract void postFailure(Exception ex, int retryCount);
+    void postFailure(Exception ex, int retryCount);
 
     /**
      * Encapsulates desired behaviour
      * @return The result of performing the behaviour
      * @throws Exception
      */
-    abstract public Object operation() throws Exception;
+    Object operation() throws Exception;
 
 }
\ No newline at end of file

Modified: james/project/trunk/server/container/util/src/main/java/org/apache/james/util/retry/api/RetrySchedule.java
URL: http://svn.apache.org/viewvc/james/project/trunk/server/container/util/src/main/java/org/apache/james/util/retry/api/RetrySchedule.java?rev=1726760&r1=1726759&r2=1726760&view=diff
==============================================================================
--- james/project/trunk/server/container/util/src/main/java/org/apache/james/util/retry/api/RetrySchedule.java (original)
+++ james/project/trunk/server/container/util/src/main/java/org/apache/james/util/retry/api/RetrySchedule.java Tue Jan 26 10:24:54 2016
@@ -30,6 +30,6 @@ public interface RetrySchedule {
      * @param index
      * @return
      */
-    public long getInterval(int index);
+    long getInterval(int index);
 
 }

Modified: james/project/trunk/server/data/data-api/src/main/java/org/apache/james/domainlist/api/DomainListManagementMBean.java
URL: http://svn.apache.org/viewvc/james/project/trunk/server/data/data-api/src/main/java/org/apache/james/domainlist/api/DomainListManagementMBean.java?rev=1726760&r1=1726759&r2=1726760&view=diff
==============================================================================
--- james/project/trunk/server/data/data-api/src/main/java/org/apache/james/domainlist/api/DomainListManagementMBean.java (original)
+++ james/project/trunk/server/data/data-api/src/main/java/org/apache/james/domainlist/api/DomainListManagementMBean.java Tue Jan 26 10:24:54 2016
@@ -66,6 +66,6 @@ public interface DomainListManagementMBe
      * 
      * @return the defaultdomain
      */
-    public String getDefaultDomain() throws Exception;
+    String getDefaultDomain() throws Exception;
 
 }

Modified: james/project/trunk/server/data/data-api/src/main/java/org/apache/james/rrt/api/RecipientRewriteTable.java
URL: http://svn.apache.org/viewvc/james/project/trunk/server/data/data-api/src/main/java/org/apache/james/rrt/api/RecipientRewriteTable.java?rev=1726760&r1=1726759&r2=1726760&view=diff
==============================================================================
--- james/project/trunk/server/data/data-api/src/main/java/org/apache/james/rrt/api/RecipientRewriteTable.java (original)
+++ james/project/trunk/server/data/data-api/src/main/java/org/apache/james/rrt/api/RecipientRewriteTable.java Tue Jan 26 10:24:54 2016
@@ -30,22 +30,22 @@ public interface RecipientRewriteTable {
     /**
      * The prefix which is used for error mappings
      */
-    static final String ERROR_PREFIX = "error:";
+    String ERROR_PREFIX = "error:";
 
     /**
      * The prefix which is used for regex mappings
      */
-    static final String REGEX_PREFIX = "regex:";
+    String REGEX_PREFIX = "regex:";
 
     /**
      * The prefix which is used for alias domain mappings
      */
-    static final String ALIASDOMAIN_PREFIX = "domain:";
+    String ALIASDOMAIN_PREFIX = "domain:";
 
     /**
      * The wildcard used for alias domain mappings
      */
-    final static String WILDCARD = "*";
+    String WILDCARD = "*";
 
     /**
      * Return the mapped MailAddress for the given address. Return null if no

Modified: james/project/trunk/server/data/data-hbase/src/main/java/org/apache/james/domainlist/hbase/def/HDomainList.java
URL: http://svn.apache.org/viewvc/james/project/trunk/server/data/data-hbase/src/main/java/org/apache/james/domainlist/hbase/def/HDomainList.java?rev=1726760&r1=1726759&r2=1726760&view=diff
==============================================================================
--- james/project/trunk/server/data/data-hbase/src/main/java/org/apache/james/domainlist/hbase/def/HDomainList.java (original)
+++ james/project/trunk/server/data/data-hbase/src/main/java/org/apache/james/domainlist/hbase/def/HDomainList.java Tue Jan 26 10:24:54 2016
@@ -31,7 +31,7 @@ public interface HDomainList {
     byte[] TABLE_NAME = Bytes.toBytes("JAMES_DOMAINLIST");
     byte[] COLUMN_FAMILY_NAME = Bytes.toBytes("JAMES_DOMAINLIST");
     
-    public interface COLUMN {
+    interface COLUMN {
         byte [] DOMAIN = Bytes.toBytes("dom");
     }
 

Modified: james/project/trunk/server/data/data-hbase/src/main/java/org/apache/james/rrt/hbase/def/HRecipientRewriteTable.java
URL: http://svn.apache.org/viewvc/james/project/trunk/server/data/data-hbase/src/main/java/org/apache/james/rrt/hbase/def/HRecipientRewriteTable.java?rev=1726760&r1=1726759&r2=1726760&view=diff
==============================================================================
--- james/project/trunk/server/data/data-hbase/src/main/java/org/apache/james/rrt/hbase/def/HRecipientRewriteTable.java (original)
+++ james/project/trunk/server/data/data-hbase/src/main/java/org/apache/james/rrt/hbase/def/HRecipientRewriteTable.java Tue Jan 26 10:24:54 2016
@@ -31,7 +31,7 @@ public interface HRecipientRewriteTable
     byte[] TABLE_NAME = Bytes.toBytes("JAMES_RRT");
     byte[] COLUMN_FAMILY_NAME = Bytes.toBytes("JAMES_RRT");
 
-    public interface COLUMN {
+    interface COLUMN {
         byte [] MAPPING = Bytes.toBytes("map");
     }
 

Modified: james/project/trunk/server/data/data-hbase/src/main/java/org/apache/james/user/hbase/def/HUsersRepository.java
URL: http://svn.apache.org/viewvc/james/project/trunk/server/data/data-hbase/src/main/java/org/apache/james/user/hbase/def/HUsersRepository.java?rev=1726760&r1=1726759&r2=1726760&view=diff
==============================================================================
--- james/project/trunk/server/data/data-hbase/src/main/java/org/apache/james/user/hbase/def/HUsersRepository.java (original)
+++ james/project/trunk/server/data/data-hbase/src/main/java/org/apache/james/user/hbase/def/HUsersRepository.java Tue Jan 26 10:24:54 2016
@@ -31,7 +31,7 @@ public interface HUsersRepository {
     byte[] TABLE_NAME = Bytes.toBytes("JAMES_USERS");
     byte[] COLUMN_FAMILY_NAME = Bytes.toBytes("JAMES_USERS");
     
-    public interface COLUMN {
+    interface COLUMN {
         byte [] PWD = Bytes.toBytes("pwd");
     }
 




---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org