You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2015/02/17 07:00:23 UTC
Re: Review Request 30977: Added explicit acknowledgement integration
tests.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30977/
-----------------------------------------------------------
(Updated Feb. 17, 2015, 6 a.m.)
Review request for mesos and Vinod Kone.
Changes
-------
* Updates per the removal of the signature change on the API.
* Added additional tests to ensure acks are properly dropped.
Summary (updated)
-----------------
Added explicit acknowledgement integration tests.
Bugs: MESOS-2347
https://issues.apache.org/jira/browse/MESOS-2347
Repository: mesos
Description
-------
In addition to the test frameworks, this adds an integration test to exercise explicit acknowledgements.
Diffs (updated)
-----
src/tests/scheduler_tests.cpp 080ec7236246794de6c8cc7356a06331c5e48cd5
Diff: https://reviews.apache.org/r/30977/diff/
Testing
-------
make check with 100 repetitions
Thanks,
Ben Mahler
Re: Review Request 30977: Added explicit acknowledgement integration
tests.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30977/#review73211
-----------------------------------------------------------
Ship it!
nice tests.
src/tests/scheduler_tests.cpp
<https://reviews.apache.org/r/30977/#comment119451>
You should do a Clock::pause() and Clock::settle() here to ensure any ACK would've been sent.
- Vinod Kone
On Feb. 17, 2015, 6 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30977/
> -----------------------------------------------------------
>
> (Updated Feb. 17, 2015, 6 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-2347
> https://issues.apache.org/jira/browse/MESOS-2347
>
>
> Repository: mesos
>
>
> Description
> -------
>
> In addition to the test frameworks, this adds an integration test to exercise explicit acknowledgements.
>
>
> Diffs
> -----
>
> src/tests/scheduler_tests.cpp 080ec7236246794de6c8cc7356a06331c5e48cd5
>
> Diff: https://reviews.apache.org/r/30977/diff/
>
>
> Testing
> -------
>
> make check with 100 repetitions
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request 30977: Added explicit acknowledgement integration
tests.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30977/
-----------------------------------------------------------
(Updated Feb. 21, 2015, 10:26 p.m.)
Review request for mesos and Vinod Kone.
Changes
-------
* Updated `acknowledgeStatusUpdate` to take a `TaskStatus` to simplify the call for schedulers.
Bugs: MESOS-2347
https://issues.apache.org/jira/browse/MESOS-2347
Repository: mesos
Description
-------
In addition to the test frameworks, this adds an integration test to exercise explicit acknowledgements.
Diffs (updated)
-----
src/tests/scheduler_tests.cpp 080ec7236246794de6c8cc7356a06331c5e48cd5
Diff: https://reviews.apache.org/r/30977/diff/
Testing
-------
make check with 100 repetitions
Thanks,
Ben Mahler