[GitHub] [incubator-mxnet] josephevans commented on a change in pull request #19947: [wip][V1.8.x] Attemp to fix cd for v1.8.x

[GitBox <gi...@apache.org>]

josephevans commented on a change in pull request #19947:
URL: https://github.com/apache/incubator-mxnet/pull/19947#discussion_r582115137



##########
File path: cd/python/docker/Dockerfile
##########
@@ -23,11 +23,15 @@
 ARG BASE_IMAGE
 FROM ${BASE_IMAGE}
 
-ARG PYTHON_CMD=python3
-RUN apt-get update && \
-    apt-get install -y wget ${PYTHON_CMD}-dev gcc && \
-    wget https://bootstrap.pypa.io/get-pip.py && \
-    ${PYTHON_CMD} get-pip.py
+RUN apt-get update || true

Review comment:
       Could you combine all these RUN commands into one? Each RUN command causes a docker layer to be saved, so it's more efficient to do
   ```
   RUN apt-get update && \
       apt-get install -y software-properties-common && \
       add-apt-repository -y ppa:deadsnakes/ppa && \
       apt-get update && \
       apt-get install -y python3.7-dev python3.7-distutils virtualenv wget && \
       ln -sf /usr/bin/python3.7 /usr/local/bin/python3 && \
       wget -nv https://bootstrap.pypa.io/get-pip.py && \
       python3 get-pip.py
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org