[GitHub] [camel-k] Kyle-Cooley opened a new pull request #2527: Allow Probe Scheme to Be Customized

[GitBox <gi...@apache.org>]

Kyle-Cooley opened a new pull request #2527:
URL: https://github.com/apache/camel-k/pull/2527


   <!-- Description -->
   
   Addresses https://github.com/apache/camel-k/issues/2513. This change allows the scheme used for the liveness and readiness probes to be overridden to HTTPS when needed. The approach taken was minimalistic.
   
   Verified using this groovy script saved to /tmp/helloworld.groovy
   ```
   from('timer:tick?period=3000')
     .setBody().constant('Hello world from Camel K')
     .to('log:info')
   ```
   and an integration deployed with the following commands
   ```
   openssl req -x509 -newkey rsa:4096 -keyout /tmp/integration-key.pem -out /tmp/integration-cert.pem -days 365 -nodes
   
   kubectl create secret tls my-tls-secret --cert=/tmp/integration-cert.pem --key=/tmp/integration-key.pem
   
   kamel run \
     --property quarkus.http.ssl.certificate.file=/etc/camel/conf.d/_secrets/my-tls-secret/tls.crt \
     --property quarkus.http.ssl.certificate.key-file=/etc/camel/conf.d/_secrets/my-tls-secret/tls.key \
     --config secret:my-tls-secret \
     /tmp/helloworld.groovy \
     --trait container.port=8443 \
     --trait container.probes-enabled=true \
     --trait container.liveness-scheme=HTTPS \
     --trait container.readiness-scheme=HTTPS
   ```
   
   <!--
   Enter your extended release note in the below block. If the PR requires
   additional action from users switching to the new release, include the string
   "action required". If no release note is required, write "NONE". 
   
   You can (optionally) mark this PR with labels "kind/bug" or "kind/feature" to make sure
   the text is added to the right section of the release notes. 
   -->
   
   **Release Note**
   ```release-note
   Allow the scheme used for the liveness and readiness probes to be overridden
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-k] astefanutti merged pull request #2527: Allow Probe Scheme to Be Customized

[GitBox <gi...@apache.org>]

astefanutti merged pull request #2527:
URL: https://github.com/apache/camel-k/pull/2527


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-k] squakez commented on pull request #2527: Allow Probe Scheme to Be Customized

[GitBox <gi...@apache.org>]

squakez commented on pull request #2527:
URL: https://github.com/apache/camel-k/pull/2527#issuecomment-886466636


   @Kyle-Cooley do you think you can include that simple example under [trait/container example directory](https://github.com/apache/camel-k/tree/main/examples/traits) (it has to be created)?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-k] Kyle-Cooley commented on pull request #2527: Allow Probe Scheme to Be Customized

[GitBox <gi...@apache.org>]

Kyle-Cooley commented on pull request #2527:
URL: https://github.com/apache/camel-k/pull/2527#issuecomment-886799128


   I've made those changes. Let me know if there is anything else.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org