You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@groovy.apache.org by su...@apache.org on 2021/04/21 02:35:47 UTC
[groovy] branch master updated: Trivial refactoring: remove
redundant `addAll` method calls
This is an automated email from the ASF dual-hosted git repository.
sunlan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/groovy.git
The following commit(s) were added to refs/heads/master by this push:
new e45d05e Trivial refactoring: remove redundant `addAll` method calls
e45d05e is described below
commit e45d05e3c4c8c021b9b629749502a9133ce050a2
Author: Daniel Sun <su...@apache.org>
AuthorDate: Wed Apr 21 10:35:31 2021 +0800
Trivial refactoring: remove redundant `addAll` method calls
---
.../groovy/contracts/ast/visitor/AnnotationProcessorVisitor.java | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/subprojects/groovy-contracts/src/main/java/org/apache/groovy/contracts/ast/visitor/AnnotationProcessorVisitor.java b/subprojects/groovy-contracts/src/main/java/org/apache/groovy/contracts/ast/visitor/AnnotationProcessorVisitor.java
index eccdae9..7364de9 100644
--- a/subprojects/groovy-contracts/src/main/java/org/apache/groovy/contracts/ast/visitor/AnnotationProcessorVisitor.java
+++ b/subprojects/groovy-contracts/src/main/java/org/apache/groovy/contracts/ast/visitor/AnnotationProcessorVisitor.java
@@ -36,7 +36,6 @@ import org.codehaus.groovy.ast.expr.BooleanExpression;
import org.codehaus.groovy.ast.expr.ClassExpression;
import org.codehaus.groovy.ast.expr.MethodCallExpression;
import org.codehaus.groovy.ast.expr.VariableExpression;
-import org.codehaus.groovy.ast.stmt.BlockStatement;
import org.codehaus.groovy.control.SourceUnit;
import org.codehaus.groovy.control.io.ReaderSource;
@@ -95,8 +94,7 @@ public class AnnotationProcessorVisitor extends BaseVisitor {
if (!Modifier.isAbstract(superClass.getModifiers())) return;
for (ClassNode interfaceClassNode : superClass.getInterfaces()) {
- List<MethodNode> methodNodes = new ArrayList<MethodNode>();
- methodNodes.addAll(interfaceClassNode.getMethods());
+ List<MethodNode> methodNodes = new ArrayList<MethodNode>(interfaceClassNode.getMethods());
for (MethodNode interfaceMethodNode : methodNodes) {
final List<AnnotationNode> annotationNodes = AnnotationUtils.hasMetaAnnotations(interfaceMethodNode, ContractElement.class.getName());
@@ -118,8 +116,7 @@ public class AnnotationProcessorVisitor extends BaseVisitor {
private void visitInterfaces(final ClassNode classNode, final ClassNode[] interfaces) {
for (ClassNode interfaceClassNode : interfaces) {
- List<MethodNode> methodNodes = new ArrayList<MethodNode>();
- methodNodes.addAll(interfaceClassNode.getMethods());
+ List<MethodNode> methodNodes = new ArrayList<MethodNode>(interfaceClassNode.getMethods());
// @ContractElement annotations are by now only supported on method interfaces
for (MethodNode interfaceMethodNode : methodNodes) {