You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2019/10/08 16:31:57 UTC
[GitHub] [hadoop] bharatviswa504 commented on a change in pull request
#1612: HDDS-2260. Avoid evaluation of LOG.trace and LOG.debug statement in
the read/write path (HDDS).
bharatviswa504 commented on a change in pull request #1612: HDDS-2260. Avoid evaluation of LOG.trace and LOG.debug statement in the read/write path (HDDS).
URL: https://github.com/apache/hadoop/pull/1612#discussion_r332612988
##########
File path: hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/XceiverClientGrpc.java
##########
@@ -283,7 +285,9 @@ private XceiverClientReply sendCommandWithRetry(
}
for (DatanodeDetails dn : datanodeList) {
try {
- LOG.debug("Executing command " + request + " on datanode " + dn);
+ if (LOG.isDebugEnabled()) {
+ LOG.debug("Executing command " + request + " on datanode " + dn);
Review comment:
Instead of +, can we use {}
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org