You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/06/30 23:46:06 UTC
[GitHub] [arrow-rs] viirya opened a new pull request, #1984: MINOR: Fix clippy error after updating rust toolchain
viirya opened a new pull request, #1984:
URL: https://github.com/apache/arrow-rs/pull/1984
# Which issue does this PR close?
<!---
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
There are a few clippy errors on CI. I can reproduce it once do `rustup update` locally.
# Rationale for this change
<!---
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
<!---
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!---
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please add the `breaking change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] viirya merged pull request #1984: MINOR: Fix clippy error after updating rust toolchain
Posted by GitBox <gi...@apache.org>.
viirya merged PR #1984:
URL: https://github.com/apache/arrow-rs/pull/1984
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Fix clippy error after updating rust toolchain [arrow-rs]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #1984:
URL: https://github.com/apache/arrow-rs/pull/1984#issuecomment-4187518689
## [Codecov](https://app.codecov.io/gh/apache/arrow-rs/pull/1984?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 83.57%. Comparing base ([`a89c1cf`](https://app.codecov.io/gh/apache/arrow-rs/commit/a89c1cf58161473b162fe1251d1da4cd09b25e36?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`71afabd`](https://app.codecov.io/gh/apache/arrow-rs/commit/71afabde18f09de7a8e1f52792d2a40285ba6b3a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #1984 +/- ##
=======================================
Coverage 83.56% 83.57%
=======================================
Files 221 221
Lines 57475 57482 +7
=======================================
+ Hits 48029 48040 +11
+ Misses 9446 9442 -4
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/arrow-rs/pull/1984?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] viirya commented on pull request #1984: MINOR: Fix clippy error after updating rust toolchain
Posted by GitBox <gi...@apache.org>.
viirya commented on PR #1984:
URL: https://github.com/apache/arrow-rs/pull/1984#issuecomment-1171896947
Thank you @liukun4515 @HaoYang670
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] viirya commented on pull request #1984: MINOR: Fix clippy error after updating rust toolchain
Posted by GitBox <gi...@apache.org>.
viirya commented on PR #1984:
URL: https://github.com/apache/arrow-rs/pull/1984#issuecomment-1171777118
cc @sunchao @tustvold
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] viirya commented on pull request #1984: MINOR: Fix clippy error after updating rust toolchain
Posted by GitBox <gi...@apache.org>.
viirya commented on PR #1984:
URL: https://github.com/apache/arrow-rs/pull/1984#issuecomment-1171883969
cc @alamb too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org