You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "kaxil (via GitHub)" <gi...@apache.org> on 2024/11/23 03:26:17 UTC
[PR] Use Python 3.9 as target version for Ruff & Black rules [airflow]
kaxil opened a new pull request, #44298:
URL: https://github.com/apache/airflow/pull/44298
Since we dropped support of Python 3.8 (after it reach EOL), we missed changing rules for black & ruff.
For reviewers: easier to just review [first commit](https://github.com/apache/airflow/commit/62627fe76de09e5e76b304bba2149623aa4dd960), second commit is auto-mated code
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use Python 3.9 as target version for Ruff & Black rules [airflow]
Posted by "jscheffl (via GitHub)" <gi...@apache.org>.
jscheffl commented on PR #44298:
URL: https://github.com/apache/airflow/pull/44298#issuecomment-2496200543
> And one more here @jscheffl ;) #44328
Hope this was the last one... or shall I go hunting again? :-D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use Python 3.9 as target version for Ruff & Black rules [airflow]
Posted by "kaxil (via GitHub)" <gi...@apache.org>.
kaxil commented on PR #44298:
URL: https://github.com/apache/airflow/pull/44298#issuecomment-2496199953
> And one more here @jscheffl ;) #44328
:D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use Python 3.9 as target version for Ruff & Black rules [airflow]
Posted by "kaxil (via GitHub)" <gi...@apache.org>.
kaxil merged PR #44298:
URL: https://github.com/apache/airflow/pull/44298
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use Python 3.9 as target version for Ruff & Black rules [airflow]
Posted by "kaxil (via GitHub)" <gi...@apache.org>.
kaxil commented on PR #44298:
URL: https://github.com/apache/airflow/pull/44298#issuecomment-2496200099
> Interesting. How can it be that I over-looked the changes in the first commit when removing Python 3.9 support?
All good man
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use Python 3.9 as target version for Ruff & Black rules [airflow]
Posted by "kaxil (via GitHub)" <gi...@apache.org>.
kaxil commented on PR #44298:
URL: https://github.com/apache/airflow/pull/44298#issuecomment-2495809436
> Nice - but seems there are still some troubles with collection changes.
>
>
>
> BTW. I would like - before merge and when green re-run it locally and reapply ruff auto-changes - to see if I come up with small set of reviewable changes (aka - reproducibility check :)
>
>
Done, rebased, ran ruff, force pushed locally
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use Python 3.9 as target version for Ruff & Black rules [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #44298:
URL: https://github.com/apache/airflow/pull/44298#issuecomment-2496199713
And one more here @jscheffl ;) https://github.com/apache/airflow/pull/44328
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use Python 3.9 as target version for Ruff & Black rules [airflow]
Posted by "kaxil (via GitHub)" <gi...@apache.org>.
kaxil commented on PR #44298:
URL: https://github.com/apache/airflow/pull/44298#issuecomment-2495810337
> Interesting. How can it be that I over-looked the changes in the first commit when removing Python 3.9 support?
You already had to many changes to handle :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use Python 3.9 as target version for Ruff & Black rules [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #44298:
URL: https://github.com/apache/airflow/pull/44298#issuecomment-2495749633
Nice - but seems there are still some troubles with collection changes.
BTW. I would like - before merge and when green re-run it locally and reapply ruff auto-changes - to see if I come up with small set of reviewable changes (aka - reproducibility check :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use Python 3.9 as target version for Ruff & Black rules [airflow]
Posted by "kaxil (via GitHub)" <gi...@apache.org>.
kaxil commented on PR #44298:
URL: https://github.com/apache/airflow/pull/44298#issuecomment-2496210999
> > And one more here @jscheffl ;) #44328
>
> Hope this was the last one... or shall I go hunting again? :-D
If you wouldn't be missing such things, I would consider you a bot 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org