[GitHub] [tvm] shingjan commented on pull request #9432: [TIR] Add type hint for TIR

[GitBox <gi...@apache.org>]

shingjan commented on pull request #9432:
URL: https://github.com/apache/tvm/pull/9432#issuecomment-961529551


   right now with `mypy --strict`, the only errors we get are:
   ``` python/tvm/script/tir/__init__.pyi: note: In class "Buffer":
   python/tvm/script/tir/__init__.pyi:44:14: error: Class cannot subclass "Var" (has type "Any")
   python/tvm/script/tir/__init__.pyi: note: In function "prim_func":
   python/tvm/script/tir/__init__.pyi:195:27: error: Missing type parameters for generic type "Callable"
   python/tvm/script/tir/__init__.pyi: note: At top level:
   python/tvm/script/tir/__init__.pyi:208:13: error: Missing type parameters for generic type "ContextManager"
   python/tvm/script/tir/__init__.pyi:212:12: error: Missing type parameters for generic type "ContextManager"
   python/tvm/script/tir/__init__.pyi:215:11: error: Missing type parameters for generic type "ContextManager"
   Found 5 errors in 1 file (checked 1 source file)```
   
   Should be good for another round of review now


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org