[jira] [Commented] (CASSANDRA-5093) Wrong bloom_filter_fp_chance for newly created CFs with LeveledCompactionStrategy

["Jonathan Ellis (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-5093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13540485#comment-13540485 ] 

Jonathan Ellis commented on CASSANDRA-5093:
-------------------------------------------

+1
                
> Wrong bloom_filter_fp_chance for newly created CFs with LeveledCompactionStrategy
> ---------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-5093
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-5093
>             Project: Cassandra
>          Issue Type: Bug
>    Affects Versions: 1.2.0 rc2
>            Reporter: Aleksey Yeschenko
>            Assignee: Aleksey Yeschenko
>            Priority: Minor
>             Fix For: 1.2.0
>
>         Attachments: 5093.txt
>
>
> 0.1 is supposed to be the default bloom_filter_fp_chance for LeveledCompactionStrategy (and 0.01 for all other strategies).
> However, CFPropDefs#applyToCFMetadata() sets bloom_filter_fp_chance before setting compaction strategy class, so the default bloom_filter_fp_chance is always 0.01 no matter what the compaction strategy is.
> The fix is to move cfm#bloomFilterFpChance() call below cfm#compressionParameters().
> The attached patch also kills dead default consistency level-related code.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira