You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/01/03 07:58:09 UTC

[GitHub] [flink] wangxlong opened a new pull request #14541: [FLINK-18778][table-planner] Support the SupportsProjectionPushDown i…

wangxlong opened a new pull request #14541:
URL: https://github.com/apache/flink/pull/14541


   …nterface for LookupTableSource
   
   ## What is the purpose of the change
   
   LookupTableSource supports projection pushing down when implements SupportsProjectionPushDown interface.
   
   ## Brief change log
   
   Add rule `PushCalcIntoTemporalTableSourceRule ` to support projection push into temporal tableSource.
   And add some tests to verify this.
   
   ## Verifying this change
   
   This change added tests and can be verified as follows:
   1. Add PushCalcIntoTemporalTableSourceRuleTest class.
   2. Add some test method to LookupJoinTest, and some tests in LookupJoinTest also verify this.
   3. Some tests in LookupJoinITCase already verify this. 
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #14541: [FLINK-18778][table-planner] Support the SupportsProjectionPushDown i…

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14541:
URL: https://github.com/apache/flink/pull/14541#issuecomment-753582308


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 4cca108c7a3827b8783c8e9f175ba4aec14b86ec (Fri May 28 06:59:39 UTC 2021)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
    * **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-18778).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #14541: [FLINK-18778][table-planner] Support the SupportsProjectionPushDown i…

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14541:
URL: https://github.com/apache/flink/pull/14541#issuecomment-753583193


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a9e0eb0fadc25f5abed52f21d533fd66566ea66d",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11572",
       "triggerID" : "a9e0eb0fadc25f5abed52f21d533fd66566ea66d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * a9e0eb0fadc25f5abed52f21d533fd66566ea66d Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11572) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #14541: [FLINK-18778][table-planner] Support the SupportsProjectionPushDown i…

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14541:
URL: https://github.com/apache/flink/pull/14541#issuecomment-753583193


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a9e0eb0fadc25f5abed52f21d533fd66566ea66d",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11572",
       "triggerID" : "a9e0eb0fadc25f5abed52f21d533fd66566ea66d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * a9e0eb0fadc25f5abed52f21d533fd66566ea66d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11572) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #14541: [FLINK-18778][table-planner] Support the SupportsProjectionPushDown i…

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14541:
URL: https://github.com/apache/flink/pull/14541#issuecomment-753583193


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a9e0eb0fadc25f5abed52f21d533fd66566ea66d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "a9e0eb0fadc25f5abed52f21d533fd66566ea66d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * a9e0eb0fadc25f5abed52f21d533fd66566ea66d UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #14541: [FLINK-18778][table-planner] Support the SupportsProjectionPushDown i…

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14541:
URL: https://github.com/apache/flink/pull/14541#issuecomment-753582308


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit a9e0eb0fadc25f5abed52f21d533fd66566ea66d (Sun Jan 03 08:01:04 UTC 2021)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #14541: [FLINK-18778][table-planner] Support the SupportsProjectionPushDown i…

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14541:
URL: https://github.com/apache/flink/pull/14541#issuecomment-753583193


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a9e0eb0fadc25f5abed52f21d533fd66566ea66d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11572",
       "triggerID" : "a9e0eb0fadc25f5abed52f21d533fd66566ea66d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4cca108c7a3827b8783c8e9f175ba4aec14b86ec",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11574",
       "triggerID" : "4cca108c7a3827b8783c8e9f175ba4aec14b86ec",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 4cca108c7a3827b8783c8e9f175ba4aec14b86ec Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11574) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #14541: [FLINK-18778][table-planner] Support the SupportsProjectionPushDown i…

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14541:
URL: https://github.com/apache/flink/pull/14541#issuecomment-753583193


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a9e0eb0fadc25f5abed52f21d533fd66566ea66d",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11572",
       "triggerID" : "a9e0eb0fadc25f5abed52f21d533fd66566ea66d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4cca108c7a3827b8783c8e9f175ba4aec14b86ec",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "4cca108c7a3827b8783c8e9f175ba4aec14b86ec",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * a9e0eb0fadc25f5abed52f21d533fd66566ea66d Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11572) 
   * 4cca108c7a3827b8783c8e9f175ba4aec14b86ec UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #14541: [FLINK-18778][table-planner] Support the SupportsProjectionPushDown i…

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14541:
URL: https://github.com/apache/flink/pull/14541#issuecomment-753583193


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a9e0eb0fadc25f5abed52f21d533fd66566ea66d",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11572",
       "triggerID" : "a9e0eb0fadc25f5abed52f21d533fd66566ea66d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4cca108c7a3827b8783c8e9f175ba4aec14b86ec",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11574",
       "triggerID" : "4cca108c7a3827b8783c8e9f175ba4aec14b86ec",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 4cca108c7a3827b8783c8e9f175ba4aec14b86ec Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11574) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #14541: [FLINK-18778][table-planner] Support the SupportsProjectionPushDown i…

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14541:
URL: https://github.com/apache/flink/pull/14541#issuecomment-753583193


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a9e0eb0fadc25f5abed52f21d533fd66566ea66d",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11572",
       "triggerID" : "a9e0eb0fadc25f5abed52f21d533fd66566ea66d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "4cca108c7a3827b8783c8e9f175ba4aec14b86ec",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11574",
       "triggerID" : "4cca108c7a3827b8783c8e9f175ba4aec14b86ec",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * a9e0eb0fadc25f5abed52f21d533fd66566ea66d Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11572) 
   * 4cca108c7a3827b8783c8e9f175ba4aec14b86ec Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11574) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org