You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by GitBox <gi...@apache.org> on 2021/12/23 17:26:55 UTC
[GitHub] [cassandra] HadesArchitect opened a new pull request #1371: CAS-17184: Add += and -= syntax to ALTER TABLE WITH
HadesArchitect opened a new pull request #1371:
URL: https://github.com/apache/cassandra/pull/1371
**INITIAL PROPOSAL, NOT READY FOR MERGE**
Description: TBD
At the moment the only purpose of the PR is to discuss the suggested prototype implementation.
* Issue: https://issues.apache.org/jira/browse/CASSANDRA-17184?jql=labels%20%3D%20AdventCalendar2021
* Expected behavior: https://github.com/apache/cassandra/compare/trunk...HadesArchitect:trunk#diff-60155f5fd589ec7d5d5cba38462b429d211fa0c70a3c3283972dd6e865c1eebbR265
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] HadesArchitect commented on pull request #1371: CAS-17184: Add += and -= syntax to ALTER TABLE WITH
Posted by GitBox <gi...@apache.org>.
HadesArchitect commented on pull request #1371:
URL: https://github.com/apache/cassandra/pull/1371#issuecomment-1000847307
Hey @Gerrrr, thanks for the review and ideas. Sure I'll add more tests when the general approach will be approved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] HadesArchitect commented on a change in pull request #1371: CAS-17184: Add += and -= syntax to ALTER TABLE WITH
Posted by GitBox <gi...@apache.org>.
HadesArchitect commented on a change in pull request #1371:
URL: https://github.com/apache/cassandra/pull/1371#discussion_r774702339
##########
File path: src/java/org/apache/cassandra/cql3/statements/PropertyDefinitions.java
##########
@@ -24,57 +24,82 @@
import org.slf4j.LoggerFactory;
import org.apache.cassandra.exceptions.SyntaxException;
+import org.mortbay.io.nio.SelectorManager;
Review comment:
I have no idea how did it get there... Will remove.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] HadesArchitect commented on pull request #1371: CAS-17184: Add += and -= syntax to ALTER TABLE WITH
Posted by GitBox <gi...@apache.org>.
HadesArchitect commented on pull request #1371:
URL: https://github.com/apache/cassandra/pull/1371#issuecomment-1000439106
@blerer Here we go
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org